https://bitbucket.org/petsc/petsc/pull-requests/1834/remove-testing-and-inserting-into/diff
removed about 1/3 of the entries for a build with about 10 external packages
perhaps there are a small number of entries that may still be removed but I
think I got rid of most the unneeded ones.
Matthew Knepley writes:
> On Sat, Jun 29, 2019 at 8:39 AM Jed Brown wrote:
>
>> Matthew Knepley writes:
>>
>> > On Fri, Jun 28, 2019 at 4:37 PM Jed Brown wrote:
>> >
>> >> Matthew Knepley writes:
>> >>
>> >> > On Fri, Jun 28, 2019 at 2:04 PM Smith, Barry F. via petsc-dev <
>> >> >
Matthew Knepley writes:
> On Fri, Jun 28, 2019 at 4:37 PM Jed Brown wrote:
>
>> Matthew Knepley writes:
>>
>> > On Fri, Jun 28, 2019 at 2:04 PM Smith, Barry F. via petsc-dev <
>> > petsc-dev@mcs.anl.gov> wrote:
>> >
>> >>
>> >> You are right, these do not belong in petscconf.h
>> >>
>> >
>>
On Fri, Jun 28, 2019 at 4:37 PM Jed Brown wrote:
> Matthew Knepley writes:
>
> > On Fri, Jun 28, 2019 at 2:04 PM Smith, Barry F. via petsc-dev <
> > petsc-dev@mcs.anl.gov> wrote:
> >
> >>
> >> You are right, these do not belong in petscconf.h
> >>
> >
> > The problematic thing here is hiding
Matthew Knepley writes:
> On Fri, Jun 28, 2019 at 2:04 PM Smith, Barry F. via petsc-dev <
> petsc-dev@mcs.anl.gov> wrote:
>
>>
>> You are right, these do not belong in petscconf.h
>>
>
> The problematic thing here is hiding information from users of
> PETSc. If you are a user that counts on
Some of the material collected could go into another file that is stored in
the same location available to users but not included by PETSc source.
Other material like PETSC_HAVE_LIBPNETCDF doesn't seem to be worthing putting
in include files. We already have the macros PETSC_HAVE_PNETCDF
You are right, these do not belong in petscconf.h
Barry
> On Jun 28, 2019, at 12:37 PM, Jed Brown via petsc-dev
> wrote:
>
> We have a lot of lines like this
>
> $ grep -c HAVE_LIB $PETSC_ARCH/include/petscconf.h
> 96
>
> but only four of these are ever checked in src/. Delete them?
We have a lot of lines like this
$ grep -c HAVE_LIB $PETSC_ARCH/include/petscconf.h
96
but only four of these are ever checked in src/. Delete them?
IMO, unused stuff should not go into petscconf.h. We have to scroll up
past these lines every time configure crashes. These are apparently all
