[petsc-dev] Why separate PCASMGetSubKSP/PCGASMGetSubKSP/PCBJacobiGetSubKSP?

2017-09-20 Thread Richard Tran Mills
Folks, I see that we have separate interface routines PCASMGetSubKSP(), PCGASMGetSubKSP(), and PCBJacobiGetSubKSP(), all of which have an identical interface and do the same thing. It seems like there ought to instead be just one routine called something like PCGetSubKSP(). Is there a good reason

Re: [petsc-dev] Why separate PCASMGetSubKSP/PCGASMGetSubKSP/PCBJacobiGetSubKSP?

2017-09-20 Thread Barry Smith
I think it is mostly historical reasons, we never refactored to have a common API and use the PetscUseMethod() to implement. I'd be happy to consider a refactorization in a pull request. > On Sep 20, 2017, at 6:08 PM, Richard Tran Mills wrote: > > Folks, > > I see that we have separate in