Re: [petsc-dev] fixing bugs in resolution of TSEvent's

2023-07-18 Thread Barry Smith via petsc-dev
We are aware of "issues" with TSEvent and appreciate you working on it. Another user reported problems last week https://gitlab.com/petsc/petsc/-/issues/1414 which we resolved in an associated MR, you might want to check those changes to see how/if they would interact with your MR. As that

Re: [petsc-dev] fixing bugs in resolution of TSEvent's

2023-07-17 Thread Matthew Knepley
On Mon, Jul 17, 2023 at 10:55 AM Ilya Fursov wrote: > Dear to whom is may concern, > > A while ago I tried to use TS events in my time stepping code, and I found > erroneous behaviour of the event resolution algorithm. For that particular > example it resulted in long series of extremely small ti

Re: [petsc-dev] fixing bugs in resolution of TSEvent's

2023-07-17 Thread Stefano Zampini
Dear Ilya Thanks for your willing to contribute back to PETSc. Please submit a PR from the main branch. We do not allow API changes from minor patch versions. Thanks Stefano On Mon, Jul 17, 2023, 16:55 Ilya Fursov wrote: > Dear to whom is may concern, > > A while ago I tried to use TS events i

[petsc-dev] fixing bugs in resolution of TSEvent's

2023-07-17 Thread Ilya Fursov
Dear to whom is may concern, A while ago I tried to use TS events in my time stepping code, and I found erroneous behaviour of the event resolution algorithm. For that particular example it resulted in long series of extremely small time steps. After examining the TSEvent handler code, I found som