Patch for sqleditor js syntax issue

Hi, Please find attached minor patch which fixes js syntax issue in sqleditor.js -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js b/web/pgad

Re: [pgAdmin4][Patch] To fix the duplicate entry in History panel

Nice! Looks good. We were investigating this bug before you sent this and it looks like your patch resolves the duplicate calls to update_msg_history Cheers, Sarah and George On Fri, Jun 30, 2017 at 1:14 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch

Re: [pgAdmin4][Patch]: Refactor of the History Tab

> On 30 Jun 2017, at 18:00, Surinder Kumar > wrote: > > ​Hi, > > Review comments: > > 1) I see the font used for class .query-history .entry​ is monospace, > shouldn't it be Helvetica as per style guide ? the font for Messages > text > is also monospace. No, the style guide needs an entry

Re: [pgAdmin4][Patch]: Refactor of the History Tab

Hi, On Fri, Jun 30, 2017 at 10:30 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > ​Hi, > > Review comments: > > 1) I see the font used for class .query-history .entry​ is monospace, > shouldn't it be Helvetica as per style guide ? the font for Messages > text > is also monospace. >

[pgAdmin4][Patch] To fix the duplicate entry in History panel

Hi, PFA minor patch to fix the issue where duplicate entry is made of successful executed query one with status message and one without status message. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/sqledito

Re: Tree view icon samples

Dave et al, Might I suggest flipping the foreign key icon left for right? That way, the key "points" to the left, back toward something pre-existing whilst the primary key "points" to the right, forward towards something new? Also, for me, the updated index icon loses its intuitiveness as it sugg

Re: [pgAdmin4][Patch]: Refactor of the History Tab

Surinder, It would be great if you could take a look at this an see if the style changes are more inline with what you were thinking when you commented on the first patch. -- Rob On Fri, Jun 30, 2017 at 11:55 AM, Shruti Iyer wrote: > Hi Hackers, > > Attached is the patch that refactors the rea

[pgAdmin4][Patch]: Refactor of the History Tab

Hi Hackers, Attached is the patch that refactors the react components that supports the history detail pane. We moved inline styling. whenever possible, to scss. Thanks, Joao and Shruti refactor-react-history.diff Description: Binary data

Re: Tree view icon samples

Hi - The Primary Key and Foreign Key icons should have more differentiation than just colour. Maybe add a 1 to Primary Key? - Did you get a list of the other icons that aren't on that sheet yet? - I'm not sure I like the Casts and Conversions icons (mis-spelt as Converts by the previous owner).

[pgAdmin4][Patch] To fix the issues in Debugger module

Hi, Please find patch to fix the below issues, 1) Debugger page layout RM#2512 2) To fix the issue when you user clicks on Stop button and gets connection lost error. RM#2511 @Dave, When we stop the debugger using pldbg_abort_target() function and try to start it again in the same connection, w

Jenkins build is back to normal : pgadmin4-master-python33 #208

See

Re: UI issue

Thanks, applied. I also renamed the variable to something more suitable. On Fri, Jun 30, 2017 at 12:49 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch for the same. > This is due to my precious patch. > > Thanks, > Khushboo > > On Fri, Jun 30,

pgAdmin 4 commit: Fix typo that caused a layout issue with the Edit Gri

Fix typo that caused a layout issue with the Edit Grid. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7c09a8f8272e9d697ea9f8cfddf6f3a34a4d9fe9 Author: Khushboo Vashi Modified Files -- web/pgadmin/tools/datagrid/templates/datagri

Re: Tree view icon samples

Hello Team, Below are the updates for TreeView Icons - 1. Fine tuned the icons - Database, Language, Primary and Foreign key, Unique Constraint 2. Designed new concept for - Casts and Converts, Trigger 3. Attached the color blind test result for "Primary and Foreign key", now I feel it is pretty

Re: UI issue

Hi, Please find the attached patch for the same. This is due to my precious patch. Thanks, Khushboo On Fri, Jun 30, 2017 at 5:06 PM, Dave Page wrote: > > > On Fri, Jun 30, 2017 at 12:29 PM, Dave Page wrote: > >> >> >> On Fri, Jun 30, 2017 at 12:25 PM, Dave Page wrote: >> >>> >>> >>> On Fri,

Re: UI issue

On Fri, Jun 30, 2017 at 12:29 PM, Dave Page wrote: > > > On Fri, Jun 30, 2017 at 12:25 PM, Dave Page wrote: > >> >> >> On Fri, Jun 30, 2017 at 12:23 PM, Harshal Dhumal < >> harshal.dhu...@enterprisedb.com> wrote: >> >>> >>> >>> On Fri, Jun 30, 2017 at 4:39 PM, Dave Page wrote: >>> >>>

Re: [pgAdmin4]: Webpacking of static JS/CSS

Awesome work. Do you have an ETA for a feature complete test patch? On Fri, Jun 30, 2017 at 11:41 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > So far, I have been able to generate bundled > 'sources/generated/browser.js' which contains only three browser modules > (Server

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hi So far, I have been able to generate bundled 'sources/generated/browser.js' which contains only three browser modules (Server-group, Server, Database) and load it from 'browser/index.html'(entry point) and it works(except few JS error present in file). so will fix them. Then I will add one by

Build failed in Jenkins: pgadmin4-master-python33 #207

See Changes: [Dave Page] Fix a couple of gripes from the JS linter on Windows. -- [...truncated 289.08 KB...] Update materialized view under schema node ... ok ru

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hi On Fri, Jun 30, 2017 at 2:29 AM, George Gelashvili wrote: > Hey Surinder, > > > ​1. ​ >> Tools >> ​(tools.js)​ - It will contain all JS modules under tools directory >> >> >> ​2. ​ >> Browser >> ​(browser.js)​ - It will contain all JS modules under browser directory >> > > By under, do you m

pgAdmin 4 commit: Fix a couple of gripes from the JS linter on Windows.

Fix a couple of gripes from the JS linter on Windows. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ffb00b502ab149234b27aeaf38d418707bb6085a Modified Files -- .../event_handlers/handle_query_output_keyboard_event_spec.js|

Re: [pgadmin-hackers][Patch] Change alert styling

OK, thanks - patch applied. Note to all hackers: As we modify our override CSS moving forwards, it should be migrated to SCSS, and use the defined colour variable names. Thanks. On Thu, Jun 29, 2017 at 2:25 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi! > > Are you c

pgAdmin 4 commit: Update alertify alerts to use the styling defined in

Update alertify alerts to use the styling defined in the styleguide (missed some files in the original commit). Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f2d2075d81718ec02550fb592851aa330d327b24 Author: Joao Pedro De Almeida Pereira Mo

pgAdmin 4 commit: Update alertify alerts to use the styling defined in

Update alertify alerts to use the styling defined in the styleguide. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2a30a86e7d5e562040500f448fbb0d143ff2cff9 Author: Joao Pedro De Almeida Pereira Modified Files -- .../servers/data

pgAdmin 4 commit: Add support for SCSS building in webpack.

Add support for SCSS building in webpack. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ba3ab7b322ef940a53e2e4309b39855d1bac0b66 Author: Joao Pedro De Almeida Pereira Modified Files -- web/package.json | 3

Re: [pgAdmin4][Patch]: Feature #2506 - Allow the dashboard panel to be closed

Thanks - seems to work for me :-). Patch applied. On Thu, Jun 29, 2017 at 1:35 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Wed, Jun 28, 2017 at 7:08 PM, Dave Page wrote: > >> Hi >> >> On Tue, Jun 27,

pgAdmin 4 commit: Allow the dashboard panel to be closed. Fixes #2506

Allow the dashboard panel to be closed. Fixes #2506 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=501120701eecfda0fed14dcc11edf54f2ac333f3 Author: Khushboo Vashi Modified Files -- web/pgadmin/browser/static/js/panel.js

Re: [RM2522] Improve grid/column select all operation

On Fri, Jun 30, 2017 at 9:39 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > This patch is not related to improve copy/past operation. It's only > related to grid selection. > The improvement is only between when user clicks on grid select all column > to until all row are s

pgAdmin 4 commit: Improve speed of Select All in the results grid. Fixe

Improve speed of Select All in the results grid. Fixes #2522 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2d653129108179af270a5cd6e65b758d437f6176 Author: Harshal Dhumal Modified Files -- web/pgadmin/static/js/selection/range_s

Re: [RM2522] Improve grid/column select all operation

Hi, This patch is not related to improve copy/past operation. It's only related to grid selection. The improvement is only between when user clicks on grid select all column to until all row are selected (turned into blue). With large columns though improvement is not large but it not putting any

Re: [RM2522] Improve grid/column select all operation

On Fri, Jun 30, 2017 at 8:57 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > I guess so, number of columns do have overhead on selection & copy/paste > operation because of arbitrary copy paste feature, now we have to scan > start cell (first selected cell) & end cell (last se

Re: [RM2522] Improve grid/column select all operation

++ Corrected sentence On Fri, Jun 30, 2017 at 1:27 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > I guess so, number of columns do have overhead on selection & copy/paste > operation because of arbitrary copy paste feature, now we have to scan > start cell (first selected ce

Re: [RM2522] Improve grid/column select all operation

I guess so, number of columns do have overhead on selection & copy/paste operation because of arbitrary copy paste feature, now we have to scan start cell (first selected cell) & end cell (last selected cell) for each row, In old code we were selecting complete row which was fast but now user can s