Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

2017-07-10 Thread Shirley Wang
I noticed that the default font, Menlo, was disabled in favor of Monospace. Was there a specific reason why Monospace was used in favor of Menlo? I find that Menlo is an easier font to read, especially for uppercase letters. For web apps, sans-serif fonts are used (fonts without the little notch,

Re: Windows testing required: Updated runtime

2017-07-10 Thread Eric Hirst
FYI, this new version appears to resolve the following issue for me. Thanks for your work on this. -Eric Bug #2255: Latency issues make tool unusable in remote desktop On Mon, Jul 10, 2017 at 12:00 PM, Jeff Janes

[pgadmin-hackers][pgaweb][patch] Website patch to add SCSS

2017-07-10 Thread Joao De Almeida Pereira
Hi Hackers, In this email you will be able to find the first patches to start the migration of the Styleguide from http://pgadmin4-styleguide.cfapps.io/ to the pgadmin.org webpage. The first patch adds a Readme to the project and also the yarn.lock file The second patch: - Adds SCSS processor to

Jenkins build is back to normal : pgadmin4-master-python35 #233

2017-07-10 Thread pgAdmin 4 Jenkins
See

Re: [pgAdmin4][Patch]: Fixed #2550 declarative partitioning - drop/delete and drop cascade is not working for partition table

2017-07-10 Thread Dave Page
Thanks, applied. On Mon, Jul 10, 2017 at 3:28 PM, Akshay Joshi wrote: > Hi All > > Attached is the patch file to fix the RM #2550, where user will not be > able to drop/drop cascade partitions. Apart from that RM this patch > contains following fix: > >-

Jenkins build is back to normal : pgadmin4-master-python27 #237

2017-07-10 Thread pgAdmin 4 Jenkins
See

Jenkins build is back to normal : pgadmin4-master-python34 #223

2017-07-10 Thread pgAdmin 4 Jenkins
See

Jenkins build is back to normal : pgadmin4-master-python33 #232

2017-07-10 Thread pgAdmin 4 Jenkins
See

pgAdmin 4 commit: Fix alignment of Object > delete/drop & properties ic

2017-07-10 Thread Dave Page
Fix alignment of Object > delete/drop & properties icons Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2bfe640a081cc59a22453c3db847817406cb6651 Author: Surinder Kumar Modified Files --

Build failed in Jenkins: pgadmin4-master-python35 #232

2017-07-10 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Couple of typos in the release notes. -- [...truncated 317.24 KB...] ResourceGroupsDeleteTestCase (Delete resource

Object > delete/drop and properties menu icons misaligned

2017-07-10 Thread Surinder Kumar
Hi Object > delete/drop & properties icons are now misaligned. This is regression of commit d56f1d847c946f43bebbfbdefb929870f0050694 I found the lack of information why these changes were

Build failed in Jenkins: pgadmin4-master-python36 #228

2017-07-10 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Couple of typos in the release notes. -- [...truncated 317.21 KB...] PackageAddTestCase (Fetch Package Node URL)

Build failed in Jenkins: pgadmin4-master-python33 #231

2017-07-10 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Bump version numbers prior to release. [Dave Page] Couple of typos in the release notes. -- [...truncated 317.34 KB...]

Re: pgAdmin 4 commit: Release notes for 1.6.

2017-07-10 Thread Dave Page
Thanks, fixed. On Mon, Jul 10, 2017 at 3:14 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, > > Below corrections required in release notes. > > Feature #2137: > 1) Redmine link is pointing to issue 2437 it should be 2137 > 2) Feature title should On-demand loading for

Build failed in Jenkins: pgadmin4-master-python27 #236

2017-07-10 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Couple of typos in the release notes. -- [...truncated 317.73 KB...] Detach partition from

Build failed in Jenkins: pgadmin4-master-python35 #231

2017-07-10 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Release notes for 1.6. [Dave Page] Bump version numbers prior to release. -- [...truncated 317.23 KB...]

Re: pgagent build issue on SLES 12

2017-07-10 Thread Devrim Gündüz
Hi, On Mon, 2017-07-10 at 14:01 +0100, Dave Page wrote: > I have no idea if pgAgent will work with wxWidgets 3. Are there wx 2.8 > packages available? Ah, that fixed it (the package names in SLES are different than Red Hat, it took me a while to find the right package) That said, reminder for

Build failed in Jenkins: pgadmin4-master-python26 #353

2017-07-10 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Release notes for 1.6. [Dave Page] Bump version numbers prior to release. [Dave Page] Couple of typos in the release notes. --

[pgAdmin4][Patch]: Fixed #2550 declarative partitioning - drop/delete and drop cascade is not working for partition table

2017-07-10 Thread Akshay Joshi
Hi All Attached is the patch file to fix the RM #2550, where user will not be able to drop/drop cascade partitions. Apart from that RM this patch contains following fix: - Update the SQL query to fix the jenkins build. - Use AlertifyWrapper in Partition.js - Fix the icon while 'truncate

Build failed in Jenkins: pgadmin4-master-python27 #235

2017-07-10 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Release notes for 1.6. [Dave Page] Bump version numbers prior to release. -- [...truncated 317.73 KB...]

pgAdmin 4 commit: Couple of typos in the release notes.

2017-07-10 Thread Dave Page
Couple of typos in the release notes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7aa7ea0fe2eede85cbb95c3fe69bdbe6496b5cd8 Author: Harshal Dhumal Modified Files --

Re: pgAdmin 4 commit: Release notes for 1.6.

2017-07-10 Thread Harshal Dhumal
Hi Dave, Below corrections required in release notes. Feature #2137: 1) Redmine link is pointing to issue 2437 it should be 2137 2) Feature title should On-demand loading for the query tool result and not Fixed Row selection issue and row past issue. Fearture# 2191: 1) Redmine link is pointing

Build failed in Jenkins: pgadmin4-master-python34 #221

2017-07-10 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Release notes for 1.6. [Dave Page] Bump version numbers prior to release. -- [...truncated 317.17 KB...]

Build failed in Jenkins: pgadmin4-master-python36 #227

2017-07-10 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Release notes for 1.6. [Dave Page] Bump version numbers prior to release. -- [...truncated 317.14 KB...]

Build failed in Jenkins: pgadmin4-master-python33 #230

2017-07-10 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Release notes for 1.6. -- [...truncated 317.19 KB...] Attach partition to existing range

pgAdmin 4 commit: Bump version numbers prior to release.

2017-07-10 Thread Dave Page
Bump version numbers prior to release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ea5dfe23a078080d98d8a549ff48efbdbc677974 Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +- web/config.py| 4

Build failed in Jenkins: pgadmin4-master-python26 #352

2017-07-10 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Handle partitioned tables created "OF TYPE". Fixes #2545 -- [...truncated 321.98 KB...] Attach

Build failed in Jenkins: pgadmin4-master-python35 #230

2017-07-10 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Handle partitioned tables created "OF TYPE". Fixes #2545 -- [...truncated 317.20 KB...] Create

Build failed in Jenkins: pgadmin4-master-python36 #226

2017-07-10 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Handle un-mounted drives correctly on Windows. Fixes #1999 [Dave Page] Handle partitioned tables created "OF TYPE". Fixes #2545 --

Build failed in Jenkins: pgadmin4-master-python27 #234

2017-07-10 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Handle un-mounted drives correctly on Windows. Fixes #1999 [Dave Page] Handle partitioned tables created "OF TYPE". Fixes #2545 --

Build failed in Jenkins: pgadmin4-master-python34 #220

2017-07-10 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix IE11 alert layout again. [Dave Page] Handle un-mounted drives correctly on Windows. Fixes #1999 [Dave Page] Handle partitioned tables created "OF TYPE". Fixes #2545

Build failed in Jenkins: pgadmin4-master-python33 #229

2017-07-10 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix IE11 alert layout again. [Dave Page] Handle un-mounted drives correctly on Windows. Fixes #1999 [Dave Page] Handle partitioned tables created "OF TYPE". Fixes #2545

Re: [pgAdmin4][Patch]: Fixed RM #1165 - Too many request to update dashboard graphs when server is disconnected.

2017-07-10 Thread Dave Page
Hi On Mon, Jul 10, 2017 at 2:14 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM #1165 - Too many request to > update dashboard graphs when server is disconnected. > If I disconnect the server, it doesn't stop trying to get data

Re: [pgAdmin4][Patch]: Fixed #2545 Partitioned table should be created using 'OF TYPE'

2017-07-10 Thread Dave Page
Thanks, applied. On Mon, Jul 10, 2017 at 1:30 PM, Akshay Joshi wrote: > Hi All > > Attached is the patch file to fix the RM #2545, where user will be able to > create partitioned table using 'OF TYPE' feature of table dialog. > > -- > *Akshay Joshi* > *Principal

pgAdmin 4 commit: Handle partitioned tables created "OF TYPE". Fixes #2

2017-07-10 Thread Dave Page
Handle partitioned tables created "OF TYPE". Fixes #2545 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ed3cb7df417b3e0b4a1dc3da8d4224a09727412e Author: Akshay Joshi Modified Files --

[pgAdmin4][Patch]: Fixed RM #1165 - Too many request to update dashboard graphs when server is disconnected.

2017-07-10 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #1165 - Too many request to update dashboard graphs when server is disconnected. Thanks, Khushboo diff --git a/web/pgadmin/dashboard/templates/dashboard/js/dashboard.js b/web/pgadmin/dashboard/templates/dashboard/js/dashboard.js index

Re: [pgAdmin4][Patch] To fix "there is no disk..." warning in Windows

2017-07-10 Thread Dave Page
Thanks, applied. On Mon, Jul 10, 2017 at 1:26 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue in Windows where Windows throws warning "there > is no disk..." if user do not have a removable disk in the removable disk > drive while opening

pgAdmin 4 commit: Handle un-mounted drives correctly on Windows. Fixes

2017-07-10 Thread Dave Page
Handle un-mounted drives correctly on Windows. Fixes #1999 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6d3d2cd458aa74c677559a3c3b3c2fb44da4aa6f Author: Murtuza Zabuawala Modified Files --

Re: pgagent build issue on SLES 12

2017-07-10 Thread Devrim Gündüz
Hi Ashesh, On Mon, 2017-07-10 at 17:56 +0530, Ashesh Vashi wrote: > You can find the logs/temporary files in the CMakeFiles directory. I have sent the log file with the previous email: https://www.gunduz.org/temp/pgagent-CMakeOutput.log Regards, -- Devrim Gündüz EnterpriseDB:

Re: pgagent build issue on SLES 12

2017-07-10 Thread Dave Page
On Mon, Jul 10, 2017 at 1:59 PM, Devrim Gündüz wrote: > > Hi Dave, > > On Mon, 2017-07-10 at 13:18 +0100, Dave Page wrote: > > What wxWidgets configs are available on that machine? > > wxWidgets-3_2-devel-3.1.0 > I have no idea if pgAgent will work with wxWidgets 3. Are there

Re: pgagent build issue on SLES 12

2017-07-10 Thread Devrim Gündüz
Hi Dave, On Mon, 2017-07-10 at 13:18 +0100, Dave Page wrote: > What wxWidgets configs are available on that machine? wxWidgets-3_2-devel-3.1.0 is installed. I also have a few packages that start with libwx_gtk2 and libwx_gtk3, but not sure they are related. Regards, -- Devrim Gündüz

[pgAdmin4][Patch]: Fixed #2545 Partitioned table should be created using 'OF TYPE'

2017-07-10 Thread Akshay Joshi
Hi All Attached is the patch file to fix the RM #2545, where user will be able to create partitioned table using 'OF TYPE' feature of table dialog. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_2545.patch Description: Binary data

Re: pgagent build issue on SLES 12

2017-07-10 Thread Ashesh Vashi
You can find the logs/temporary files in the CMakeFiles directory. On Jul 10, 2017 17:48, "Dave Page" wrote: > > > On Mon, Jul 10, 2017 at 12:59 PM, Devrim Gündüz wrote: > >> >> Hi, >> >> I'm trying to RPMify pgagent on SLES 12, but getting an error. Here

Re: [pgAdmin4][Patch]: Fixed #2532 - Left side tree: The node disappears on update if there is only one child exist for that category.

2017-07-10 Thread Dave Page
Thanks, patch applied. On Mon, Jul 10, 2017 at 7:07 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM #2532 : Left side tree: The > node disappears on update if there is only one child exist for that > category. > > > Thanks, >

pgAdmin 4 commit: Refresh nodes correctly when there is a single child

2017-07-10 Thread Dave Page
Refresh nodes correctly when there is a single child that is updated. Fixes #2532 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ecd95141f3c89aa19e6723799c6cfe41db066d22 Author: Khushboo Vashi Modified

Re: pgagent build issue on SLES 12

2017-07-10 Thread Dave Page
On Mon, Jul 10, 2017 at 12:59 PM, Devrim Gündüz wrote: > > Hi, > > I'm trying to RPMify pgagent on SLES 12, but getting an error. Here is the > command I'm using (like I did for RHEL) > > cmake -D CMAKE_INSTALL_PREFIX:PATH=/usr -D >

pgagent build issue on SLES 12

2017-07-10 Thread Devrim Gündüz
Hi, I'm trying to RPMify pgagent on SLES 12, but getting an error. Here is the command I'm using (like I did for RHEL) cmake -D CMAKE_INSTALL_PREFIX:PATH=/usr -D PG_CONFIG_PATH:FILEPATH=/usr/pgsql-9.6/bin/pg_config -D STATIC_BUILD:BOOL=OFF Error is: CMake Error at cmake/FindWX.cmake:271

Jenkins build is back to normal : pgadmin4-master-python35 #227

2017-07-10 Thread pgAdmin 4 Jenkins
See

pgAdmin 4 commit: Fix history font on IE.

2017-07-10 Thread Dave Page
Fix history font on IE. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2dfa6223574d6a16bc5144462a1e440df80649d4 Modified Files -- web/pgadmin/static/scss/_typography.scss | 8 1 file changed, 4 insertions(+), 4

pgAdmin 4 commit: Use the correct font for alerts on IE.

2017-07-10 Thread Dave Page
Use the correct font for alerts on IE. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=907c5fe1984ead9d1df1c7d0dbe458f9ab607488 Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin4][patch] fix history panel on ie11

2017-07-10 Thread Dave Page
Thanks, applied. On Sat, Jul 8, 2017 at 12:03 AM, Sarah McAlear wrote: > Hi Hackers! > > This patch fixes the layout issues on IE11. There is a known issue on > react-split-pane that requires a previous version of bowser in order to > render correctly on IE11. We had to

[pgAdmin4][Patch]: Fixed #2532 - Left side tree: The node disappears on update if there is only one child exist for that category.

2017-07-10 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #2532 : Left side tree: The node disappears on update if there is only one child exist for that category. Thanks, Khushboo diff --git a/web/pgadmin/browser/templates/browser/js/browser.js b/web/pgadmin/browser/templates/browser/js/browser.js