Re: pgAdmin 4 v1.6 Released!

2017-07-18 Thread Pawel Hadam
Hi Dave, Thank you for this advise. Please find attached my files: 1) C:\Users\pawelhadam\AppData\Roaming\pgAdmin\pgadmin4.log I cannot understand why this log file says "Starting pgAdmin 4 v1.5..." as I have installed v1.6 from pgadmin4-1.6-x86.exe 2) C:\Program Files (x86)\pgAdmin 4\v1\web\c

Re: Build failed in Jenkins: pgadmin4-master-python27-feature #8

2017-07-18 Thread Harshal Dhumal
On Tue, Jul 18, 2017 at 9:33 PM, pgAdmin 4 Jenkins wrote: > See feature/8/display/redirect?page=changes> > > Changes: > > [Dave Page] Use client-side url_for in the sql editor and data grid > modules. > > [Dave Page] Ensure revoked publ

Build failed in Jenkins: pgadmin4-master-python27-feature #8

2017-07-18 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Use client-side url_for in the sql editor and data grid modules. [Dave Page] Ensure revoked public privileges are displayed in the RE-SQL for [Dave Page] Ensure saved pas

Jenkins build is back to normal : pgadmin4-master-python34 #236

2017-07-18 Thread pgAdmin 4 Jenkins
See

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-18 Thread Murtuza Zabuawala
Great job Surinder, Load time ~2 sec on browser :) [image: Inline image 1] -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jul 18, 2017 at 9:01 PM, Dave Page wrote: > Thanks, applied. > > On Tue, Jul 18, 2017 at 4:12 PM, Surind

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-18 Thread Dave Page
Thanks, applied. On Tue, Jul 18, 2017 at 4:12 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > 1. As Slickgrid has dependency of `jQuery-ui`, it was missed. now added. > 2. Column sorting for collection nodes sometimes failing when clicked on > different collection nodes. > >

pgAdmin 4 commit: Resolve an issue where collection nodes sometimes wou

2017-07-18 Thread Dave Page
Resolve an issue where collection nodes sometimes wouldn't sort properly. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b90d368ee7bf8a029378cd70f577e24e05e1c13f Author: Surinder Kumar Modified Files -- web/pgadmin/static/js/back

pgAdmin 4 commit: Add a missing dependency.

2017-07-18 Thread Dave Page
Add a missing dependency. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=659aeeb58e6a91f67b546e1d3fa06735cf453c68 Author: Surinder Kumar Modified Files -- web/pgadmin/static/bundle/slickgrid.js | 1 + 1 file changed, 1 insertion(+

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-18 Thread Surinder Kumar
Hi 1. As Slickgrid has dependency of `jQuery-ui`, it was missed. now added. 2. Column sorting for collection nodes sometimes failing when clicked on different collection nodes. Please find attached patch. Thanks Surinder On Tue, Jul 18, 2017 at 8:20 PM, Khushboo Vashi < khushboo.va...@enterpris

Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] data in datagrid

2017-07-18 Thread Dave Page
On Tue, Jul 18, 2017 at 2:40 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, > > On Tue, Jul 18, 2017 at 1:24 PM, Dave Page wrote: > >> >> >> On Tue, Jul 18, 2017 at 8:26 AM, Harshal Dhumal < >> harshal.dhu...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> >>> On Mon, Ju

Build failed in Jenkins: pgadmin4-master-python34 #235

2017-07-18 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Webpack all the things! Fixes #2135 [Dave Page] Add missing new files from the previous commit. Ooops. [Dave Page] Support SSL in the regression tests. Fixes #2170 ---

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-18 Thread Khushboo Vashi
On Tue, Jul 18, 2017 at 7:46 PM, Dave Page wrote: > Thanks - applied! > > Awesome work - on an average of 3 tests on my Mac, load time reduced from > 11.55s with v1.6 to 5.53s with GIT Head. > > Surinder, great work... > On Mon, Jul 17, 2017 at 5:57 PM, Surinder Kumar < > surinder.ku...@enterpr

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-18 Thread Murtuza Zabuawala
Hi Shirley, On Tue, Jul 18, 2017 at 1:21 AM, Shirley Wang wrote: > Hi! > > I can't seem to get the patch to completely work on my computer, only the > close icon shows up plus the dialog and success/error messages, but here > are some comments: > > Because we are just cancelling the active runn

Re: [PATCH] Persist opened nodes in tree

2017-07-18 Thread Sarah McAlear
Hello, In order to save everything in the backend sqlite database, maybe a jQuery plugin needs to be developed that has the same interface as jStorage and that will do Ajax calls instead of using the Local Storage. The only caveat for this is that it needs to be registered in window. $.jStorage in

Re: [RM2544][pgAdmin4] Add SSL database connection support in Regression tests

2017-07-18 Thread Dave Page
Thanks, applied. On Tue, Jul 18, 2017 at 6:30 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find updated patch for the same. > > > On Mon, Jul 17, 2017 at 8:59 PM, Dave Page wrote: > >> Hi >> >> On Mon, Jul 17, 2017 at 2:59 PM, Murtuza Zabuawala < >> mu

Jenkins build is back to normal : pgadmin4-master-python35 #244

2017-07-18 Thread pgAdmin 4 Jenkins
See

pgAdmin 4 commit: Support SSL in the regression tests. Fixes #2170

2017-07-18 Thread Dave Page
Support SSL in the regression tests. Fixes #2170 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bab3da24e6a0d82f7be26b7559ee0d6392baaffd Author: Murtuza Zabuawala Modified Files -- .../servers/databases/casts/tests/test_cast_add.

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-18 Thread Dave Page
Thanks - applied! Awesome work - on an average of 3 tests on my Mac, load time reduced from 11.55s with v1.6 to 5.53s with GIT Head. On Mon, Jul 17, 2017 at 5:57 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > Now all test cases are executing. > Please find updated patch. >

pgAdmin 4 commit: Add missing new files from the previous commit. Ooops

2017-07-18 Thread Dave Page
Add missing new files from the previous commit. Ooops. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6396b8ce1801ebb9b00013b5115ea7851ca094a7 Author: Surinder Kumar Modified Files -- .../index_constraint/static/js/primary_key.js

pgAdmin 4 commit: Webpack all the things! Fixes #2135

2017-07-18 Thread Dave Page
Webpack all the things! Fixes #2135 This significantly speeds up loading of the application; in an average of 3 tests, v1.6 loaded in 11.5s in the runtime on a Mac, whilst the webpacked version of the code loaded in 5.53s. Branch -- master Details --- https://git.postgresql.org/gitweb?

Re: [pgadmin-hackers][pgaweb][Patch] Add style guide to pga website

2017-07-18 Thread Dave Page
Thanks, applied. On Tue, Jul 18, 2017 at 2:45 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Dave, > > We changed the name of the file and changed the import, this way it should > be able to import it correctly. > > Thanks > Sarah & Joao > > On Tue, Jul 18, 2017 at 8:2

Re: [pgadmin-hackers][pgaweb][Patch] Add style guide to pga website

2017-07-18 Thread Joao De Almeida Pereira
Hello Dave, We changed the name of the file and changed the import, this way it should be able to import it correctly. Thanks Sarah & Joao On Tue, Jul 18, 2017 at 8:20 AM, Dave Page wrote: > > > On Tue, Jul 18, 2017 at 1:15 PM, Robert Eckhardt > wrote: > >> Looks good. >> > > Thanks. I just n

Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] data in datagrid

2017-07-18 Thread Harshal Dhumal
Hi Dave, On Tue, Jul 18, 2017 at 1:24 PM, Dave Page wrote: > > > On Tue, Jul 18, 2017 at 8:26 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi Dave, >> >> >> On Mon, Jul 17, 2017 at 9:33 PM, Dave Page wrote: >> >>> Hi >>> >>> On Mon, Jul 17, 2017 at 1:09 PM, Harshal Dhumal

Re: Testing out font changes in query editor tool

2017-07-18 Thread Shirley Wang
Thank you! On Tue, Jul 18, 2017 at 7:03 AM Dave Page wrote: > Done. Same location. > > On Mon, Jul 17, 2017 at 7:58 PM, Shirley Wang wrote: > >> Thank you! We also realized it would be easier on people to have both Mac >> and Windows test builds from the same url above. If it's not too difficul

Re: [pgadmin-hackers][pgaweb][Patch] Add style guide to pga website

2017-07-18 Thread Dave Page
On Tue, Jul 18, 2017 at 1:15 PM, Robert Eckhardt wrote: > Looks good. > Thanks. I just noticed though, that we're trying to link to github.css, and failing. Was that intended to be in the same directory as all the scss? > > I assumed American spelling, should we use proper English spelling? Ou

Re: [pgadmin-hackers][pgaweb][Patch] Add style guide to pga website

2017-07-18 Thread Robert Eckhardt
Looks good. I assumed American spelling, should we use proper English spelling? Our prodigious use of the 'z' (pronounced zee) definitely improves our scrabble scores. -- Rob On Tue, Jul 18, 2017 at 7:54 AM, Dave Page wrote: > > > On Mon, Jul 17, 2017 at 7:51 PM, Joao De Almeida Pereira < > jd

Re: [pgadmin-hackers][pgaweb][Patch] Add style guide to pga website

2017-07-18 Thread Dave Page
On Mon, Jul 17, 2017 at 7:51 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers, > > With this patch we added the style guide to the current pgAdmin website. > It is not 100% migrated yet, but we already have the Alerts and colors. > > Thanks - applied with some min

Re: Testing out font changes in query editor tool

2017-07-18 Thread Dave Page
Done. Same location. On Mon, Jul 17, 2017 at 7:58 PM, Shirley Wang wrote: > Thank you! We also realized it would be easier on people to have both Mac > and Windows test builds from the same url above. If it's not too difficult, > would you also be able to add that as well? > > On Mon, Jul 17, 20

Re: [PATCH] Persist opened nodes in tree

2017-07-18 Thread Dave Page
Hi This would be a welcome feature addition, but why not store the treeview state in the configuration database? I'd prefer not to add another storage mechanism without a very compelling reason. If you need info on how it works, please feel free to ask questions. Thanks. On Tue, Jul 18, 2017 at

Re: [pgadmin-hackers] 10k Tables and more

2017-07-18 Thread Dave Page
Hi On Mon, Jul 17, 2017 at 7:08 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > We were looking at a schema that had 10k+ tables on it and we noticed a > substantial decrease of performance while loading the tables and after they > are loaded and we try to scrol

[PATCH] Persist opened nodes in tree

2017-07-18 Thread Versus Void
--- web/pgadmin/browser/__init__.py| 13 +- .../browser/static/vendor/jStorage/jstorage.js | 996 + .../browser/static/vendor/jStorage/jstorage.min.js | 16 + .../browser/templates/browser/js/browser.js| 6 +- 4 files changed, 1029 insertions

[PATCH] Persist opened nodes in tree

2017-07-18 Thread Versus Void
This will restore tree structure on load like in good old pgadmin3.

Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] data in datagrid

2017-07-18 Thread Dave Page
On Tue, Jul 18, 2017 at 8:26 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, > > > On Mon, Jul 17, 2017 at 9:33 PM, Dave Page wrote: > >> Hi >> >> On Mon, Jul 17, 2017 at 1:09 PM, Harshal Dhumal < >> harshal.dhu...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find up

Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] data in datagrid

2017-07-18 Thread Harshal Dhumal
Hi Dave, On Mon, Jul 17, 2017 at 9:33 PM, Dave Page wrote: > Hi > > On Mon, Jul 17, 2017 at 1:09 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> Please find updated patch. Now placeholder string for bytea and bytea[] >> data will only appear in datagrid (view all/1