Re: Build failed in Jenkins: pgadmin4-master-python27-feature #8

Surinder; are you looking at this? On Tue, Jul 18, 2017 at 5:33 PM, Harshal Dhumal wrote: > > > On Tue, Jul 18, 2017 at 9:33 PM, pgAdmin 4 Jenkins > wrote: > >> See > ature/8/display/redirect?page=changes> >> >> Changes: >> >> [Dave

Re: Build failed in Jenkins: pgadmin4-master-python27-feature #8

Yes Dave. I am looking. On Wed, Jul 19, 2017 at 1:44 PM, Dave Page wrote: > Surinder; are you looking at this? > > On Tue, Jul 18, 2017 at 5:33 PM, Harshal Dhumal > wrote: > >> >> >> On Tue, Jul 18, 2017 at 9:33 PM, pgAdmin 4 Jenkins >> wrote: >> >>> See

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi, PFA updated patch, 1) Added Keyboard shortcuts to comment line, uncomment line and comment/uncomment block of code also added drop-down for the same. 2) Also added options for indent & unindent code in the same drop-down. 3) Updated shortcut documents accordingly. Please review. On Mon, Jul

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Just a FYI, You need to run yarn bundle for this to be working as Surinder has moved all the CodeMirror code into bundle package. On Wed, Jul 19, 2017 at 2:20 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA updated patch, > 1) Added Keyboard shortcuts to comment l

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hi Fix library path reference for `jquery.contextmenu'. This issue was only reproducible on Linux machine. So, i setup pgAdmin4 on Ubuntu VM and tested the patch and it works. Please find attached patch. Thanks, Surinder On Tue, Jul 18, 2017 at 9:05 PM, Murtuza Zabuawala wrote: > Great job Su

pgAdmin 4 commit: Add controls and shortcuts for commenting/uncommentin

Add controls and shortcuts for commenting/uncommenting code in the SQL Editor. Fixes #2456. Take the opportunity to tidy up the menus and add access keys to appropriate buttons. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1e1a9f2cf4a76a4

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Thanks, applied. I also took the opportunity to tidy up the menus a little and add access keys for accessibility. One change I made was to make the Edit and Clear menus not have a default option - e.g. instead of a button with a drop-down next to it, they're now a single dropdown button with icon

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Thank you Dave. On Wed, Jul 19, 2017 at 4:17 PM, Dave Page wrote: > Thanks, applied. > > I also took the opportunity to tidy up the menus a little and add access > keys for accessibility. > > One change I made was to make the Edit and Clear menus not have a default > option - e.g. instead of a b

pgAdmin 4 commit: Fix typo in filename.

Fix typo in filename. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6046be7fba76b0617244f3d8ead1fdf81dddc7ca Author: Surinder Kumar Modified Files -- web/webpack.shim.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [pgAdmin4]: Webpacking of static JS/CSS

That was a fun one to spot I'm sure! Thanks, committed. On Wed, Jul 19, 2017 at 11:21 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > Fix library path reference for `jquery.contextmenu'. This issue was only > reproducible on Linux machine. > So, i setup pgAdmin4 on Ubuntu V

Re: [pgAdmin4]: Webpacking of static JS/CSS

On Wed, Jul 19, 2017 at 4:27 PM, Dave Page wrote: > That was a fun one to spot I'm sure! > ​Indeed, i had setup pgAdmin evn on Linux(as it works on Mac) and then i did `ls path/to/jquery.contextmenu.js`, it was spotted :) > > Thanks, committed. > > On Wed, Jul 19, 2017 at 11:21 AM, Surinder Kuma

Build failed in Jenkins: pgadmin4-master-python26 #368

See Changes: [Dave Page] Add controls and shortcuts for commenting/uncommenting code in the SQL [Dave Page] Fix typo in filename. -- [...truncated 576.25 KB...]

Request a feature

Hi, When copying data from query resut the user can choose whether it would be copied with column names or without but choosing the correct setting. This is nice but extermly annoying. Sometimes I want it the first way and sometimes the other way.  Would it be possible that Ctrl + C would continue

Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] data in datagrid

Hi Dave, On Tue, Jul 18, 2017 at 8:31 PM, Dave Page wrote: > > > On Tue, Jul 18, 2017 at 2:40 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Tue, Jul 18, 2017 at 1:24 PM, Dave Page wrote: >> >>> >>> >>> On Tue, Jul 18, 2017 at 8:26 AM, Harshal Dhumal < >>>

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hi, PFA patch for few code review comments given by Ashesh. Thanks, Surinder On Wed, Jul 19, 2017 at 4:36 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > On Wed, Jul 19, 2017 at 4:27 PM, Dave Page wrote: > >> That was a fun one to spot I'm sure! >> > ​Indeed, i had setup pgAdmi

pgAdmin 4 commit: Webpacking cleanups

Webpacking cleanups Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dfa877262d67a9daaff2597d31217d9d3852 Author: Surinder Kumar Modified Files -- .../js/exclusion_constraint.js | 2 - .../templates/foreign_

Re: [pgAdmin4]: Webpacking of static JS/CSS

Thanks, applied. On Wed, Jul 19, 2017 at 2:40 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > PFA patch for few code review comments given by Ashesh. > > Thanks, > Surinder > > > On Wed, Jul 19, 2017 at 4:36 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >

Build failed in Jenkins: pgadmin4-master-python26 #369

See Changes: [Dave Page] Webpacking cleanups -- [...truncated 576.29 KB...] PackagePutTestCase (Fetch Package Node URL) TableAddTe

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Except I managed to break a couple of tests :-(. Can you take a look please? I've had some other work come up that I need to deal with. == ERROR: runTest (pgadmin.feature_tests.query_tool_journey_test.QueryToolJourneyTest) Tests t

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Sure, Will take a look. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 19, 2017 at 8:00 PM, Dave Page wrote: > Except I managed to break a couple of tests :-(. Can you take a look > please? I've had some other work come up t

[pgadmin4][PATCH] Query History Arrow Navigation and Styling

Hello Hackers, Attached are two patches. The first patch adds the ability to navigate through the query history list using up and down arrow keys. The second patch adds error message to the query detail pane and other minor style changes as discussed with the mailing list. Thanks, Joao and Shruti

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

Hi Hackers, One of the patches didn't include some changes. Please find the updated patches attached to this email. Thanks, Shruti and Joao On Wed, Jul 19, 2017 at 11:48 AM Shruti Iyer wrote: > Hello Hackers, > > Attached are two patches. The first patch adds the ability to navigate > through

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

Hi again! Attached are the most updated patches. We found an issue with the previous implementation. So we generated the new patches. Thanks, Joao and Shruti On Wed, Jul 19, 2017 at 2:39 PM Shruti Iyer wrote: > Hi Hackers, > > One of the patches didn't include some changes. Please find the upd