Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-24 Thread Shirley Wang
> > > On Mon, Jul 24, 2017 at 8:11 PM, Dave Page wrote: > >> >> >> On Mon, Jul 24, 2017 at 3:28 PM, Shirley Wang wrote: >> >>> 2-3 days is a lot of valuable engineering time. Is this a 'drop >>> everything now' kind of feature or can this wait for some user validation >>> on a mock up first? >>>

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-24 Thread Harshal Dhumal
-- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jul 24, 2017 at 8:11 PM, Dave Page wrote: > > > On Mon, Jul 24, 2017 at 3:28 PM, Shirley Wang wrote: > >> 2-3 days is a lot of valuable engineering time. Is th

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-24 Thread Dave Page
On Mon, Jul 24, 2017 at 3:28 PM, Shirley Wang wrote: > 2-3 days is a lot of valuable engineering time. Is this a 'drop everything > now' kind of feature or can this wait for some user validation on a mock up > first? > Most of the time will likely be on the infrastructure to change the display t

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-24 Thread Shirley Wang
2-3 days is a lot of valuable engineering time. Is this a 'drop everything now' kind of feature or can this wait for some user validation on a mock up first? > On Jul 24, 2017, at 20:41, Murtuza Zabuawala > wrote: > > Sure. > > RM created: https://redmine.postgresql.org/issues/2597. > >> On

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-24 Thread Murtuza Zabuawala
Sure. RM created: https://redmine.postgresql.org/issues/2597. On Mon, Jul 24, 2017 at 6:04 PM, Dave Page wrote: > > > On Mon, Jul 24, 2017 at 1:12 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> On Mon, Jul 24, 2017 at 4:44 PM, Dave Page wrote: >> >>> Thanks, applied. >>> >

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-24 Thread Dave Page
On Mon, Jul 24, 2017 at 1:12 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > On Mon, Jul 24, 2017 at 4:44 PM, Dave Page wrote: > >> Thanks, applied. >> >> How much effort do you think it would take to turn the table into a >> subnode control so we can show the SQ

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-24 Thread Murtuza Zabuawala
Hi Dave, On Mon, Jul 24, 2017 at 4:44 PM, Dave Page wrote: > Thanks, applied. > > How much effort do you think it would take to turn the table into a > subnode control so we can show the SQL query and other missing fields from > pg_stat_activity on that tab? > I think around 2-3 days would be ne

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-24 Thread Dave Page
Thanks, applied. How much effort do you think it would take to turn the table into a subnode control so we can show the SQL query and other missing fields from pg_stat_activity on that tab? On Mon, Jul 24, 2017 at 11:45 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave

Jenkins build is back to normal : pgadmin4-master-python36 #257

2017-07-24 Thread pgAdmin 4 Jenkins
See

pgAdmin 4 commit: Allow queries to be cancelled from the dashboards. Fi

2017-07-24 Thread Dave Page
Allow queries to be cancelled from the dashboards. Fixes #1812 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=617e9dbb3a466507a7cfdd6ba144c0dca5955dec Author: Murtuza Zabuawala Modified Files -- web/pgadmin/dashboard/__init__.py

Re: [RM2579][pgAdmin4] Set default file listing layout as list instead of grid

2017-07-24 Thread Dave Page
Hi On Mon, Jul 24, 2017 at 11:34 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached patch to set default layout of file listing as a list > in file manager. > Also replaced alertify with out custom alertifywrapper in file manager > utils.js > This isn't a

pgAdmin 4 commit: Ensure the appropriate entry is focussed when enterin

2017-07-24 Thread Dave Page
Ensure the appropriate entry is focussed when entering the history tab. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe95b7670b539b1957a41ee77b9c304fef31825f Author: Joao Pedro De Almeida Pereira Modified Files -- web/pgadmin/s

Re: [pgadmin-hackers][patch]

2017-07-24 Thread Dave Page
Thanks, applied. On Fri, Jul 21, 2017 at 10:38 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi hackers, > With the last commits, the behavior of focusing on a selected entry when > entering the History Tab was not working as expected. > This patch will bring this behavior

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-24 Thread Murtuza Zabuawala
Hi Dave, Please find updated patch. On Tue, Jul 18, 2017 at 8:05 PM, Murtuza Zabuawala wrote: > Hi Shirley, > > On Tue, Jul 18, 2017 at 1:21 AM, Shirley Wang wrote: > >> Hi! >> >> I can't seem to get the patch to completely work on my computer, only the >> close icon shows up plus the dialog a

[RM2579][pgAdmin4] Set default file listing layout as list instead of grid

2017-07-24 Thread Harshal Dhumal
Hi, Please find attached patch to set default layout of file listing as a list in file manager. Also replaced alertify with out custom alertifywrapper in file manager utils.js -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL

Re: [pgAdmin4][Patch]: Improvise the treeview element selection

2017-07-24 Thread Dave Page
On Mon, Jul 24, 2017 at 8:51 AM, Shirley Wang wrote: > Hi Surinder, > > This change seems to be different from the other patterns for selected / > highlighted options. Is there a reason why this needs to be more visible > than it already is? In terms of feedback on the tree, we have not heard any

Re: [pgAdmin4][Patch]: Improvise the treeview element selection

2017-07-24 Thread Shirley Wang
Hi Surinder, This change seems to be different from the other patterns for selected / highlighted options. Is there a reason why this needs to be more visible than it already is? In terms of feedback on the tree, we have not heard any pains from users that this is not visible enough. Shirley On