Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-25 Thread Dave Page
On Tue, Jul 25, 2017 at 6:26 AM, Shirley Wang wrote: > >> On Mon, Jul 24, 2017 at 8:11 PM, Dave Page wrote: >> >>> >>> >>> On Mon, Jul 24, 2017 at 3:28 PM, Shirley Wang wrote: >>> 2-3 days is a lot of valuable engineering time. Is this a 'drop everything now' kind of feature or can th

[pgAdmin4][Patch]: Handle WSGI Alias while generating URL for endpoints.js

2017-07-25 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where user were not able to run pgAdmin4 under WSGI Alias (example: localhost/pgadmin). RM#2563 *Issue:* - Removed hard coded url paths from base.html - URL's are not generated with WSGI alias when we use current_app.url_map.iter_rules() function to fetch all the en

pgAdmin 4 commit: Fix paths under non-standard virtual directories. Fix

2017-07-25 Thread Dave Page
Fix paths under non-standard virtual directories. Fixes #2563 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=178d583bcd7390f3b1e47df6298d924059b21c86 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/__init__.py | 3

Re: [pgAdmin4][Patch]: Handle WSGI Alias while generating URL for endpoints.js

2017-07-25 Thread Dave Page
Thanks, applied. On Tue, Jul 25, 2017 at 9:48 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where user were not able to run pgAdmin4 under > WSGI Alias (example: localhost/pgadmin). > RM#2563 > > *Issue:* > - Removed hard coded url paths f

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-25 Thread Shirley Wang
Ok, I understand that this is a feature that should exist. We should decouple the need for a feature existing from the way the feature is designed and used. I think we need a broader discussion on how to do this. On Tue, Jul 25, 2017 at 3:59 PM Dave Page wrote: > On Tue, Jul 25, 2017 at 6:26 AM,

pgAdmin 4 commit: Do not dump the session data on the disk on every req

2017-07-25 Thread Ashesh Vashi
Do not dump the session data on the disk on every request. Session object is updated, everytime a request is being served, and that was forcing the session object dumped on the dist on every request. On windows, it was causing issues on slower system on startup. Because - windows file system lock

[pgAdmin4][Patch]: Backform control visibility fix

2017-07-25 Thread Khushboo Vashi
Hi, Please find the attached patch to handle the control visibility even in the javascript strict mode. Thanks, Khushboo diff --git a/web/pgadmin/browser/server_groups/servers/roles/templates/role/js/role.js b/web/pgadmin/browser/server_groups/servers/roles/templates/role/js/role.js index 1c0917d