Re: pgAdmin4 - Tree view icons for final reveiw

2017-08-23 Thread Chethana Kumar
Hi Murtuza, Please see my reply inline along with the updated .svg file for tree view icons. On Tue, Aug 22, 2017 at 11:17 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Chethana, > > - The icons for Server node is missing, we will need given set of icons > for server.

Re: pgAdmin4 - Tree view icons for final reveiw

2017-08-23 Thread Murtuza Zabuawala
Hi Chethana, On Wed, Aug 23, 2017 at 12:51 PM, Chethana Kumar < chethana.ku...@enterprisedb.com> wrote: > Hi Murtuza, > > Please see my reply inline along with the updated .svg file for tree view > icons. > > > On Tue, Aug 22, 2017 at 11:17 AM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprised

pgAdmin 4 commit: Syntax error while saving changes for start/end time,

2017-08-23 Thread Akshay Joshi
Syntax error while saving changes for start/end time, weekdays, monthdays, month, hours, minutes while updating the pgAgent Job. Fixes #2657. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ee20a10e9410f2ce5024a7b8e4fa758706dc52d0 Author: Suri

Re: Selecting tables from Browser

2017-08-23 Thread Dave Page
On Tue, Aug 22, 2017 at 5:04 PM, Shirley Wang wrote: > > > On Tue, Aug 22, 2017 at 8:27 AM Dave Page wrote: > >> On Tue, Aug 22, 2017 at 12:17 AM, Shirley Wang wrote: >> >>> Hi Rob >>> On Mon, Aug 21, 2017 at 1:53 PM Robert Eckhardt >>> wrote: >>> Shirley, I have a few questions

Re: [pgAdmin4] [pgAgent] [Patch]: RM_ 2657 - Syntax error while saving changes when start/end time is changed from scheduler

2017-08-23 Thread Akshay Joshi
Thanks patch applied. While reviewing the patch I have found one more issue where user won't be able to update Week Days, Month Days, Months, Hours and Minutes as well, so I have fixed it as well. On Tue, Aug 22, 2017 at 1:12 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > *

pgAdmin 4 commit: Unable to add/update variables for columns of a table

2017-08-23 Thread Akshay Joshi
Unable to add/update variables for columns of a table. Fixes #2659 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe6e4686a2bf5d9d7db438d209d4d4d6783543ce Modified Files -- .../schemas/tables/column/static/js/column.js |

Re: [pgAdmin4][Patch]: RM_ 2658 - Improve help message for "binary paths" entered in Preferences

2017-08-23 Thread Surinder Kumar
Hi Dave, On Tue, Aug 22, 2017 at 7:22 PM, Murtuza Zabuawala wrote: > ​​ > https://redmine.postgresql.org/issues/2008 > ​ > > On Tue, Aug 22, 2017 at 7:14 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> On Tue, Aug 22, 2017 at 6:07 PM, Dave Page wrote: >> >>> >>> >>> On Tue,