Re: [pgadmin4] Explain plans

Hi On Fri, Jan 19, 2018 at 2:09 PM, Joao De Almeida Pereira wrote: > Hello Hackers, > We are trying to find a solution for the explain plans that currently are > not working in GP, due to the lack of support for JSON. We believe that the > best options for this it would be to display the text in

Re: [pgAdmin4][Patch#2897] Add support for keyboard navigation in Debugger

Hi This seems to be missing documentation updates. I would also expect to see some Jasmine unit tests for some/all of the new JS functions. On Tue, Jan 16, 2018 at 1:29 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to add keyboard navigation in Debugger m

Re: [pgAdmin4][Patch]: Update ESLint to latest version

Thanks, patch applied. On Wed, Jan 17, 2018 at 6:27 AM, Surinder Kumar wrote: > Hi > > In the current version of ESLint the option "--fix-dry-run" not working. So, > updating to the latest one resolve this. > > Please find an attached patch. > > Thanks, > Surinder -- Dave Page Blog: http://pg

pgAdmin 4 commit: Update ESLint requirement to support --fix-dry-run

Update ESLint requirement to support --fix-dry-run Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0ee9f09bbde345160f7bb764ce3242e78b3c1293 Author: Surinder Kumar Modified Files -- web/package.json | 2 +- 1 file changed, 1 inserti

pgAdmin 4 commit: Ensure clickable images/buttons have appropriate tool

Ensure clickable images/buttons have appropriate tooltips for screen readers. Fixes #2904 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ca80cfa04a4b11718340196c381a1a1c85451b21 Author: Khushboo Vashi Modified Files -- web/pgadm

Re: [pgAdmin4][Patch]: RM #2904: As a visually impaired user I need all buttons in the application to have appropriate tooltips for my screen reader to interpret

Thanks, patch applied. On Wed, Jan 17, 2018 at 6:55 AM, Khushboo Vashi wrote: > > > On Wed, Jan 17, 2018 at 12:23 PM, Khushboo Vashi > wrote: >> >> >> >> On Mon, Jan 15, 2018 at 10:39 PM, Dave Page wrote: >>> >>> Hi >>> >>> On Mon, Jan 15, 2018 at 10:23 AM, Khushboo Vashi >>> wrote:

Build failed in Jenkins: pgadmin4-master-python26 #580

See Changes: [Dave Page] Update ESLint requirement to support --fix-dry-run -- [...truncated 406.58 KB...] 157:1 error Expected indentation of 6 spaces but f

Re: [pgAdmin4][Patch#3021] Updating existing Index scan & Scan icons

Hi On Thu, Jan 18, 2018 at 12:48 PM, Chethana Kumar < chethana.ku...@enterprisedb.com> wrote: > Hello Team, > > I am sending a patch for the ex_index and ex_scan icons where those were > similar to each other so I have made them easy to differentiate now. > > It is respective to the issue *RM# 3

Build failed in Jenkins: pgadmin4-master-python33 #451

See Changes: [Dave Page] Update ESLint requirement to support --fix-dry-run [Dave Page] Ensure clickable images/buttons have appropriate tooltips for screen -- [

Build failed in Jenkins: pgadmin4-master-python34 #440

See Changes: [Dave Page] Update ESLint requirement to support --fix-dry-run [Dave Page] Ensure clickable images/buttons have appropriate tooltips for screen -- [

Fwd: Build failed in Jenkins: pgadmin4-master-python34 #440

Hi Surinder, It seems that updating ESLint exposed various issues. Can you take a look ASAP please? Thanks. -- Forwarded message -- From: pgAdmin 4 Jenkins Date: Mon, Jan 22, 2018 at 10:53 AM Subject: Build failed in Jenkins: pgadmin4-master-python34 #440 To: pgadmin-hack...@po

Re: Build failed in Jenkins: pgadmin4-master-python34 #440

Yes, I will look. Thanks, Surinder On Mon, Jan 22, 2018 at 4:25 PM, Dave Page wrote: > Hi Surinder, > > It seems that updating ESLint exposed various issues. Can you take a > look ASAP please? > > Thanks. > > > -- Forwarded message -- > From: pgAdmin 4 Jenkins > Date: Mon, Jan

Build failed in Jenkins: pgadmin4-master-python36 #447

See Changes: [Dave Page] Update ESLint requirement to support --fix-dry-run [Dave Page] Ensure clickable images/buttons have appropriate tooltips for screen -- [

Re: Build failed in Jenkins: pgadmin4-master-python34 #440

Dave, We need to make habit of running the following command before committing any javascript files. > *yarn run linter* -- Thanks, Ashesh On Mon, Jan 22, 2018 at 4:25 PM, Dave Page wrote: > Hi Surinder, > > It seems that updating ESLint exposed various issues. Can you take a > look ASAP ple

Re: Build failed in Jenkins: pgadmin4-master-python34 #440

On Mon, Jan 22, 2018 at 10:59 AM, Ashesh Vashi wrote: > Dave, > > We need to make habit of running the following command before committing any > javascript files. >> >> yarn run linter We do - it's called when creating the bundle, which I always do when testing. This newer version of ESLint seem

Re: Build failed in Jenkins: pgadmin4-master-python34 #440

On Mon, Jan 22, 2018 at 4:29 PM, Ashesh Vashi wrote: > Dave, > > We need to make habit of running the following command before committing > any javascript files. > >> *yarn run linter* > > Surinder, Please run the following command to fix most of the indentation issues, but - you'll need to fix

Build failed in Jenkins: pgadmin4-master-python35 #451

See Changes: [Dave Page] Update ESLint requirement to support --fix-dry-run [Dave Page] Ensure clickable images/buttons have appropriate tooltips for screen -- [

pgAdmin 4 commit: Correctly display SQL of multiple objects on the SQL

Correctly display SQL of multiple objects on the SQL tab in GPDB. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=284adbbb901b1be30d130be0e40674cfde931e41 Author: Joao Pedro De Almeida Pereira Modified Files -- .../templates/schem

Re: Build failed in Jenkins: pgadmin4-master-python34 #440

On Mon, Jan 22, 2018 at 4:32 PM, Dave Page wrote: > On Mon, Jan 22, 2018 at 10:59 AM, Ashesh Vashi > wrote: > > Dave, > > > > We need to make habit of running the following command before committing > any > > javascript files. > >> > >> yarn run linter > > We do - it's called when creating the b

Build failed in Jenkins: pgadmin4-master-python27 #452

See Changes: [Dave Page] Update ESLint requirement to support --fix-dry-run [Dave Page] Ensure clickable images/buttons have appropriate tooltips for screen -- [

Build failed in Jenkins: pgadmin4-master-python35 #452

See Changes: [Dave Page] Correctly display SQL of multiple objects on the SQL tab in GPDB. -- [...truncated 401.59 KB...] 228:1 error Expected indentation of

Build failed in Jenkins: pgadmin4-master-python26 #581

See Changes: [Dave Page] Ensure clickable images/buttons have appropriate tooltips for screen [Dave Page] Correctly display SQL of multiple objects on the SQL tab in GPDB. -

pgAdmin 4 commit: Add missing comma to appease the linter

Add missing comma to appease the linter Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2b1c8879452d8146924b96ba6fd1e67ba3f225fd Modified Files -- web/pgadmin/static/js/backform.pgadmin.js | 2 +- 1 file changed, 1 insertion(+), 1 d

pgAdmin 4 commit: Revert "Update ESLint requirement to support --fix-dr

Revert "Update ESLint requirement to support --fix-dry-run" This reverts commit 0ee9f09bbde345160f7bb764ce3242e78b3c1293. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=51cda9891115a58ed97807a6fa2148d9834b07f5 Modified Files -- w

pgAdmin 4 commit: Modern versions of yarn don't require -- to forward o

Modern versions of yarn don't require -- to forward options. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0ec74dfa8934726685c01b86832678dceda0e2d2 Modified Files -- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

Build failed in Jenkins: pgadmin4-master-python36 #448

See Changes: [Dave Page] Correctly display SQL of multiple objects on the SQL tab in GPDB. -- [...truncated 401.50 KB...] 228:1 error Expected indentation of

Jenkins build is back to normal : pgadmin4-master-python33 #452

See

Build failed in Jenkins: pgadmin4-master-python34 #441

See Changes: [Dave Page] Correctly display SQL of multiple objects on the SQL tab in GPDB. -- [...truncated 401.62 KB...] 228:1 error Expected indentation of

Jenkins build is back to normal : pgadmin4-master-python27 #453

See

Jenkins build is back to normal : pgadmin4-master-python35 #453

See

pgAdmin 4 commit: Complain if the default web browser cannot be opened.

Complain if the default web browser cannot be opened. Branch -- runtime-revamp Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9d0d1eb5fd092d501975c362947d7579daf57bd2 Modified Files -- runtime/TrayIcon.cpp | 8 +++- runtime/pgAdmin4.cpp | 8 +++

Jenkins build is back to normal : pgadmin4-master-python26 #582

See

Jenkins build is back to normal : pgadmin4-master-python34 #442

See

Jenkins build is back to normal : pgadmin4-master-python36 #449

See

[pgadmin4] Feature tests

Hello Hackers, Is the latest commit in master passing the Feature tests? Thanks Joao

Re: [pgadmin4] Feature tests

No, we are looking into it. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jan 22, 2018 at 6:56 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers, > Is the latest commit in master passing the Fea

Re: [pgadmin4] Explain plans

Hello, Eventually we can extract a ExecuteQuery class that will execute the query and poll for the result this way can extract some code from SQLEditor. Then the execute query can have parameters for the explain plan option and we can build the query in the backend. Thanks for the input, I will tr

Re: [pgadmin4]{Patch] Display GreenPlum partitions and correct SQL on SQL Tab

Hello Hackers, I merge the 2 commits into 1 and also corrected a problem with SQL display of partitions in GP. So this new patch Displays the partitions on GreenPlum database, correct SQL that was being used in the SQL tab for Schemas and display the correct SQL for Partitioned tables in GreenPlum.

Re: [pgadmin4][Patch]: Display Functions node for GreenPlum database

Any comments on this patch? Or is it ready to merge? On Fri, Jan 19, 2018 at 7:56 AM Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers, > I am updating this patch as we found out that the SQL tab was not showing > the functions properly, and we corrected that in the n

Re: [pgAdmin4][Patch#2897] Add support for keyboard navigation in Debugger

Hi Dave, Please find updated patch with docs and JS tests. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jan 22, 2018 at 4:02 PM, Dave Page wrote: > Hi > > This seems to be missing documentation updates. I would also expect t