Re: [pgAdmin4][RM#2950] Add marker to dashboard queries

Hello Murtuza, Looks like I missread the Issue then. In that case I think it might be the solution that we can implement. Unless anyone in the list as a different idea. Thanks Joao On Thu, Feb 15, 2018 at 11:12 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Joao, > > It w

Re: [pgAdmin4][RM#3121] Fix PEP-8 issues

Thank you for reviewing Joao. On Thu, Feb 15, 2018 at 8:37 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Murtuza, > I just run this patch as you suggested(no errors reported) and also run it > through our CI pipeline and it look good > > Thanks > Joao > > On Wed, Feb

Re: [pgAdmin4][RM#2950] Add marker to dashboard queries

Hi Joao, It was mainly intended for PostgreSQL database logs and not pgAdmin4 logs :) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Feb 15, 2018 at 8:03 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hel

Re: [pgAdmin4][RM#3121] Fix PEP-8 issues

Hello Murtuza, I just run this patch as you suggested(no errors reported) and also run it through our CI pipeline and it look good Thanks Joao On Wed, Feb 14, 2018 at 7:23 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the PEP-8 issues, > > To verify

Next release

Apologies if this has been discussed and I missed it. When is the 3.0 release planned? -- Rob

Re: [pgAdmin4][RM#2950] Add marker to dashboard queries

Hello Murtuza, I was looking into the Issue information and the solution that was provided there needs some polish. With the solution that was asked, the log will still be generated, but eventually will not show up in a log monitor, but nevertheless will be there. After some digging around the cod

Re: [pgAdmin4][RM#3105] Allow user to insert new row if PK is in capital letters

​Sure, will do that.​ -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Feb 15, 2018 at 7:34 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Murtuza, > Just reviewed your patch, and it looks good. > Do yo

Re: [pgAdmin4][RM#3105] Allow user to insert new row if PK is in capital letters

Hello Murtuza, Just reviewed your patch, and it looks good. Do you think you can wrap some tests around this behavior to ensure it doesn't happen again in the future? Thanks Joao On Thu, Feb 15, 2018 at 8:34 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to

[pgAdmin4][RM#2950] Add marker to dashboard queries

Hi, PFA patch to add marker in dashboard queries, it will allow to user to filter out those queries from database logs if required. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/dashboard/templates/dashboard/sql/

[pgAdmin4][RM#3105] Allow user to insert new row if PK is in capital letters

Hi, PFA patch to fix the issue user was not able to insert new row in the table via 'view data' if the PK is in capital letters. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/sqleditor/__init__.py b/web/pg