Re: Experiencing issues

2018-03-22 Thread Khushboo Vashi
Hi, On Wed, Mar 21, 2018 at 9:31 PM, Dave Page wrote: > > > On Wed, Mar 21, 2018 at 3:57 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Sorry I did not understand what you said. >> This configuration: >> >> DEFAULT_SERVER = '0.0.0.0' >> SESSION_COOKIE_DOMAIN = DEFAULT_

Re: v3.0 release on hold

2018-03-22 Thread Khushboo Vashi
On Thu, Mar 22, 2018 at 3:42 PM, Dave Page wrote: > > > On Thu, Mar 22, 2018 at 9:58 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Thu, Mar 22, 2018 at 3:20 PM, Dave Page wrote: >> >>> Hi >>> >>> On Thu, Mar 22, 2018 at 9:25 AM, Khushboo Vashi < >>> khushboo.va...@

Re: v3.0 release on hold

2018-03-22 Thread Akshay Joshi
On Thu, Mar 22, 2018 at 10:24 PM, Dave Page wrote: > Hi > > On Thu, Mar 22, 2018 at 1:13 PM, Dave Page wrote: > >> >> 2) Starting a second instance of the app bundle on Mac doesn't always >> open a new pgAdmin window as it should. It works fine in the debugger, or >> if you start the

Re: Showstopper desktop runtime issue

2018-03-22 Thread Joao De Almeida Pereira
Hello Hackers In the PoC we did with Electron last month this was the point where we stopped What did we accomplish: - Use Electron as a runtime and packaging solution for the application - Support opening new windows when the preferences ask for them - Make the application generally work - U

Re: Showstopper desktop runtime issue

2018-03-22 Thread Dave Page
On Thu, Mar 22, 2018 at 4:28 PM, Dave Page wrote: > > 2) This option is not very appealing to me, because we would be pilling >>> code into the QT portion of the application, that I hope we remove in the >>> future, that currently is untested to solve a problem caused by a Window >>> Manager.

Re: v3.0 release on hold

2018-03-22 Thread Dave Page
Hi On Thu, Mar 22, 2018 at 1:13 PM, Dave Page wrote: > > 2) Starting a second instance of the app bundle on Mac doesn't always > open a new pgAdmin window as it should. It works fine in the debugger, or > if you start the app with a command like: "/Applications/pgAdmin\ > 4.app/C

Re: Showstopper desktop runtime issue

2018-03-22 Thread Robert Eckhardt
On Thu, Mar 22, 2018 at 12:28 PM, Dave Page wrote: > Hi > > On Thu, Mar 22, 2018 at 4:17 PM, Magnus Hagander > wrote: > >> >> >> On Thu, Mar 22, 2018 at 3:57 PM, Joao De Almeida Pereira < >> jdealmeidapere...@pivotal.io> wrote: >> >>> Hello Hackers, >>> Here is our take on the 3 options present:

Re: Showstopper desktop runtime issue

2018-03-22 Thread Dave Page
Hi On Thu, Mar 22, 2018 at 4:17 PM, Magnus Hagander wrote: > > > On Thu, Mar 22, 2018 at 3:57 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Hackers, >> Here is our take on the 3 options present: >> > > This looks like a good summary, so I'm going to pick this on

Re: Showstopper desktop runtime issue

2018-03-22 Thread Magnus Hagander
On Thu, Mar 22, 2018 at 3:57 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers, > Here is our take on the 3 options present: > This looks like a good summary, so I'm going to pick this one to comment on :) > 1) QtWebkit and QtWebEngine > > Pros: > - Webkit is

Re: Showstopper desktop runtime issue

2018-03-22 Thread Dave Page
Hi On Thu, Mar 22, 2018 at 2:57 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers, > Here is our take on the 3 options present: > 1) QtWebkit and QtWebEngine > > Pros: > - Webkit is a mature technology that as been around for some time > - Apparently the Fork of W

Re: Showstopper desktop runtime issue

2018-03-22 Thread Joao De Almeida Pereira
Hello Hackers, Here is our take on the 3 options present: 1) QtWebkit and QtWebEngine Pros: - Webkit is a mature technology that as been around for some time - Apparently the Fork of Webkit we were using as been catching up Cons: - We are using a Fork - It is to far behind of the today browsers an

Re: Little patch for Runtime build from Top Level Directory($PGADMIN_SRC) MakeFile

2018-03-22 Thread Dave Page
Rats, my bad. Fixed now - thanks. On Thu, Mar 22, 2018 at 1:41 PM, Rahul Soshte wrote: > there is a small typo in the target name "all" runtime-release needs to be > changed runtime too. > > On Thu, Mar 22, 2018 at 4:50 PM, Dave Page wrote: > >> Thanks - patch applied with a minor change of the

pgAdmin 4 commit: Fix target dependency per Rahul Soshte.

2018-03-22 Thread Dave Page
Fix target dependency per Rahul Soshte. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d5ebf6777a5470e4c39a5348bcf375534bd5e9c4 Modified Files -- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: Little patch for Runtime build from Top Level Directory($PGADMIN_SRC) MakeFile

2018-03-22 Thread Rahul Soshte
there is a small typo in the target name "all" runtime-release needs to be changed runtime too. On Thu, Mar 22, 2018 at 4:50 PM, Dave Page wrote: > Thanks - patch applied with a minor change of the target name > "runtime-release" to "runtime" (runtime-debug remains the same). > > On Thu, Mar 22,

Re: v3.0 release on hold

2018-03-22 Thread Dave Page
Hi On Thu, Mar 22, 2018 at 1:00 PM, Akshay Joshi wrote: > > > On Thu, Mar 22, 2018 at 3:22 PM, Dave Page wrote: > >> Hi >> >> On Thu, Mar 22, 2018 at 9:21 AM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Dave >>> >>> On Wed, Mar 21, 2018 at 9:05 PM, Dave Page wrote: >>> >>

Re: v3.0 release on hold

2018-03-22 Thread Akshay Joshi
On Thu, Mar 22, 2018 at 3:22 PM, Dave Page wrote: > Hi > > On Thu, Mar 22, 2018 at 9:21 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> On Wed, Mar 21, 2018 at 9:05 PM, Dave Page wrote: >> >>> We've run into a number of unexpected issues with the v3.0 release that >

Re: Little patch for Runtime build from Top Level Directory($PGADMIN_SRC) MakeFile

2018-03-22 Thread Dave Page
Thanks - patch applied with a minor change of the target name "runtime-release" to "runtime" (runtime-debug remains the same). On Thu, Mar 22, 2018 at 9:28 AM, Rahul Soshte wrote: > This is my first time trying to make a Patch. > > I am using Ubuntu 17.10. > > This patch is in reference to the F

pgAdmin 4 commit: Enable building of the runtime from the top level Mak

2018-03-22 Thread Dave Page
Enable building of the runtime from the top level Makefile. Fixes #1305 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6d7f7952608b5bd07f20fa431ec540093f68d845 Author: Rahul Soshte Modified Files -- Makefile

Re: Little patch for Runtime build from Top Level Directory($PGADMIN_SRC) MakeFile

2018-03-22 Thread Murtuza Zabuawala
Have you configured your local test configuration file ../pgadmin4/web/regression/test_config.json.in , Make a copy of it as ../pgadmin4/web/regression/test_config.json and update it as per your environment to run tests. On Thu, Mar 22, 2018 at 4:18 PM, Rahul Soshte wrote: > Although I have post

Re: Little patch for Runtime build from Top Level Directory($PGADMIN_SRC) MakeFile

2018-03-22 Thread Rahul Soshte
Although I have postgresql-9.6 it is showing-Running the test cases for 'PostgreSQL 9.4' On Thu, Mar 22, 2018 at 4:17 PM, Rahul Soshte wrote: > Although I have postgresql-9.6 it is showing > -- > -- > Running the test cases for 'PostgreSQL 9.4' > > On Thu, Mar 22, 2018 at 4:01 PM, Rahul Soshte

Re: Showstopper desktop runtime issue

2018-03-22 Thread Murtuza Zabuawala
On Thu, Mar 22, 2018 at 3:19 PM, Dave Page wrote: > All, > > As you know, the 3.0 release is currently on hold as we discovered late > yesterday that the re-vamped desktop runtime will not run on Gnome 3.26 and > later. This is because the GTK project, and later Gnome, have removed > support for

Re: Little patch for Runtime build from Top Level Directory($PGADMIN_SRC) MakeFile

2018-03-22 Thread Rahul Soshte
Although I have postgresql-9.6 it is showing -- -- Running the test cases for 'PostgreSQL 9.4' On Thu, Mar 22, 2018 at 4:01 PM, Rahul Soshte wrote: > > -- Forwarded message -- > From: Rahul Soshte > Date: Thu, Mar 22, 2018 at 4:01 PM > Subject: Re: Little patch for Runtime build

Fwd: Little patch for Runtime build from Top Level Directory($PGADMIN_SRC) MakeFile

2018-03-22 Thread Rahul Soshte
-- Forwarded message -- From: Rahul Soshte Date: Thu, Mar 22, 2018 at 4:01 PM Subject: Re: Little patch for Runtime build from Top Level Directory($PGADMIN_SRC) MakeFile To: Murtuza Zabuawala I am still getting the same error even when I did SERVER_MODE = False. On Thu, Mar 22,

Re: Showstopper desktop runtime issue

2018-03-22 Thread Dave Page
On Thu, Mar 22, 2018 at 10:19 AM, Neel Patel wrote: > Hi, > > On Thu, Mar 22, 2018 at 3:19 PM, Dave Page wrote: > >> All, >> >> As you know, the 3.0 release is currently on hold as we discovered late >> yesterday that the re-vamped desktop runtime will not run on Gnome 3.26 and >> later. This is

Re: Showstopper desktop runtime issue

2018-03-22 Thread Neel Patel
Hi, On Thu, Mar 22, 2018 at 3:19 PM, Dave Page wrote: > All, > > As you know, the 3.0 release is currently on hold as we discovered late > yesterday that the re-vamped desktop runtime will not run on Gnome 3.26 and > later. This is because the GTK project, and later Gnome, have removed > support

Re: v3.0 release on hold

2018-03-22 Thread Dave Page
On Thu, Mar 22, 2018 at 9:58 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Thu, Mar 22, 2018 at 3:20 PM, Dave Page wrote: > >> Hi >> >> On Thu, Mar 22, 2018 at 9:25 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> On Wed, Mar 21, 2018

Re: Showstopper desktop runtime issue

2018-03-22 Thread Akshay Joshi
On Thu, Mar 22, 2018 at 3:19 PM, Dave Page wrote: > All, > > As you know, the 3.0 release is currently on hold as we discovered late > yesterday that the re-vamped desktop runtime will not run on Gnome 3.26 and > later. This is because the GTK project, and later Gnome, have removed > support for

Re: v3.0 release on hold

2018-03-22 Thread Khushboo Vashi
On Thu, Mar 22, 2018 at 3:20 PM, Dave Page wrote: > Hi > > On Thu, Mar 22, 2018 at 9:25 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Wed, Mar 21, 2018 at 9:05 PM, Dave Page wrote: >> >>> We've run into a number of unexpected issues with the v3.0 release t

Re: v3.0 release on hold

2018-03-22 Thread Dave Page
Hi On Thu, Mar 22, 2018 at 9:21 AM, Akshay Joshi wrote: > Hi Dave > > On Wed, Mar 21, 2018 at 9:05 PM, Dave Page wrote: > >> We've run into a number of unexpected issues with the v3.0 release that I >> think we need to resolve before moving forwards. For the time being, only >> patches critical

Re: v3.0 release on hold

2018-03-22 Thread Dave Page
Hi On Thu, Mar 22, 2018 at 9:25 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > On Wed, Mar 21, 2018 at 9:05 PM, Dave Page wrote: > >> We've run into a number of unexpected issues with the v3.0 release that I >> think we need to resolve before moving forwards. For the

Showstopper desktop runtime issue

2018-03-22 Thread Dave Page
All, As you know, the 3.0 release is currently on hold as we discovered late yesterday that the re-vamped desktop runtime will not run on Gnome 3.26 and later. This is because the GTK project, and later Gnome, have removed support for the System Tray on which the new runtime relies. They have rep

Re: Little patch for Runtime build from Top Level Directory($PGADMIN_SRC) MakeFile

2018-03-22 Thread Murtuza Zabuawala
You need to make SERVER_MODE = False in config_local.py in order to run feature tests. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Mar 22, 2018 at 3:00 PM, Rahul Soshte wrote: > how do I resolve those errors in step 4 of the

Re: Little patch for Runtime build from Top Level Directory($PGADMIN_SRC) MakeFile

2018-03-22 Thread Rahul Soshte
how do I resolve those errors in step 4 of the checklist? On Thu, Mar 22, 2018 at 2:58 PM, Rahul Soshte wrote: > This is my first time trying to make a Patch. > > I am using Ubuntu 17.10. > > This patch is in reference to the Feature Added by Dave Page > https://redmine.postgresql.org/issues/13

Re: v3.0 release on hold

2018-03-22 Thread Khushboo Vashi
Hi Dave, On Wed, Mar 21, 2018 at 9:05 PM, Dave Page wrote: > We've run into a number of unexpected issues with the v3.0 release that I > think we need to resolve before moving forwards. For the time being, only > patches critical to fix these issues should be committed. > > I'll try to look at 1

Re: v3.0 release on hold

2018-03-22 Thread Akshay Joshi
Hi Dave On Wed, Mar 21, 2018 at 9:05 PM, Dave Page wrote: > We've run into a number of unexpected issues with the v3.0 release that I > think we need to resolve before moving forwards. For the time being, only > patches critical to fix these issues should be committed. > > I'll try to look at 1,

Re: v3.0 release on hold

2018-03-22 Thread Dave Page
Hi On Wed, Mar 21, 2018 at 5:52 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Dave, > I think that this Gnome issue should be addressed after the release of > 3.0. We should create a bug and see the best way to address it after. This > is my proposal, because I am not 10