Re: [pgAdmin4][RM#3271] Update to the latest 3.x version of jQuery

Hi, No luck with data-test-selector. :( I added data-test-selector to html tags. I get undefined for .data('test-selector') as well as for .attr('data-test-selector'). Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant

Re: [pgAdmin4][RM#3271] Update to the latest 3.x version of jQuery

Hi Victoria/Joao, Thank you for reviewing. The above function is probably the last solution which I added. The test cases in web/regression/javascript/sqleditor/execute_query_spec.js calls the execute query function of pgAdmin4 sqleditor. The execution disables/enables the buttons internally and i

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

I spoke to Ashesh earlier - he's working on an update to the proposed patch at the moment and will get back to you ASAP. On Wed, May 23, 2018 at 3:14 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers, > > Just to remind that if you need some more information from

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

Hello Hackers, Just to remind that if you need some more information from our side you can ping us. Can we expect and email tomorrow morning with the commit? Thanks Victoria & Joao On Mon, May 21, 2018 at 9:56 AM Dave Page wrote: > Ashesh, please prioritise this so we can move on. > > Thanks.

Re: [pgAdmin4][RM#3271] Update to the latest 3.x version of jQuery

HI Aditya, Good job porting the app from the ancient version of JQuery to the latest build :D The patch in general looks good, and the patches-bot says all tests pass. The only thing that we would like to point out is this piece of code: /* jQuery has removed selector property in version 3.x *

Re: Implement geospatial data viewer in pgAdmin4 for PostGIS

Hello Xuri, Welcome to the pgadmin project. Let us give you some guidelines/pointers to help you out starting. As a general rule of thumb all the new development should be done in a separate file that contain the functionality itself. For Javascript, - Has you might have notice we started some tim

Implement geospatial data viewer in pgAdmin4 for PostGIS

Hi Dave/Team, My name is Xuri Gong. I am working on implementing geospatial data viewer in pgAdmin4. I wrote a design document for the viewer[1] according to the related issue[2] and I am wondering if it is a proper design. It would be great if there are any suggestions. I have read the #pgAdmin

pgAdmin 4 commit: Batch, not bash!! Correct the syntax.

Batch, not bash!! Correct the syntax. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=61d8072a8c5950d12b0eae559bff6f65671b67f0 Modified Files -- Make.bat | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

pgAdmin 4 commit: Hack to compile PyCrypto with VC++

Hack to compile PyCrypto with VC++ Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fa07400fddd3dd6c30df7b3a957418c1ebbed03a Modified Files -- Make.bat | 11 +++ 1 file changed, 11 insertions(+)

Re: GSoC Introduction - Implement geospatial data viewer in pgAdmin4 for PostGIS

Hi Anthony, Thank you for your suggestion. I received some feedback from PostGIS community and wrote a design document for the viewer[1]. I plan to create a new panel beside the output data grid in the sqleditor to show map. It would be great if there are any suggestions. It's necessary for me to

Re: [pgAdmin4][RM#3271] Update to the latest 3.x version of jQuery

Hi Hackers, Please find the updated patch for upgrading the jQuery version to 3.x. The patch is only for pgAdmin4 code changes replacing old deprecated functions with new replacement. We need to look into external libraries used for any vulnerabilities. Request you to kindly review. Thanks and Re

pgAdmin 4 commit: Fix PyCrypto if using Python 3.

Fix PyCrypto if using Python 3. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dab5d94b7c2d54ad62cd00a786183fe926a2df9d Modified Files -- Make.bat | 6 ++ 1 file changed, 6 insertions(+)

pgAdmin 4 commit: Add missing .

Add missing . Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2c6938491ecab0b75581396060d6eaeb9ea409cd Modified Files -- Make.bat | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)