Re: [pgAdmin][RM4451]Cannot construct SQL script for composite type having only one field variable

2019-11-01 Thread Dave Page
Thanks, patch applied. On Fri, Nov 1, 2019 at 9:54 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > pgAdmin allows to create composite type only with 2 or more members. > Attached is the patch to remove the restriction as PostgreSQL allows zero > or more and fix t

pgAdmin 4 commit: Remove arbitrary (and incorrect) requirement that com

2019-11-01 Thread Dave Page
Remove arbitrary (and incorrect) requirement that composite types must have at least two members. Fixes #4451 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=080ccdda5b293864f752b02b37e5ec9a51a1236b Author: Aditya Toshniwal Modified Files --

pgAdmin 4 commit: Ensure that units are respected when sorting by file

2019-11-01 Thread Dave Page
Ensure that units are respected when sorting by file size in the File dialog. Fixes #4647 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a7d8b9de8c3a931c2ed5f71ec585911456956564 Author: Aditya Toshniwal Modified Files -- docs/en

Re: [pgAdmin][RM4647] Select File Dialog Sort by file size does not take units into account

2019-11-01 Thread Dave Page
Thanks, patch applied. On Fri, Nov 1, 2019 at 7:03 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix sorting by file size in file dialog. > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | Enterpr

Re: [pgAdmin][RM3999] SQL Editor - Upper case shortcut on MacOS

2019-11-01 Thread Dave Page
Thanks, applied. On Fri, Nov 1, 2019 at 4:38 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is a tiny patch to fix keyboard shortcut for toggle case. > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB

pgAdmin 4 commit: Fix the toggle case shortcut key combination. Fixes #

2019-11-01 Thread Dave Page
Fix the toggle case shortcut key combination. Fixes #3999 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=30c7effa502566c9096286f1d5ba0edf57ec4197 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_15.rst

Re: [pgAdmin][RM4242] Server "Statistics" tab, broken sort

2019-11-01 Thread Dave Page
Thanks, patch applied. On Thu, Oct 31, 2019 at 11:28 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix sorting in backgrid for columns with null > values. > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software E

pgAdmin 4 commit: Handle NULL values appropriately when sorting backgri

2019-11-01 Thread Dave Page
Handle NULL values appropriately when sorting backgrid tables. Fixes #4242 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f85efb27974d503bdbf027644f17f027ac3464d4 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_note

pgAdmin 4 commit: Ensure comments are shown in reverse engineered SQL f

2019-11-01 Thread Dave Page
Ensure comments are shown in reverse engineered SQL for table partitions. Fixes #4191 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f8e0b54836531d9c5afe494c0d9a8345d5cddb91 Author: Aditya Toshniwal Modified Files -- docs/en_US/

Re: [pgAdmin][RM4191] Comments is not visible in SQL pane for partition table

2019-11-01 Thread Dave Page
Thanks, applied. On Thu, Oct 31, 2019 at 9:48 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is a tiny patch to show comments in SQL tab for partitions of a > table. > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Enginee

Re: [pgAdmin][RM4006] Trigger enable always/replica shown as disabled

2019-11-01 Thread Dave Page
Thanks, applied. On Thu, Oct 31, 2019 at 7:52 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch for Bug-cum-feature to show always/replica options > for triggers. > The "Trigger enabled" switch control is changed to select2 dropdown now, > wit

pgAdmin 4 commit: Support Enable Always and Enable Replica on triggers.

2019-11-01 Thread Dave Page
Support Enable Always and Enable Replica on triggers. Fixes #4006 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=131a944e246cf4ec71f064178725e33fbb0f4acd Author: Aditya Toshniwal Modified Files -- docs/en_US/compound_trigger_dial

[pgAdmin][RM4451]Cannot construct SQL script for composite type having only one field variable

2019-11-01 Thread Aditya Toshniwal
Hi Hackers, pgAdmin allows to create composite type only with 2 or more members. Attached is the patch to remove the restriction as PostgreSQL allows zero or more and fix the issue where SQL is not generated for types having less than 2 members. Kindly review. -- Thanks and Regards, Aditya Tosh

[pgAdmin][RM4647] Select File Dialog Sort by file size does not take units into account

2019-11-01 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to fix sorting by file size in file dialog. Kindly review. -- Thanks and Regards, Aditya Toshniwal Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4647.patch Description: Binary data