Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing the columns in the existing view

2020-01-13 Thread Akshay Joshi
Hi Khushboo Following are the review comments: - Fix the PEP8 issue. - Drop query should be part of the jinja template for consistency. Currently, it is added through the python file. - Any changes in the view code should not warn the user "Changing the columns in a view requires d

[pgAdmin4][Patch]: RM 5053 - Getting an error while changing the columns in the existing view

2020-01-13 Thread Khushboo Vashi
Hi, Please find the attached patch for RM #5053 - Getting an error while changing the columns in the existing view. PostgreSQL doesn't allow to change the view columns. So, while performing this task the existing view should be dropped first and then recreate it and also user will get a warning f

[pgAdmin][RM5000] Logout the inactive session

2020-01-13 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch for the feature where inactive session will be logged out. Note that, here inactive session means no user activity of mouse move, click or keypress. I've introduced two config params: 1. USER_INACTIVITY_TIMEOUT - Interval in seconds for the timeout. Default is 0-Z

pgAdmin 4 commit: Schema Diff Improvements:

2020-01-13 Thread Akshay Joshi
Schema Diff Improvements: 1. Grid header should be center aligned vertically. 2. Increase the space between object counts. 3. The previous selected objects should not be re-selected on comparison. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h

Re: pgAdmin 4 commit: Added Schema Diff tool to compare two schemas and gen

2020-01-13 Thread Murtuza Zabuawala
Hi Khushboo, We can create a common function in Server node to fetch the servers and then use that same function in the schema diff tool, currently we have written the same function in schema diff tool to avoid duplicate code. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.c