[pgadmin4][patch] GreenPlum error while checking roles SQL

Hi Hackers, Attached you can find a patch that will correct issue #3578 The SQL command used to retrieve the SQL for the Role does not work, because it as a piece of it that is intended for Postgres > 9.0. Thanks Joao diff --git a/web/pgadmin/browser/server_groups/servers/roles/templates/role/sq

[pgadmin4][patch] Correct issue on external tables

Hi Hackers, You can find attached a patch that corrects the RM #3431. When trying to retrieve the DDL of an external table and exceptions was being raised. Thanks Joao diff --git a/web/pgadmin/browser/server_groups/servers/databases/external_tables/templates/sql/gpdb_5.0_plus/create.sql b/web/pg

Re: [pgadmin4][Patch]: Support for create multiple test classes in one test file

Hello Hackers, Instead of doing this change and include more test harnessing to the setup we have, do you think we can try to push to get pytest into the code base and all these features will come by default? Thanks Joao ​ On Tue, Jun 12, 2018 at 9:30 AM Akshay Joshi wrote: > Hi Hackers, > > At

[pgadmin4][patch][GreenPlum] Display SQL for tables takes 15 minutes to execute

Hi Hackers, Attached you can find the diff file that corrects RM 3415 ​ Thanks Joao RM_3415.diff Description: Binary data

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hello Aditya, > > > There is no change related to notifications in this patch. > The below code is minor fix related to connection status of sql editor. > Can you please share the code snippet if it is not the below. > > -# Check for the asynchronous notifies statements. > -conn.ch

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

>> Aditya Toshniwal >> Software Engineer | EnterpriseDB Software Solutions | Pune >> "Don't Complain about Heat, Plant a tree" >> >> On Thu, May 31, 2018 at 6:42 PM, Dave Page wrote: >> >>> Hi >>> >>> On Thu, Ma

Re: [pgadmin4][Patch]: Test cases for the backup module

;>> >>>>>>> return self._parent.execute(command, params) >>>>>>> >>>>>>> File >>>>>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py", >

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

the skip that previously was around the entire function to surround only the pg_notify call Thanks Victoria && Joao ​ On Wed, May 30, 2018 at 1:52 AM Akshay Joshi wrote: > Hi Joao > > On Tue, May 29, 2018 at 9:10 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivota

Re: pgAdmin 4 commit: Disable emojis in Yarn output.

Hello Dave, When running yarn linter after this commit we get the following: yarn run v1.7.0 $ yarn eslint --emoji false --no-eslintrc -c .eslintrc.js --ext .js --ext .jsx . $ /Users/pivotal/workspace/pgadmin4/web/node_modules/.bin/eslint --emoji false --no-eslintrc -c .eslintrc.js --ext .js --ext

Re: [pgAdmin4][Patch#3389] To prevent unwanted model changes in Server dialog

Hi Murtuza, We are having a hard time understanding the logic on the change. If tunnel_authentication is not on the model and the tunnel_identify_file is present, we change the tunnel_identify_file in the model to null? Is this what you mean? Thanks Victoria && Joao ​ On Wed, May 30, 2018 at 9:

Re: [PATCH] Support for the source-map in Karma test framework

Hello Ashesh The change looks great. This will help the community a lot when we are TDDing new features. Please do not forget NOT to commit the second patch. Thanks Victoria && Joao On Wed, May 30, 2018 at 3:51 AM Ashesh Vashi wrote: > Hi Team, > > Debugging the failed jasmine test-cases is v

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hello Aditya, It looks ok and it passes CI. We have some recommendations: - These look like 2 different changes so they should be in separated commits - Do we have test coverage for the bug that you are talking about? If not we should, to ensure this problem does not happen again in a future chan

Re: [pgAdmin4][Patch] RM #3355 User can not perform operation of backup,Backup all, Backup global and Maintenance DB with ssh tunneling

Hello Akshay, Looks like the tests failed, but it is just flakes. We assume no regression was made with this code, despite the fact that no tests were added to ensure the new code is working. Thanks Anthony && Joao On Tue, May 29, 2018 at 6:41 AM Akshay Joshi wrote: > Hi Hackers, > > Attached

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hello Akshay, The code looks good, we do have some minor notes for next time: . To make the code easier to understand we should decide on 1 term and not have notifies and notifications to reference the same thing. . It would be nice if we tried not to use XPATH to get the HTML components that we

Re: [pgadmin4][patch] Use pytest test runner for unit tests

Hello Dave > As part of the development environment we do not see the reasoning behind >> not add PYTHONPATH to the environment variables, specially because this >> looks like the way pytest was invisoned. >> > > Really? It's one more step that wasn't previously required, and for which > there is

Re: Nightly snapshot builds

Hi Dave That is huge news, this takes us closer to a more frequent cadence of releases and that is very exciting prospect. Thanks for all the hard work to make this change. Best regards Joao On Fri, May 25, 2018, 6:34 AM Ashesh Vashi wrote: > Awesome - Dave! > > -- > > Thanks & Regards, > > As

Re: [pgadmin4][patch] Use pytest test runner for unit tests

As part of the development environment we do not see the reasoning behind not add PYTHONPATH to the environment variables, specially because this looks like the way pytest was invisoned. However please try the following patch instead. We've changed the pytest invocation to assume the relevant dir

Re: [pgAdmin4][RM#3271] Update to the latest 3.x version of jQuery

less information, >> not sure why. I had tried using css selector for id, tried extracting id >> directly, class, but none of them were present in the object. >> >> I can try adding data-test-selector to the HTML5 tag, if it works then >> will send the updated pa

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

Hey, Thanks so much for the reply. We've noticed that you've made several modifications on top of our original patch. Unfortunately, we've found it very hard to follow. Could we please get a brief synopsis of the changes you have made - just so we can better understand the rationale behind them? J

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

Hello Hackers, Just to remind that if you need some more information from our side you can ping us. Can we expect and email tomorrow morning with the commit? Thanks Victoria & Joao On Mon, May 21, 2018 at 9:56 AM Dave Page wrote: > Ashesh, please prioritise this so we can move on. > > Thanks.

Re: [pgAdmin4][RM#3271] Update to the latest 3.x version of jQuery

HI Aditya, Good job porting the app from the ancient version of JQuery to the latest build :D The patch in general looks good, and the patches-bot says all tests pass. The only thing that we would like to point out is this piece of code: /* jQuery has removed selector property in version 3.x *

Re: Implement geospatial data viewer in pgAdmin4 for PostGIS

Hello Xuri, Welcome to the pgadmin project. Let us give you some guidelines/pointers to help you out starting. As a general rule of thumb all the new development should be done in a separate file that contain the functionality itself. For Javascript, - Has you might have notice we started some tim

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

ashesh.va...@enterprisedb.com> wrote: >>> >>>> On Mon, May 14, 2018 at 2:59 PM, Dave Page wrote: >>>> >>>>> >>>>> >>>>> On Sat, May 12, 2018 at 12:10 AM, Ashesh Vashi < >>>>> ashesh.va...@enterpri

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hi Akshay, This patch is flaky; it doesn't always pass the tests in our pipeline. == ERROR: runTest (pgadmin.fe

Re: [pgAdmin4][Patch]: Minor JS Fix

Hi, The code looks fine, all tests pass and linter. Once again, not to sound like a broken record, we could have done some much more to improve our code base Why didn't we extract that function into a more testable place? In order for the code to become more clean and modular, we should try t

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

Hello Ashesh, 1. In TreeNode, we're keepging the reference of DOMElement, do we really >> need it? > > As of right now, our Tree abstraction acts as an adapter to the aciTree >> library. The aciTree library needs the domElement for most of its functions >> (setInode, unload, etc). Thus this is the

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

ked the design so far. > But - as Khushboo mentioned ealier - it is missing at some places. > I had to read through the code to understand the execution flow for some. > > And, there is still a lot missing bits, and pieces to consider for commit > in the repo. > > -- Thanks, Ashesh

Re: [pgAdmin4][Patch]: RM 3284 - F5 key not working consistently

I have noticed that you > deleted attachShortcut and attachDialogTabNavigatorShortcut functions from > keyboard.js, any specific reason for that? > > Thanks, > Khushboo > > On Fri, Apr 27, 2018 at 3:11 AM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: >

Re: [pgAdmin4][Patch]: RM 3284 - F5 key not working consistently

Hi Khushboo, I did some changes on your patch: 0001 - Your original patch 0002 - Convert keyboard.js to ES6 0003 - Refactoring of the keyboard.js file(some one letter variables and other code) Thanks Joao On Thu, Apr 26, 2018 at 5:34 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrot

Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel

at 11:45 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Joao >> >> On Tue, Apr 24, 2018 at 10:04 PM, Joao De Almeida Pereira < >> jdealmeidapere...@pivotal.io> wrote: >> >>> Hi Akshay, >>> >>> After looking thr

[pgadmin4][patch] Old code failing CI

Hi Hackers, Attached you can find a patch of some leftover code that we didn't realize was still there. Thanks Joao old-code.patch Description: Binary data

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

; >>>>>- Set the "Lock layout?" flag to False. >>>>>- Move out Dashboard panel. >>>>>- Set the "Lock layout?" flag to True. >>>>>- Close the Dashboard panel, as layout is locked and empty >>>&

[pgadmin4][patch] [GreenPlum] Partitioned table icon is the same as non partitioned tables

Hi Hackers, Attached you can find 2 patches that correct the Redmine: #3308 A Patches: 0001 - In this patch we update the SQL to retrieve the is_partitioned flag from the database 0002 - Extract and refactor the icon css class retrieval. It was scattered

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

Hi Hackers, Can someone review and merge this patch? Thanks Joao On Wed, Apr 18, 2018 at 10:23 AM Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > Any other comment about this patch? > > Thanks > Joao > > On Tue, Apr 10, 2018 at 12:00

Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel

Hi Akshay, After looking through the patch we found some one letter variable names and this is a regression on what we have been trying to accomplish in the last year. An objective that we have for pgAdmin source code is to increase the testability of it and make it more readable. If we keep on a

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

>>> On Wed, Apr 4, 2018 at 10:45 AM, Murtuza Zabuawala < >>>>>>>> murtuza.zabuaw...@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> On Wed, Apr 4, 2018 at 2:47 PM, Dave Page >>>>>>

[pgadmin4][patch] [GreenPlum] Display SQL of table with index #3306

Hi Hackers, Attached you can find the patch that corrects the rm - 3306. Also adds some tests around the behavior of the wrapping function of the table controller. Thanks Anthony & Joao diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/tests/test_utils.py b/web/pgadmi

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

Hi Hackers, Any other comment about this patch? Thanks Joao On Tue, Apr 10, 2018 at 12:00 PM Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Khushboo > > On Mon, Apr 9, 2018 at 1:59 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: &g

Re: [pgAdmin4][RM#3272] - Replace the pycrypto with the pycryptodome

Hi Aditya, Didn't we revert a patch that added pycryptodome due to problem in problems on windows? Is it solved now? Thanks Joao On Wed, Apr 18, 2018 at 7:23 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > PFA patch for replacing pycrytpo with pycryptodome. > Te

Re: pgAdmin 3.0 builds

2, 2018 at 7:14 PM, Dave Page wrote: > >> Hi >> >> On Thu, Apr 12, 2018 at 2:29 PM, Joao De Almeida Pereira < >> jdealmeidapere...@pivotal.io> wrote: >> >>> Hi Dave, >>> Did you remove the folder with the builds? >>> >

Re: pgAdmin 3.0 builds

Hi Dave, Did you remove the folder with the builds? What is the git SHA from which the release is going to be created from? Thanks Joao On Thu, Apr 12, 2018 at 4:08 AM Dave Page wrote: > Hi > > On Wed, Apr 11, 2018 at 6:08 PM, Christoph Berg wrote: > >> Re: Dave Page 2018-04-11 < >> ca+ocxoxvs

Re: Bug #3083 fix

hed typing... >>> >>> On Tue, Apr 3, 2018 at 1:38 PM, Dave Page wrote: >>> >>>> Hi >>>> >>>> On Thu, Mar 29, 2018 at 4:29 PM, Joao De Almeida Pereira < >>>> jdealmeidapere...@pivotal.io> wrote: >>>> >>&

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

Hello Khushboo On Mon, Apr 9, 2018 at 1:59 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Joao, > > I have reviewed your patch and have some suggestions. > > On Sat, Apr 7, 2018 at 12:43 AM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io

Re: [pgAdmin4][RM#3257] Fix for explain functionality

Hi Murtuza, Looks like the tests are failing due to this change. I also got some strange result on the linter, but I believe it is something related to this machine. Thanks Joao On Tue, Apr 10, 2018 at 6:20 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > A minor

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

gards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Thu, Apr 5, 2018 at 7:08 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Khushboo, >> Attached you can find both patches reb

Re: [pgAdmin4][RM#3072] Make pgagent job history rows configurable

Hi Murtuza, Generally the patch looks good passes all CI but the linter fails: /tmp/build/4a5630c2/pivotal-rm-3072/web /tmp/build/4a5630c2 ./pgadmin/browse

Re: pgAdmin4 - Issue of unmaintained libraries

Hi Dave, On Tue, Apr 3, 2018 at 8:32 AM Dave Page wrote: > Hi > > On Tue, Apr 3, 2018 at 1:22 PM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi Team, >> >> As we are heavily dependent on 3rd party JS libraries and some of them >> are no longer actively maintained by th

Re: [pgAdmin4][RM#3154] Update modules to latest version

Hi Murtuza, The patches look good and they pass all tests in CI. One think that we realized was the SlickGrid as a npm package now: https://www.npmjs.com/package/slickgrid Also Slickgrid comes packaged with jquery 3.1 not sure if it is fully supported or not.. Thanks Victoria & Joao On Tue,

Re: [pgAdmin4][RM#3235] Code refactoring in Query tool

Hi Murtuza It is really good to see other patches that are just refactoring code. We have some suggestions: - We are trying to use === instead of == because === ensure that the type is also checked ( https://developer.mozilla.org/en-US/docs/Web/JavaScript/Equality_comparisons_and_sameness ) - Now

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

Victoria & Joao On Tue, Apr 3, 2018 at 7:57 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Thanks Joao for reviewing. > > PFA updated patch. > > On Tue, Apr 3, 2018 at 1:11 AM, Joao De Almeida Pereira < > jdealmeidapere...@pivota

[pgadmin4][patch] #3244 Query elapse time granularity

Hi Hackers, Attached you can find a patch that increases the granularity of time displayed for total run time of a query. Also extracts the functionality, wraps it with tests. An addon to this patch is the extraction of the function call_render_after_poll that uses the function that calculates th

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

and wcDocker). I might even add to the mix jquery 1.11.2 because it stopped being actively developed and supported after May 20 of 2016. > For time being, I've created subtask for this issue > https://redmine.postgresql.org/issues/3243 > > Thanks, > Murtuza > ​ > On T

Re: [pgAdmin4][Patch][Feature #1998] Appends .sql if extension not given when using 'save' or 'save as' feature

Hi Rahul, I see you extracted some code, that is a pretty good move :D We run the patch through the testing pipeline and everything is green GJ :D Also tested the functionality by hand and looks like it is working except for "add the .sql extension when format is set to SQL." if you set it to All

Re: [pgAdmin4][Patch]: RM #3180 Index node is missing from the tree view of the table node

Hi Murtuza, Lets imagine you have CREATE TABLE cities ( city_id bigserial not null, name text not null, population int ) PARTITION BY LIST (initcap(name)); CREATE TABLE cities_west PARTITION OF cities ( CONSTRAINT city_id_nonzero CHECK (city_id != 0) ) FOR VA

Re: Bug #3083 fix

Hi Dave, That looks like in the surrounding area of the change. We run our pipeline and everything was green. Can you provide more details, which python version are you using? OS? Thanks Joao On Thu, Mar 29, 2018 at 9:03 AM Dave Page wrote: > Hi > > On Wed, Mar 28, 2018 at 7:06 PM

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

Hi Murtuza, After changing the setting in the preferences nothing happened, we had to reset the layout or refresh the app to see it working. It only looks the right side. Was this the intended behavior? Not sure if this is the expected behavior or not. I would expect that any change I do in the p

Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations

Hi Khushboo, The patch looks like it is heading on the correct direction, we passed it through our test pipeline and all tests passed. We found the same issues as Dave mentioned in his email, also after some code review we have the following questions/comments: . Why does modify_animation.js hav

Jasmine introduction

Hi Hackers, In one of the other thread Murtuza asked for more information about jasmine framework and we dig up some information about it. Jasmine is a lightweight framework that allow you to write tests in a behavior-driven style. Because of this it is a very easy to use framework with very few f

Re: How to enable debug mode to See changes on the fly?

Hello Rahul, In fact when you change python code there isn't much you can do, you need to restart the server every time. For the Javascript code you can have a second console open and run `yarn bundle:watch` and it will regenerate the javascript code and you just need to refresh the webpage on the

Re: Bug #3083 fix

2018 at 3:40 AM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Neethu, >> We passed the patch through our CI pipeline and all tests pass. >> The code looks good, but we are trying to decouple files as much as we >> can so that we

Re: [pgAdmin4][patch]: RM #3090 pgadmin shows misleading "Query returned successfully" with incorrect SQL

Hi Akshay, Thanks for the clarification, looks like there isn't much we can do then Best Regards, Joao On Wed, Mar 28, 2018 at 1:35 AM Akshay Joshi wrote: > Hi Joao > > On Tue, Mar 27, 2018 at 6:53 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: &

Re: [pgAdmin4][patch]: RM #3090 pgadmin shows misleading "Query returned successfully" with incorrect SQL

at no one can manage. A situation like this look like a very promising candidate for extraction/refactoring in our point of view. In which situation do you normally refactor or extract code? Thanks Joao On Tue, Mar 27, 2018, 1:31 AM Akshay Joshi wrote: > Hi Joao > > On Tue, Mar 27, 201

Re: Trying to work on a feature.

Hello Rahul, This issues looks like it is located in the file pgadmin/tools/sqleditor/__init__.py in the function save_file Maybe around the code: # generate full path of file file_path = unquote(file_data['file_name']) if hasattr(str, 'decode'): file_path = unquote( file_data['file_n

Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations

Hi Khushboo, Looks like you have a typo on your CSS where it reads 'zoomeIn' it should be 'zoomIn'. Also setting more parameters into the window, in our experience, is never good, so maybe it is time to create a real settings cache that can retrieve from the backend the settings, like this one. T

Re: [pgAdmin4][patch]: RM #3090 pgadmin shows misleading "Query returned successfully" with incorrect SQL

Hello, We tried to reproduce the issue but we were not capable to reproduce it. What it is strange on the fix is that python is complaining about a different line then the one that was fixed. Maybe this is just a Python thing I assume that the fix works, but I would love to see some tests to e

Re: [pgAdmin4][RM#3055] Allow user to sort the data in View data mode

Hi Hackers, @Murtuza: The patch codewise looks good. Nice to see that we are using axios instead of jquery ajax calls and that there is some coverage for the change. Nevertheless the Javascript testing looks a bit slim and could be improved. Also the DataSorting class could have some other member

Re: v3.0 release on hold

Hi Hackers, Did we had any progress on the things that are holding the release back? Thanks Joao On Fri, Mar 23, 2018 at 9:26 AM Akshay Joshi wrote: > Hi Dave > > On Fri, Mar 23, 2018 at 11:06 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Thu, Mar 22, 2018 at 10:24 P

Re: Showstopper desktop runtime issue

Hello Hackers In the PoC we did with Electron last month this was the point where we stopped What did we accomplish: - Use Electron as a runtime and packaging solution for the application - Support opening new windows when the preferences ask for them - Make the application generally work - U

Re: Showstopper desktop runtime issue

Hello Hackers, Here is our take on the 3 options present: 1) QtWebkit and QtWebEngine Pros: - Webkit is a mature technology that as been around for some time - Apparently the Fork of Webkit we were using as been catching up Cons: - We are using a Fork - It is to far behind of the today browsers an

Re: Connection Refused Error

Hello Rahul, Did you change the /etc/postgresql/10/main/pg_hba.conf file configuration to allow connections? if not take a look at https://www.thegeekstuff.com/2014/02/enable-remote-postgresql-connection/ this should guide you but basically you need to change the METHOD to `trust` on the 127.0.0.1

Re: v3.0 release on hold

order to generate binaries more frequently. Thanks Joao On Wed, Mar 21, 2018 at 12:54 PM Dave Page wrote: > Hi > > On Wed, Mar 21, 2018 at 4:22 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Dave, >> For number 1: >> https:/

Re: Experiencing issues

you follow the instructions and change the hosts file it allows you to start the application but when you try to open a database server you will get the 428 error Thanks Joao On Wed, Mar 21, 2018 at 12:01 PM Dave Page wrote: > On Wed, Mar 21, 2018 at 3:57 PM, Joao De Almeida Pereira < > jd

Re: v3.0 release on hold

Hello Dave, For number 1: https://blogs.gnome.org/aday/2017/08/31/status-icons-and-gnome/ We might need to build something like: https://itsfoss.com/best-indicator-applets-ubuntu/ Not sure if it is wise to do it in such a short notice. Thanks Joao On Wed, Mar 21, 2018 at 11:38 AM Khushboo Vashi <

Re: Experiencing issues

ery cumbersome, and somehow we should be able to disable this, because when we are developing doesn't make sense to not being able to use localhost and 127.0.0.1 Thanks Joao On Wed, Mar 21, 2018 at 11:01 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > On Wed, Mar 21, 2018

Re: Experiencing issues

So what you are saying is that if I have a server, I need to do DEFAULT_SERVER=0.0.0.0 and then set the real domain on the COOKIE domain? On Wed, Mar 21, 2018 at 10:55 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > On Wed, Mar 21, 2018 at 8:10 PM, Joao De Almeid

Re: Experiencing issues

Ok Murtuza you are right, Now my question is I have the default server to 127.0.0.1 and I want to access it using localhost as well. How can I do this? On Wed, Mar 21, 2018 at 10:39 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On 21 Mar 2018 20:01, "Joa

Re: Experiencing issues

prisedb.com > The Enterprise PostgreSQL Company > > > On Wed, Mar 21, 2018 at 7:55 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Where can I find information about that? >> >> On Wed, Mar 21, 2018 at 10:16 AM Khushboo Vashi <

Re: Experiencing issues

Where can I find information about that? On Wed, Mar 21, 2018 at 10:16 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On 21 Mar 2018 19:41, "Joao De Almeida Pereira" < > jdealmeidapere...@pivotal.io> wrote: > > Hello Hackers, > Can a

Experiencing issues

Hello Hackers, Can anyone use the current master branch? When I try to open a server I get a 428. Is that only me? Thanks Joao

Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed

'execute', >>>> [ '' ] ] but it was never called. >>>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the >>>> SQL statement is not empty when error is returned by the server when a new >>>> transaction is

Re: AttributeError

Hi Rahul, Sorry for the late reply, if you still have any issue just let us know Thanks Joao On Tue, Mar 20, 2018 at 4:21 PM Rahul Soshte wrote: > I installed from the git source but when I am trying to run the I am > getting this > error.I am using Ubuntu 17.10.What do I do? > > AttributeError

[pgadmin4][patch] Update karma to 2.0 #3222

Hi Hackers, Attached you can find the patch that updates karma to 2.0 and also other plugins from karma. The only plugins that are not updated are the jasmine ones because we are waiting on the support for jasmine 3.0 on karma-jasmine Thanks Joao karma-plugins-update.diff Description: Binary da

Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn

Hello, Personally I believe we should fix the config_local pep issues and just ignore the migrations. Specially because the migration file should not have a lot of python code. Thanks On Thu, Mar 15, 2018 at 3:32 PM Dave Page wrote: > On Thu, Mar 15, 2018 at 12:25 PM, Murtuza Zabuawala < > murt

Re: pgAdmin 4 commit: Refactor server dialogue validation for better unit t

Hi Khushboo, Good catch, attached you can find the fix for the problem. Thanks Victoria & Joao On Wed, Mar 14, 2018 at 10:37 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Joao/Victoria, > > I am getting an error while editing the server properties. Please refer > the attached

Re: pgAdmin 4 commit: Fix unicode handling in the external process tools an

Hi Dave, Khushboo Looks like there is a linting issue with this commit: Successfully installed pycodestyle-2.3.1 /tmp/build/4a5630c2/pgadmin-master/web /tmp/b

Re: [pgAdmin4][RM#3140] Add service parameter

Hi Dave and Murtuza, Regarding this patch we refactored the Javascript code so that is lives in a different file and added some tests. Also we found an issue with karma-jasmine that does not allow us to use jasmine 3.1 yet. You can find attached a patch that reverts that commit. Thanks Victoria

Re: pgAdmin 4 commit: Support for external tables in GPDB. Fixes #3168

also encounter similar issue on Windows while running tests. >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> On Tue, Mar 6, 2018 at 8:25 PM, Joao De Almeida Pere

Re: [pgadmin4][patch] Unit test fail on GreenPlum (#3190)

Hello, Can you point out an example? Thanks On Sat, Mar 10, 2018, 3:53 PM Dave Page wrote: > Hi > > On Friday, March 9, 2018, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Hackers, >> >> Attached you can find the patch that s

[pgadmin4][patch] Unit test fail on GreenPlum (#3190)

Hello Hackers, Attached you can find the patch that skip some tests and correct issues on SQL that are failing when trying to connect to a GreenPlum database. We did this by adding a attribute to to test_json called "db_type" that will carry the type of database we are running tests against. Whe

Re: ACI Tree

Hi Hackers, Maybe this list might not have a big group of users of the application itself, nevertheless it would be interesting to understand if this is a specific problem of GreenPlum Use Case or not. This issue is preventing a wider adoption of pgAdmin4 by the GreenPlum users. >From a preliminar

Re: pgAdmin 4 commit: Support EXPLAIN on Greenplum. Fixes #3097

On Fri, Mar 9, 2018 at 11:04 AM Dave Page wrote: > Hi > > On Fri, Mar 9, 2018 at 3:54 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello, >> Definitely running single tests is something that would be great, >> specially if

Re: pgAdmin 4 commit: Support EXPLAIN on Greenplum. Fixes #3097

response_data = json.loads(response.data.decode('utf-8')) self.server_id = response_data['node']['_id'] def tearDown(self): """This function delete the server from SQLite """ utils.delete_server_with_api(self.

Re: [pgAdmin4][RM#2989] To fix the issue in Table node

Hello Murtuza/Dave, Nice splitting of some of the functionality into functions, removing some of the complexity of the initial function. Good job. I made some changes because the linter was failing and also changed some variable names. These changes pass our CI and the linter. Thanks Joao On Th

Re: pgAdmin 4 commit: Support EXPLAIN on Greenplum. Fixes #3097

Hello Khushboo, Completely forgot about this python "feature"... Attached is the fix. Just as a side question, does anyone else feel the pain of wanting to run a single test using a IDE or the command line and not being able to? We an HandRolled the loader, and that as some implications. Did a

[pagdmin][patch] Update jasmine #3182

Hi Hackers, Attached you can find the patch that updates the version of jasmine to 3.0 Thanks Joao diff --git a/web/package.json b/web/package.json index 2707b334..a4cb58d5 100644 --- a/web/package.json +++ b/web/package.json @@ -18,7 +18,7 @@ "file-loader": "^0.11.2", "image-webpack-lo

Re: [pgAdmin4][RM#3037] Allow user to disable Gravatar image

brainer really, > assuming we ensure we update/invalidate the cache when needed), and using > promises for accessing them. > > >> >> I may be wrong, Let's wait for the input from other community members. >> >> Regards, >> Murtuza >> >> On Tue

Re: [pgAdmin4][RM#2989] To fix the issue in Table node

Hi Murtuza, The code change works, and I passed the patches through our pipeline and everything is green. Personally I would love this bug fixes to have refactored the function into smaller chunk and made it more readable so that the next time someone need to check out a problem in the same area i

Re: [pgAdmin4][Patch]: RM #3135 - [Web based] Syntax error displayed when user try to insert data on table where primray key is in captial letters and table contains OIDS

ao On Tue, Mar 6, 2018 at 7:33 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Joao, > > Thanks for reviewing. > > On Thu, Mar 1, 2018 at 8:06 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Kushboo, >> >

Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query

Hello Khushboo, Thanks for the changes here. Now everything looks good, and the tests all pass. Thanks Joao On Tue, Mar 6, 2018 at 5:09 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > On Mon, Mar 5, 2018 at 8:42 PM, Joao De Almeida Pereira < > jdealmeidapere...@pi

Re: pgAdmin 4 commit: Support for external tables in GPDB. Fixes #3168

Hello Neel, You can find attached the corrections of the path's needed for windows. The fix should correct TestExternalTablesView and TestTemplateCreate but for the ChangePasswordTestCase I need more information to help you out. We need to understand what is the response that the endpoint /user_ma

  1   2   >