Re: pgAdmin v3.1 candidate builds and source...

2018-06-27 Thread Robert Eckhardt
On Tue, Jun 26, 2018 at 8:12 PM, Anthony DeBarros wrote: > Sounds good! Must just be my environment. Thanks for checking it out! > > On Tue, Jun 26, 2018 at 2:11 PM Fahar Abbas > wrote: > >> Hi Anthony! >> >> I am not able to reproducible this issue using Browser[Chrome Version >> 67.0.3396.99 (

Re: Release this week?

2018-06-25 Thread Robert Eckhardt
Shipit On Mon, Jun 25, 2018, 10:37 AM Dave Page wrote: > Anyone have any reasons why we shouldn't push a release this week using > the new automated build system (assuming they work as planned and no issues > are found in QA)? > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pg

Re: [pgadmin4][patch][GreenPlum] Display SQL for tables takes 15 minutes to execute

2018-06-11 Thread Robert Eckhardt
On Tue, Jun 12, 2018, 12:27 AM Ashesh Vashi wrote: > Hi Joao, > > On Tue, Jun 12, 2018 at 1:50 AM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Hackers, >> >> Attached you can find the diff file that corrects RM 3415 >> >> >

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

2018-05-31 Thread Robert Eckhardt
All, These patches were first proposed on April 2 and the meaningful changes have yet to be committed. ~8 weeks is long enough that my assumption now is that these aren't going to be committed. The goal of these patches is to begin to separate out the ACI tree in order to allow us to do feature w

Re: Possibility to increase release frequency

2018-04-30 Thread Robert Eckhardt
On Mon, Apr 30, 2018 at 10:51 AM, Dave Page wrote: > Hi > > On Mon, Apr 30, 2018 at 3:33 PM, Robert Eckhardt > wrote: >> >> All, >> >> Currently we are starting to get a fair number of users leveraging >> pgAdmin 4. Because of this we are finding new iss

Possibility to increase release frequency

2018-04-30 Thread Robert Eckhardt
All, Currently we are starting to get a fair number of users leveraging pgAdmin 4. Because of this we are finding new issues with Greenplum we didn't previously know about and we would like to get the fixes for those issues out as soon as possible. The current release process is shrouded in a bit

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

2018-04-05 Thread Robert Eckhardt
On Wed, Apr 4, 2018 at 11:31 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Wed, Apr 4, 2018 at 8:09 PM, Dave Page wrote: > >> >> >> On Wed, Apr 4, 2018 at 12:54 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> On Wed, Apr 4, 2018 at 5:00 PM, Dav

Re: v3.0 release on hold

2018-04-03 Thread Robert Eckhardt
On Tue, Apr 3, 2018 at 11:04 AM, Dave Page wrote: > I'm thinking build Monday, release Thursday. > > Objections? > It we can make it happen faster I'd be all for it. If not that will work. Thanks -- Rob > > > On Tue, Apr 3, 2018 at 2:43 PM, Robert Eckhardt >

Re: v3.0 release on hold

2018-04-03 Thread Robert Eckhardt
All, Where are we with respect to cutting this release? -- Rob On Mon, Mar 26, 2018 at 9:59 AM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > Did we had any progress on the things that are holding the release back? > > Thanks > Joao > > On Fri, Mar 23, 2018 at

Re: [pgadmin4][patch] #3244 Query elapse time granularity

2018-04-02 Thread Robert Eckhardt
On Mon, Apr 2, 2018 at 6:24 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > Attached you can find a patch that increases the granularity of time > displayed for total run time of a query. > Also extracts the functionality, wraps it with tests. > An addon to thi

Re: [pgAdmin4][Patch]: RM #3180 Index node is missing from the tree view of the table node

2018-03-29 Thread Robert Eckhardt
On Thu, Mar 29, 2018 at 12:45 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Thanks Akshay & Joao, got it. > > My bad sorry for the noise. > The question helped me, nothing wrong with questions. -- Rob > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enter

Re: [pgAdmin4][RM#3055] Allow user to sort the data in View data mode

2018-03-28 Thread Robert Eckhardt
On Wed, Mar 28, 2018 at 11:20 AM, Dave Page wrote: > > > On Wed, Mar 28, 2018 at 2:54 PM, Robert Eckhardt > wrote: > >> >> >> On Wed, Mar 28, 2018 at 4:12 AM, Dave Page wrote: >> >>> >>> >>> On Wed, Mar 28, 2018 at 1:37 AM, Robe

Re: [pgAdmin4][RM#3055] Allow user to sort the data in View data mode

2018-03-28 Thread Robert Eckhardt
On Wed, Mar 28, 2018 at 4:12 AM, Dave Page wrote: > > > On Wed, Mar 28, 2018 at 1:37 AM, Robert Eckhardt > wrote: > >> >> >> On Tue, Mar 27, 2018 at 9:54 AM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>&

Re: [pgAdmin4][RM#3055] Allow user to sort the data in View data mode

2018-03-27 Thread Robert Eckhardt
On Tue, Mar 27, 2018 at 9:54 AM, Murtuza Zabuawala wrote: > > > On Tue, Mar 27, 2018 at 7:06 PM, Robert Eckhardt > wrote: > >> >> >> On Tue, Mar 27, 2018 at 6:25 AM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> &g

Re: [pgAdmin4][RM#3055] Allow user to sort the data in View data mode

2018-03-27 Thread Robert Eckhardt
On Tue, Mar 27, 2018 at 6:25 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > On Tue, Mar 27, 2018 at 3:13 PM, Dave Page wrote: > >> >> >> On Mon, Mar 26, 2018 at 9:26 PM, Robert Eckhardt >> wrote: >> >>> >>>

Re: [pgAdmin4][RM#3055] Allow user to sort the data in View data mode

2018-03-26 Thread Robert Eckhardt
On Mon, Mar 26, 2018 at 2:07 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > @Murtuza: The patch codewise looks good. Nice to see that we are using > axios instead of jquery ajax calls and that there is some coverage for the > change. > Nevertheless the Javascr

Re: Showstopper desktop runtime issue

2018-03-22 Thread Robert Eckhardt
On Thu, Mar 22, 2018 at 12:28 PM, Dave Page wrote: > Hi > > On Thu, Mar 22, 2018 at 4:17 PM, Magnus Hagander > wrote: > >> >> >> On Thu, Mar 22, 2018 at 3:57 PM, Joao De Almeida Pereira < >> jdealmeidapere...@pivotal.io> wrote: >> >>> Hello Hackers, >>> Here is our take on the 3 options present:

Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed

2018-03-20 Thread Robert Eckhardt
Thanks for doing this, sorry about the breakage. We're taking a look at this to make sure it is still working with Greenplum. -- Rob On Tue, Mar 20, 2018 at 9:12 AM, Akshay Joshi wrote: > Hi Hackers > > Attached is the patch file to fix the RM #2815. > > On Tue, Mar 20, 2018 at 3:24 PM, Dave P

ACI Tree

2018-03-07 Thread Robert Eckhardt
Hackers, We have multiple end users who have in excess of 10 thousand of tables in a single schema. Currently this causes pgAdmin to choke. The major issue we are seeing is that the ACI tree is unsupported and it seems to be the backbone of pgAdmin 4. Is anyone else having this issue? Is there

Next release

2018-02-15 Thread Robert Eckhardt
Apologies if this has been discussed and I missed it. When is the 3.0 release planned? -- Rob

Re: Revamped runtime vs. Version number

2018-02-01 Thread Robert Eckhardt
On Thu, Feb 1, 2018 at 9:45 AM, Dave Page wrote: > So there's been nothing but positive feedback about the PoC revamped > runtime I asked folks on the lists to test. Thank you to everyone that did > so. > > With that in mind, I think we should use that in the next version and > moving forwards, a

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-08-30 Thread Robert Eckhardt
How does this reflect actual user workflow? I have never quite understood how a user was supposed to navigate through this, it seems like the expectation is to continually click until they see the thing they want rather than just going through as though it were a wizard. Is this something that coul

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

2017-08-25 Thread Robert Eckhardt
Given that Greenplum is going to GA next month can we get that stable OSS version included in the CI? Rob On Aug 25, 2017 8:27 AM, "Akshay Joshi" wrote: > Thanks patch applied. I haven't tested it on GPDB. > > On Fri, Aug 25, 2017 at 4:55 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrot

Re: Selecting tables from Browser

2017-08-21 Thread Robert Eckhardt
On Mon, Aug 21, 2017 at 7:17 PM, Shirley Wang wrote: > Hi Rob > On Mon, Aug 21, 2017 at 1:53 PM Robert Eckhardt > wrote: > >> Shirley, >> >> I have a few questions. >> >>1. Why 20. It is a dunbar number and seems smallish but is there >>

Re: pgAdmin 4 commit: Fix test assertion.

2017-07-31 Thread Robert Eckhardt
The Enterprise PostgreSQL Company On Mon, Jul 31, 2017 at 5:43 PM, Robert Eckhardt wrote: > It fails because the test was broken and has never been fixed. > > Rob > > On Jul 31, 2017 8:03 PM, "Murtuza Zabuawala" < > murtuza.zabuaw...@enterprisedb.com> wrote: >

Re: pgAdmin 4 commit: Fix test assertion.

2017-07-31 Thread Robert Eckhardt
f it is because of Python3.6. > > On Mon, Jul 31, 2017 at 5:27 PM, Robert Eckhardt > wrote: > >> This was broken when the clear button and the edit button were changed to >> drop downs. Happened a few weeks ago. >> >> Rob >> >> On Jul 31, 2017 6:51 PM,

Re: pgAdmin 4 commit: Fix test assertion.

2017-07-31 Thread Robert Eckhardt
This was broken when the clear button and the edit button were changed to drop downs. Happened a few weeks ago. Rob On Jul 31, 2017 6:51 PM, "Murtuza Zabuawala" < murtuza.zabuaw...@enterprisedb.com> wrote: Hi All, When I run the feature tests, the gives test always fails ( 'query_tool_journey_

Re: Error using pgadmin4 HEAD

2017-07-29 Thread Robert Eckhardt
Dave, We just set up 3 workstations if you don't mind waiting a couple of days we can go in on Monday and share the directions we followed. Maybe that will help spell out how we can improve the documentation as well. Rob On Jul 29, 2017 2:34 PM, "Murtuza Zabuawala" < murtuza.zabuaw...@enterpris

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-21 Thread Robert Eckhardt
I'd say we should go with Cmd+/ and Cmd+Shift+/ as that seems the most common by a small margin - however, I'm still not convinced that we don't need two keys for optimal behaviour of line commenting. To be clear, I'm not 100% convinced either. I am, however, convinced that it is the right first

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-21 Thread Robert Eckhardt
> > Right - we lose the ability to uncomment multiple levels though, which may > also be useful. > Well yes. I would argue that simplicity trumps potential use. I'd also argue that attempting to maintain consistency across environments (IDEs, etc. ) is advantageous. This was the philosophy we wer

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-21 Thread Robert Eckhardt
ave Page wrote: > > > On Fri, Jul 21, 2017 at 4:21 PM, Robert Eckhardt > wrote: > >> I hope you're overthinking. Having not implemented it yet I'm not sure. >> >> Block commenting will look like the below >> >> /* >> CREATE TABLE fo

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-21 Thread Robert Eckhardt
, 2017 at 11:13 AM, Dave Page wrote: > > > On Fri, Jul 21, 2017 at 4:08 PM, Robert Eckhardt > wrote: > >> I wouldn't say wrong, it just wasn't what I was expecting. >> >> I guess I'd like to hear what others are expecting. If I had my way we &g

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-21 Thread Robert Eckhardt
garding choosing comma & period keys, they all are near each to each > other so user can remember them easily. > > Let me know If my thinking was wrong for shortcut keys, I'll change them > accordingly and send new patch. > > On Fri, Jul 21, 2017 at 4:25 PM, Robert Eckhar

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-21 Thread Robert Eckhardt
orms. On Fri, Jul 21, 2017 at 1:25 AM, Robert Eckhardt wrote: > Murtuza, > > Is there a particular reason you choose the keyboard shortcuts that you > choose. When we were looking at this earlier to see what was being used > elsewhere we discovered: > > jetbrains

Re: [PATCH] Persist opened nodes in tree

2017-07-20 Thread Robert Eckhardt
Versus, We are about to start a story to persist the Tabs and History. Since pgAdmin 4 is centered around the tree we need to be able to persist this first. If you are interested in making the changes suggested above we have some additional work to do, otherwise we'd be happy to pick this up and

Re: Request a feature

2017-07-20 Thread Robert Eckhardt
Nick, We were looking at adding this feature but ran into the same problem you are describing, e.g. when to include and when to not include headers. Honestly we were waiting for people to start using the new UX for the differing copy and paste functionality and waiting to see what people said. T

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-20 Thread Robert Eckhardt
Murtuza, Is there a particular reason you choose the keyboard shortcuts that you choose. When we were looking at this earlier to see what was being used elsewhere we discovered: jetbrains cmd+/ pycharmcmd+/ SublimeCtrl+/ Toggle line comment Ctrl+Shift+/ Toggle bloc

Re: [pgadmin-hackers][pgaweb][Patch] Add style guide to pga website

2017-07-18 Thread Robert Eckhardt
Looks good. I assumed American spelling, should we use proper English spelling? Our prodigious use of the 'z' (pronounced zee) definitely improves our scrabble scores. -- Rob On Tue, Jul 18, 2017 at 7:54 AM, Dave Page wrote: > > > On Mon, Jul 17, 2017 at 7:51 PM, Joao De Almeida Pereira < > jd

Re: pgadmin-for-web is going nowhere

2017-07-14 Thread Robert Eckhardt
I'm somewhat unclear as to what the desired behavior is supposed to be from the writeup of that Redmine issue. If I were to guess what was wanted it would be a slightly different build that included a container that had: - Python preconfigured - Apache HTTPD configured - Then had the app

Re: pgadmin-for-web is going nowhere

2017-07-14 Thread Robert Eckhardt
Josh, I'd be interested in knowing what specific things could be done to make you think that the Web version is no longer the 'ugly stepchild'. If I consider our (Pivotal's) current development process then the most honest thing we could say is that the desktop application is our afterthought. Al

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-12 Thread Robert Eckhardt
Yay. -- Rob On Wed, Jul 12, 2017 at 8:16 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch which will add functionality to allow user to comment/uncomment > code in query editor. > RM#2456 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enter

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-11 Thread Robert Eckhardt
Surinder, Sorry I'm missing the email can you tell me the name please. -- Rob On Tue, Jul 11, 2017 at 12:51 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > On Tue, Jul 11, 2017 at 10:18 PM, Robert Eckhardt > wrote: > >> The last email on this chain

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-11 Thread Robert Eckhardt
The last email on this chain from Surinder says that it isn't working on IE and he will submit another patch. Are we missing that patch? Would you like us to look at the previous patch? -- Rob On Jul 11, 2017 11:37 AM, "Dave Page" wrote: > Pivotal team; you guys are far more familiar with webp

Re: [pgAdmin4][Patch]: Refactor of the History Tab

2017-07-06 Thread Robert Eckhardt
Working on it. -- Rob On Thu, Jul 6, 2017 at 10:03 AM, Dave Page wrote: > And, Houston, we have a problem. The layout is quite broken on IE - which > of course we're working to use on Windows. Can you take a look ASAP please > Matt & friends? > > Screenshot attached. > > On Thu, Jul 6, 2017 at

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

2017-07-03 Thread Robert Eckhardt
On Mon, Jul 3, 2017 at 5:36 AM, Dave Page wrote: > > > On Fri, Jun 30, 2017 at 12:19 PM, Shirley Wang wrote: > >> Hello! >> >> Currently the app uses 'monospace' to define the font family for SQL >> queries and messages, which looks a little squished when in uppercase. PT >> mono is another mono

Re: [pgAdmin4][Patch]: Refactor of the History Tab

2017-06-30 Thread Robert Eckhardt
Surinder, It would be great if you could take a look at this an see if the style changes are more inline with what you were thinking when you commented on the first patch. -- Rob On Fri, Jun 30, 2017 at 11:55 AM, Shruti Iyer wrote: > Hi Hackers, > > Attached is the patch that refactors the rea

Re: Tree view icon samples

2017-06-28 Thread Robert Eckhardt
en > themselves. > > Regards, > Chethana kumar > > On Wed, Jun 28, 2017 at 10:32 PM, Robert Eckhardt > wrote: > >> I like them as well. The only comment I have is that the red icon on >> disconnected DB and corrupted DB are difficult to make out. They are >&g

Re: Tree view icon samples

2017-06-28 Thread Robert Eckhardt
I like them as well. The only comment I have is that the red icon on disconnected DB and corrupted DB are difficult to make out. They are clearly differentiable but the icon itself is unclear. -- Rob On Wed, Jun 28, 2017 at 12:49 PM, Dave Page wrote: > Hi > > > On 28 Jun 2017, at 12:41, Chethan

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-27 Thread Robert Eckhardt
On Tue, Jun 27, 2017 at 5:03 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers, > > When we started the app we noticed some change in the front end. > > The line numbers in the Editor: > - We noticed a bug with the numbers where at 1 rows, the numbers wou

Re: [pgadmin-hackers][patch] History Detail Pane

2017-06-27 Thread Robert Eckhardt
Harshal, Thanks for taking a look. That exact feature should be in our next patch along with a few style changes. -- Rob On Tue, Jun 27, 2017 at 2:03 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > New history pane is really nice and informative than existing one. > I'm j

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-27 Thread Robert Eckhardt
On Tue, Jun 27, 2017 at 12:16 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On 27 Jun 2017 18:33, "Dave Page" wrote: > > Thanks - patch committed! > > Awsome job :-) > > Gr8. Finally no more rebase request for Harshal. :) > +1 > On Tue, Jun 27, 2017 at 3:26 AM, Harshal Dhu