Code looks good to me. Thanks patch applied.
On Mon, Sep 11, 2017 at 5:40 PM, Akshay Joshi wrote:
>
>
> On Mon, Sep 11, 2017 at 5:34 PM, Dave Page wrote:
>
>> Akshay, can you review/commit this please?
>>
>
> Sure Dave.
>
>>
>> Thanks.
>>
>> On Mon, Sep 11, 2017 at 10:38 AM, Teng Zhang wro
On Mon, Sep 11, 2017 at 5:34 PM, Dave Page wrote:
> Akshay, can you review/commit this please?
>
Sure Dave.
>
> Thanks.
>
> On Mon, Sep 11, 2017 at 10:38 AM, Teng Zhang wrote:
>
>> Hi Hackers,
>>
>> Attached is a patch that makes SQL editor show syntax highlighting with
>> Greenplum keywor
Akshay, can you review/commit this please?
Thanks.
On Mon, Sep 11, 2017 at 10:38 AM, Teng Zhang wrote:
> Hi Hackers,
>
> Attached is a patch that makes SQL editor show syntax highlighting with
> Greenplum keywords.
>
> - Upgrade CodeMirror from 5.28 to 5.29 to include mime type "x-gpsql"
> - Us
On Mon, Sep 11, 2017 at 11:13 AM, Jing Li wrote:
> Can we get this patch into the 2.0 release?
>
Shouldn't be a problem. It didn't make todays build though.
>
>
> On Mon, Sep 11, 2017 5:38 PM, Teng Zhang tezh...@pivotal.io wrote:
>
>> Hi Hackers,
>>
>> Attached is a patch that makes SQL editor
Can we get this patch into the 2.0 release?
On Mon, Sep 11, 2017 5:38 PM, Teng Zhang tezh...@pivotal.io wrote:
Hi Hackers,
Attached is a patch that makes SQL editor show syntax highlighting with
Greenplum keywords.
- Upgrade CodeMirror from 5.28 to 5.29 to include mime type "x-gpsql"
- Use
Hi Hackers,
Attached is a patch that makes SQL editor show syntax highlighting with
Greenplum keywords.
- Upgrade CodeMirror from 5.28 to 5.29 to include mime type "x-gpsql"
- Use "x-gpsql" mode for sql editor when connecting database is greenplum
- No behavior change to pg and ppas, still use "x
