Re: [pgAdmin4][RM4017] Query Tool History persistence

2019-03-13 Thread Dave Page
Thanks - patch applied with a few tweaks: - Changed the button text to "Copy to Query Editor" and wrapped it in a gettext call. - Changed the timers to 100ms (it looked a bit sluggish otherwise). - Added a small doc update. On Wed, Mar 13, 2019 at 11:20 AM Aditya Toshniwal < aditya.toshni...@ente

Re: [pgAdmin4][RM4017] Query Tool History persistence

2019-03-13 Thread Aditya Toshniwal
Hi Hackers, Attached is the update patch. Now, 1) History data will be stored basis - userid/serverid/dbname. 2) Renaming the DB will trigger rename in history. 3) Deleting the server will remove the history for that server. 4) In details, date display done based on locale. 5) History loading and

Re: [pgAdmin4][RM4017] Query Tool History persistence

2019-03-13 Thread Aditya Toshniwal
On Wed, Mar 13, 2019 at 2:47 PM Dave Page wrote: > > > On Wed, Mar 13, 2019 at 6:30 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> >> >> On Wed, Mar 13, 2019 at 11:56 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> On Tue, Mar 12, 2019

Re: [pgAdmin4][RM4017] Query Tool History persistence

2019-03-13 Thread Dave Page
On Wed, Mar 13, 2019 at 6:30 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > > > On Wed, Mar 13, 2019 at 11:56 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Tue, Mar 12, 2019 at 6:27 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com>

Re: [pgAdmin4][RM4017] Query Tool History persistence

2019-03-13 Thread Dave Page
On Wed, Mar 13, 2019 at 6:26 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Tue, Mar 12, 2019 at 6:27 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> >> >> On Tue, Mar 12, 2019 at 6:14 PM Dave Page wrote: >> >>> >>> >>> On Tue, Mar 12, 2019 at

Re: [pgAdmin4][RM4017] Query Tool History persistence

2019-03-12 Thread Aditya Toshniwal
On Wed, Mar 13, 2019 at 11:56 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Tue, Mar 12, 2019 at 6:27 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> >> >> On Tue, Mar 12, 2019 at 6:14 PM Dave Page wrote: >> >>> >>> >>> On Tue, Mar 12, 2019 at

Re: [pgAdmin4][RM4017] Query Tool History persistence

2019-03-12 Thread Aditya Toshniwal
Hi, On Tue, Mar 12, 2019 at 6:27 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > > > On Tue, Mar 12, 2019 at 6:14 PM Dave Page wrote: > >> >> >> On Tue, Mar 12, 2019 at 12:33 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> On Tue, Mar

Re: [pgAdmin4][RM4017] Query Tool History persistence

2019-03-12 Thread Aditya Toshniwal
On Tue, Mar 12, 2019 at 6:14 PM Dave Page wrote: > > > On Tue, Mar 12, 2019 at 12:33 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Tue, Mar 12, 2019 at 4:02 PM Dave Page wrote: >> >>> Hi >>> >>> On Tue, Mar 12, 2019 at 7:00 AM Aditya Toshniwal < >>> adi

Re: [pgAdmin4][RM4017] Query Tool History persistence

2019-03-12 Thread Dave Page
On Tue, Mar 12, 2019 at 12:33 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > On Tue, Mar 12, 2019 at 4:02 PM Dave Page wrote: > >> Hi >> >> On Tue, Mar 12, 2019 at 7:00 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> At

Re: [pgAdmin4][RM4017] Query Tool History persistence

2019-03-12 Thread Aditya Toshniwal
Hi Dave, On Tue, Mar 12, 2019 at 4:02 PM Dave Page wrote: > Hi > > On Tue, Mar 12, 2019 at 7:00 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to make query history persistent. The number of >> records to persist is configurable usi

Re: [pgAdmin4][RM4017] Query Tool History persistence

2019-03-12 Thread Dave Page
Hi On Tue, Mar 12, 2019 at 7:00 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to make query history persistent. The number of > records to persist is configurable using MAX_QUERY_HIST_STORED (config.py) > which is per user/server/database

[pgAdmin4][RM4017] Query Tool History persistence

2019-03-12 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to make query history persistent. The number of records to persist is configurable using MAX_QUERY_HIST_STORED (config.py) which is per user/server/database based (currently set to 20). Records will be stored in the sqlite3 db. Test cases are included. Kindly rev