Hello Akshay,
Thanks for double checking the patch, clearly the things that we missing
are asking for some tests to ensure that mistakes like this do not happen
again. Specially in scenarios where the we have strange behaviors, like
loosing connection to the python server and so on.
Thanks
Joao
Thanks, applied. All tests pass on my machine, now waiting for Jenkins to
run. Assuming all is good, I'll build the release packages.
On Wed, Mar 21, 2018 at 7:27 AM, Akshay Joshi wrote:
> Hi Victoria,
>
> In "is_new_transaction_required.js" file I have modified the code and
> handled both "re
Hi Victoria,
In "is_new_transaction_required.js" file I have modified the code and
handled both "responseJSON" and "axios" responses, but in your patch you
have removed "responseJSON" part which is required because "i
*s_new_transaction_required*()" function is also called from sqleditor.js
with n
Hi Hackers,
We fixed the tests and refactored some of the code. All tests pass now.
Attached is the reviewed patch.
Sincerely,
Joao and Victoria
On Tue, Mar 20, 2018 at 10:05 AM, Dave Page
wrote:
> Hi
>
> This doesn't pass the Javascript tests for me. Please investigate ASAP:
>
> webpack: Co
Hi
This doesn't pass the Javascript tests for me. Please investigate ASAP:
webpack: Compiled successfully.
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 152 of 486 SUCCESS (0
secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 153 of 486 SUCCESS (0
secs / 0 secs)
HeadlessChrome 0
Thanks for doing this, sorry about the breakage.
We're taking a look at this to make sure it is still working with
Greenplum.
-- Rob
On Tue, Mar 20, 2018 at 9:12 AM, Akshay Joshi wrote:
> Hi Hackers
>
> Attached is the patch file to fix the RM #2815.
>
> On Tue, Mar 20, 2018 at 3:24 PM, Dave P
Hi Hackers
Attached is the patch file to fix the RM #2815.
On Tue, Mar 20, 2018 at 3:24 PM, Dave Page
wrote:
>
>
> On Tue, Mar 20, 2018 at 9:48 AM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>>
>>
>> On Tue, Mar 20, 2018 at 3:06 PM, Dave Page
>> wrote:
>>
>>> I'm a little concern
On Tue, Mar 20, 2018 at 9:48 AM, Akshay Joshi wrote:
>
>
> On Tue, Mar 20, 2018 at 3:06 PM, Dave Page
> wrote:
>
>> I'm a little concerned that noone mentioned this earlier; I'm supposed to
>> be building the release this afternoon, and I expect this change to at the
>> very least be complex to
On Tue, Mar 20, 2018 at 3:06 PM, Dave Page
wrote:
> I'm a little concerned that noone mentioned this earlier; I'm supposed to
> be building the release this afternoon, and I expect this change to at the
> very least be complex to fully test and verify. What's the ETA on the
> patch? What steps ar
I'm a little concerned that noone mentioned this earlier; I'm supposed to
be building the release this afternoon, and I expect this change to at the
very least be complex to fully test and verify. What's the ETA on the
patch? What steps are being taken to ensure it's correct and doesn't cause
regre
Hi Joao
It seems that this fix broke the functionality of RM #2815. It is mentioned
in the RM what needs to be fixed now and I am currently working on it.
While fixing the issue following problem that I found
- In "start_running_query.py" file, we need to remove check "if
conn.connected()"
Thanks, applied.
On Fri, Feb 9, 2018 at 2:35 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hello,
> Attached you can find the fix for the current pronlem
>
>
> On Fri, Feb 9, 2018 at 7:29 AM Dave Page wrote:
>
>> Hi Joao,
>>
>> It looks like Jenkins has taken umbrage to th
Hello,
Attached you can find the fix for the current pronlem
On Fri, Feb 9, 2018 at 7:29 AM Dave Page wrote:
> Hi Joao,
>
> It looks like Jenkins has taken umbrage to this change, at least with
> Python 3.x. Can you take a look please?
>
> https://jenkins.pgadmin.org/
>
> Thanks.
>
> On Fri, Fe
Hi Joao,
It looks like Jenkins has taken umbrage to this change, at least with
Python 3.x. Can you take a look please?
https://jenkins.pgadmin.org/
Thanks.
On Fri, Feb 9, 2018 at 11:54 AM, Dave Page wrote:
> Thanks, patches applied.
>
> On Fri, Feb 2, 2018 at 10:50 PM, Joao De Almeida Pereira
Thanks, patches applied.
On Fri, Feb 2, 2018 at 10:50 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hi Hackers,
> This is quite a big patch in order to solve the problem with the Explain
> Plan.
>
> We sent 2 patches that have the following:
> *- update-javascript-packages.
It’s in my queue, but I’ve been traveling. I hope to get to it later today or
tomorrow.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise PostgreSQL Company
> On 7 Feb 2018, at 22:32, Joao De Almeida Pereira
> wrote:
>
Hello,
Any Feedback on this Patch?
We have other changes that we already developed that depend on this change.
Thanks
On Tue, Feb 6, 2018 at 9:33 AM Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hello,
> Any feedback on this Patch?
>
> Thanks
> Joao
>
> On Fri, Feb 2, 2018 at
Hello,
Any feedback on this Patch?
Thanks
Joao
On Fri, Feb 2, 2018 at 5:50 PM Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hi Hackers,
> This is quite a big patch in order to solve the problem with the Explain
> Plan.
>
> We sent 2 patches that have the following:
> *- update
18 matches
Mail list logo