Re: [pgadmin][patch] Make Feature and Unit tests Green Again

2018-01-26 Thread Dave Page
Thanks - patch applied! On Fri, Jan 26, 2018 at 3:54 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello, > We changed the name in the JSON and extracted the validation to a function > to make the code more readable. > > Thanks > Joao > > On Fri, Jan 26, 2018 at 5:47 AM Dav

Re: [pgadmin][patch] Make Feature and Unit tests Green Again

2018-01-26 Thread Joao De Almeida Pereira
Hello, We changed the name in the JSON and extracted the validation to a function to make the code more readable. Thanks Joao On Fri, Jan 26, 2018 at 5:47 AM Dave Page wrote: > Hi > > On Thu, Jan 25, 2018 at 7:10 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Hacke

Re: [pgadmin][patch] Make Feature and Unit tests Green Again

2018-01-26 Thread Dave Page
Hi On Thu, Jan 25, 2018 at 7:10 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > Attached you can find a diff with the correction of Bug 3057. > With the latest changes to display some information in GP some Feature > Tests stopped working when run against a GP

[pgadmin][patch] Make Feature and Unit tests Green Again

2018-01-25 Thread Joao De Almeida Pereira
Hi Hackers, Attached you can find a diff with the correction of Bug 3057. With the latest changes to display some information in GP some Feature Tests stopped working when run against a GP instance. Also we found out that the Feature Test(PGDataType) against 9.2 is failing for some time as well. S