Re: [pgadmin-hackers][patch] History Detail Pane

On Tue, Jun 27, 2017 at 8:26 PM, Dave Page wrote: > Thanks - patch applied (just in time for Raffi's & my talk)! > > The history tab looks really very good. > On Tue, Jun 27, 2017 at 10:05 AM, Joao Pedro De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Yep, >> please see attached

Re: [pgadmin-hackers][patch] History Detail Pane

Harshal, Thanks for taking a look. That exact feature should be in our next patch along with a few style changes. -- Rob On Tue, Jun 27, 2017 at 2:03 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > New history pane is really nice and informative than existing one. > I'm j

Re: [pgadmin-hackers][patch] History Detail Pane

Hi, New history pane is really nice and informative than existing one. I'm just thinking about one minor improvement we can make, to allow history tab to respond to up and down arrow keys so that user can easily switch between executed queries without using mouse. Thanks, -- *Harshal Dhumal* *

Re: [pgadmin-hackers][patch] History Detail Pane

Thanks - patch applied (just in time for Raffi's & my talk)! On Tue, Jun 27, 2017 at 10:05 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Yep, > please see attached > > On Tue, Jun 27, 2017 at 9:11 AM, Dave Page wrote: > >> Can you rebase this patch please? >> >> Than

Re: [pgadmin-hackers][patch] History Detail Pane

Can you rebase this patch please? Thankfully I think we're basically at the end of our changes in this area! On Mon, Jun 26, 2017 at 10:08 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Surinder, > > You can find our answers inline and attached the patch with the c

Re: [pgadmin-hackers][patch] History Detail Pane

On Mon, Jun 26, 2017 at 10:08 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Surinder, > > You can find our answers inline and attached the patch with the change of > scrolls from "scroll" to "auto" > > On Mon, Jun 26, 2017 at 4:47 AM, Surinder Kumar > wrote: >> >> H

Re: [pgadmin-hackers][patch] History Detail Pane

Hi On Fri, Jun 23, 2017 at 11:39 PM, George Gelashvili wrote: > On Fri, Jun 23, 2017 at 11:24 AM, Surinder Kumar sedb.com> wrote: > >> Hi >> >> Review comments: >> >> ​1. ​ >> Can we set "message"(in message detail) style property scroll to >> ​'​ >> auto >> ​'​ >> instead of >> ​'​ >> scroll >

Re: [pgadmin-hackers][patch] History Detail Pane

On Fri, Jun 23, 2017 at 11:24 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > Review comments: > > ​1. ​ > Can we set "message"(in message detail) style property scroll to > ​'​ > auto > ​'​ > instead of > ​'​ > scroll > ​'​ > ? > > ​2. ​ > CSS property flex is supported for

Re: [pgadmin-hackers][patch] History Detail Pane

Hi Review comments: ​1. ​ Can we set "message"(in message detail) style property scroll to ​'​ auto ​'​ instead of ​'​ scroll ​'​ ? ​2. ​ CSS property flex is supported for IE >= 9 as per reference

Re: [pgadmin-hackers][patch] History Detail Pane

Hi Looking good. The only issue I found so far occurs if you open the query tool, then immediately click on the history tab: TypeError: Cannot read property 'CodeMirror' of undefined at Object. (sqleditor.js:882) at triggerEvents (backbone.js:208) at Object.trigger (backbone.js:148)