Re: Build failed in Jenkins: pgadmin4-master-python34 #440

2018-01-22 Thread Ashesh Vashi
On Mon, Jan 22, 2018 at 4:32 PM, Dave Page wrote: > On Mon, Jan 22, 2018 at 10:59 AM, Ashesh Vashi > wrote: > > Dave, > > > > We need to make habit of running the following command before committing > any > > javascript files. > >> > >> yarn run linter > > We do - it's called when creating the b

Re: Build failed in Jenkins: pgadmin4-master-python34 #440

2018-01-22 Thread Ashesh Vashi
sed various issues. Can you take a >> look ASAP please? >> >> Thanks. >> >> >> -- Forwarded message ------ >> From: pgAdmin 4 Jenkins >> Date: Mon, Jan 22, 2018 at 10:53 AM >> Subject: Build failed in Jenkins: pgadmin4-master-python34 #440 >>

Re: Build failed in Jenkins: pgadmin4-master-python34 #440

2018-01-22 Thread Dave Page
On Mon, Jan 22, 2018 at 10:59 AM, Ashesh Vashi wrote: > Dave, > > We need to make habit of running the following command before committing any > javascript files. >> >> yarn run linter We do - it's called when creating the bundle, which I always do when testing. This newer version of ESLint seem

Re: Build failed in Jenkins: pgadmin4-master-python34 #440

2018-01-22 Thread Ashesh Vashi
> look ASAP please? > > Thanks. > > > -- Forwarded message -- > From: pgAdmin 4 Jenkins > Date: Mon, Jan 22, 2018 at 10:53 AM > Subject: Build failed in Jenkins: pgadmin4-master-python34 #440 > To: pgadmin-hack...@postgresql.org, dp...@pgadmin.org

Re: Build failed in Jenkins: pgadmin4-master-python34 #440

2018-01-22 Thread Surinder Kumar
in 4 Jenkins > Date: Mon, Jan 22, 2018 at 10:53 AM > Subject: Build failed in Jenkins: pgadmin4-master-python34 #440 > To: pgadmin-hack...@postgresql.org, dp...@pgadmin.org > > > See <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ > 440/display/redirect?pa

Fwd: Build failed in Jenkins: pgadmin4-master-python34 #440

2018-01-22 Thread Dave Page
Hi Surinder, It seems that updating ESLint exposed various issues. Can you take a look ASAP please? Thanks. -- Forwarded message -- From: pgAdmin 4 Jenkins Date: Mon, Jan 22, 2018 at 10:53 AM Subject: Build failed in Jenkins: pgadmin4-master-python34 #440 To: pgadmin-hack

Build failed in Jenkins: pgadmin4-master-python34 #440

2018-01-22 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Update ESLint requirement to support --fix-dry-run [Dave Page] Ensure clickable images/buttons have appropriate tooltips for screen -- [