Re: pgAdmin4 - Tree view icons for final reveiw

2017-09-11 Thread Chethana Kumar
it is acceptable only if we are able to edit the icons through css otherwise we will have to have 3 sets of icons and it is nor recommended. So I am trying do a quick RnD on it so please hold on will come up with a solution. Thanks, Chethana kumar On Mon, Sep 11, 2017 at 3:54 PM, Murtuza Zabuawa

Re: pgAdmin4 - Tree view icons for final reveiw

2017-09-11 Thread Murtuza Zabuawala
Hi Chethana, On Mon, Sep 11, 2017 at 3:04 PM, Chethana Kumar < chethana.ku...@enterprisedb.com> wrote: > > > On Mon, Sep 11, 2017 at 1:15 PM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hello, >> >> I also observed few issues, >> >> 1) In my opinion, New icons looks dull

Re: pgAdmin4 - Tree view icons for final reveiw

2017-09-11 Thread Chethana Kumar
On Mon, Sep 11, 2017 at 1:15 PM, Murtuza Zabuawala wrote: > Hello, > > I also observed few issues, > > 1) In my opinion, New icons looks dull in main header menu due to dark > background, attaching screenshot for your reference. > Icons for the dialog boxes area will go in white. > > 2) Spacin

Re: pgAdmin4 - Tree view icons for final reveiw

2017-09-11 Thread Dave Page
On Mon, Sep 11, 2017 at 9:19 AM, Ashesh Vashi wrote: > On Mon, Sep 11, 2017 at 1:46 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find the attached patch for not showing icons for menu items. >> I have not completely removed it, but - commented the code (wi

Re: pgAdmin4 - Tree view icons for final reveiw

2017-09-11 Thread Ashesh Vashi
On Mon, Sep 11, 2017 at 1:46 PM, Ashesh Vashi wrote: > Hi Dave, > > Please find the attached patch for not showing icons for menu items. > I have not completely removed it, but - commented the code (will remove it > in final patch). > We will need to remove the icons from the individual modules l

Re: pgAdmin4 - Tree view icons for final reveiw

2017-09-11 Thread Ashesh Vashi
Hi Dave, Please find the attached patch for not showing icons for menu items. I have not completely removed it, but - commented the code (will remove it in final patch). Please review, and commit it (if it looks good to you). -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise Pos

Re: pgAdmin4 - Tree view icons for final reveiw

2017-09-11 Thread Dave Page
On Mon, Sep 11, 2017 at 8:59 AM, Ashesh Vashi wrote: > On Mon, Sep 11, 2017 at 1:25 PM, Dave Page wrote: > >> Hmm, scrub the revert - it looks like you just fixed a bunch of the >> issues. >> > K. > >> >> The main thing I think that remains as an issue is the colouring on the >> headers and menu

Re: pgAdmin4 - Tree view icons for final reveiw

2017-09-11 Thread Ashesh Vashi
On Mon, Sep 11, 2017 at 1:25 PM, Dave Page wrote: > Hmm, scrub the revert - it looks like you just fixed a bunch of the issues. > K. > > The main thing I think that remains as an issue is the colouring on the > headers and menus - the former of which needs fixing somehow, the latter we > were go

Re: pgAdmin4 - Tree view icons for final reveiw

2017-09-11 Thread Dave Page
Hmm, scrub the revert - it looks like you just fixed a bunch of the issues. The main thing I think that remains as an issue is the colouring on the headers and menus - the former of which needs fixing somehow, the latter we were going to remove to de-clutter the UI anyway. On Mon, Sep 11, 2017 at

Re: pgAdmin4 - Tree view icons for final reveiw

2017-09-11 Thread Dave Page
Agreed - these issues need to be resolved before we can proceed. Ashesh, please revert the patch for now. Chethana, please figure out what we need to change to resolve the various issues raised. Iirc, we'd already decided to remove icons from the menus right? On Mon, Sep 11, 2017 at 8:45 AM, Mur

Re: pgAdmin4 - Tree view icons for final reveiw

2017-08-25 Thread Dave Page
Hi Yes, that's my expectation. Hopefully they'll go in in the next week or so. On Fri, Aug 25, 2017 at 12:40 PM, Anthony DeBarros wrote: > Dave and all, > > Out of curiosity (because I’m writing a book that includes pgAdmin screen > grabs), do you expect these icons to make it into your Septemb

Re: pgAdmin4 - Tree view icons for final reveiw

2017-08-25 Thread Anthony DeBarros
Dave and all, Out of curiosity (because I’m writing a book that includes pgAdmin screen grabs), do you expect these icons to make it into your September release? Thanks, Anthony On August 23, 2017 at 4:03:42 AM, Murtuza Zabuawala ( murtuza.zabuaw...@enterprisedb.com) wrote: Hi Chethana, On W

Re: pgAdmin4 - Tree view icons for final reveiw

2017-08-23 Thread Murtuza Zabuawala
Hi Chethana, On Wed, Aug 23, 2017 at 12:51 PM, Chethana Kumar < chethana.ku...@enterprisedb.com> wrote: > Hi Murtuza, > > Please see my reply inline along with the updated .svg file for tree view > icons. > > > On Tue, Aug 22, 2017 at 11:17 AM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprised

Re: pgAdmin4 - Tree view icons for final reveiw

2017-08-23 Thread Chethana Kumar
Hi Murtuza, Please see my reply inline along with the updated .svg file for tree view icons. On Tue, Aug 22, 2017 at 11:17 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Chethana, > > - The icons for Server node is missing, we will need given set of icons > for server.

Re: pgAdmin4 - Tree view icons for final reveiw

2017-08-22 Thread Chethana Kumar
Hi Surinder, The dimensions remain same as 16x16, there is no change in it. The .svg file which I sent earlier was not the one you use it for your development, it was just to showcase the all icons in a single view. Regards, Chethana kumar On Tue, Aug 22, 2017 at 11:53 AM, Surinder Kumar < sur

Re: pgAdmin4 - Tree view icons for final reveiw

2017-08-21 Thread Surinder Kumar
Hi Chethana, The icons dimensions seem to vary in attached SVG. I have attached screenshot. Ideally, the icon(s) must fit(take full width/height) in the dimensions either it is 16x16 or 14x14. because we will not adjust the pixels for each icon. Can you please tell what are the dimensions for an

Re: pgAdmin4 - Tree view icons for final reveiw

2017-08-21 Thread Murtuza Zabuawala
Hi Chethana, - The icons for Server node is missing, we will need given set of icons for server. 1) Basic Server icon (Disconnect state) 2) PG (Connected state) 3) EPAS (Connected state) 4) GreenPlum (Connected state) [Attaching current icons for PG & EPAS, I'm not sure about GreenPlum server icon

Re: pgAdmin4 - Tree view icons for final reveiw

2017-08-21 Thread Chethana Kumar
Yes Shirley, I have already thought through on it. Basically, we need to have one more set of icons in white color mode so that we can use it on dialog headers as well. As the blue theme icons won't fit there. Please share your thoughts. Regards, Chethana kumar On Tue, Aug 22, 2017 at 4:32 AM, S

Re: pgAdmin4 - Tree view icons for final reveiw

2017-08-21 Thread Shirley Wang
Hi Chethana, I just thought of something with these icons. What happens with the ones that appear in dialog headers? In the blue bar? On Mon, Aug 21, 2017 at 8:31 AM Chethana Kumar < chethana.ku...@enterprisedb.com> wrote: > Hello Team, > > I have applied labels for each icon for identification