pgAdmin 4 commit: Added informative message when there is no difference

2021-01-15 Thread Akshay Joshi
Added informative message when there is no difference found for schema diff. Fixes #6122 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=065bda37b4ff5e3908de557cd713c9b0a491c62d Author: Nikhil Mohite Modified Files -- docs/en_US/

Re: [pgAdmin][RM-6122]: There is no informative message when there is no diff found

2021-01-15 Thread Akshay Joshi
Thanks, patch applied. On Fri, Jan 15, 2021 at 11:44 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > Please find the attached patch for RM-6122 > : There is no informative > message when there is no diff found. > > -- > *Thanks

Re: Quick search for menu items & help articles

2021-01-15 Thread Dave Page
Hi On Fri, Jan 15, 2021 at 7:23 AM Pramod Ahire wrote: > Hi Dave, > > > > Thank you for comments ! I had described points below. Please do let me > know if anything missing. > > > > *From: *Dave Page > *Date: *Thursday, 14 January 2021 at 10:26 PM > *To: *Pramod Ahire > *Cc: *pgadmin-hackers

Re: Quick search for menu items & help articles

2021-01-15 Thread Akshay Joshi
Hi Dave On Fri, Jan 15, 2021 at 2:46 PM Dave Page wrote: > Hi > > On Fri, Jan 15, 2021 at 7:23 AM Pramod Ahire < > pramod.ah...@enterprisedb.com> wrote: > >> Hi Dave, >> >> >> >> Thank you for comments ! I had described points below. Please do let me >> know if anything missing. >> >> >> >> *Fro

Re: Quick search for menu items & help articles

2021-01-15 Thread Dave Page
On Fri, Jan 15, 2021 at 9:43 AM Akshay Joshi wrote: > Hi Dave > > On Fri, Jan 15, 2021 at 2:46 PM Dave Page wrote: > >> Hi >> >> On Fri, Jan 15, 2021 at 7:23 AM Pramod Ahire < >> pramod.ah...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> >>> >>> Thank you for comments ! I had described points

Re: Quick search for menu items & help articles

2021-01-15 Thread Akshay Joshi
On Fri, Jan 15, 2021 at 3:15 PM Dave Page wrote: > > > On Fri, Jan 15, 2021 at 9:43 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> On Fri, Jan 15, 2021 at 2:46 PM Dave Page wrote: >> >>> Hi >>> >>> On Fri, Jan 15, 2021 at 7:23 AM Pramod Ahire < >>> pramod.ah...@ente

Re: [pgAdmin4][Patch] - RM 5457 - Kerberos Authentication - Phase 1

2021-01-15 Thread Dave Page
And another thought... Some of the Jenkins QA jobs setup the virtual environment for running tests themselves. I believe these might actually be the cause of some of the failures we saw initially with the commit - I'll review those, and ensure they won't try to build the gssapi module from source