Re: [pgAdmin][RM5912]: Added support for Logical Replication.

2021-01-16 Thread Akshay Joshi
Hi Pradip Following are the GUI related review comments: *Publication:* 1. The truncate option is not visible for PG 10 but the SQL query showing it. 2. "All table?" should be "All tables?" and "Table" should be renamed to "Tables". 3. "-- Publication : test; -- DROP PUBLICATIO

pgAdmin 4 commit: Added ERD Diagram support with basic table fields, pr

2021-01-16 Thread Akshay Joshi
Added ERD Diagram support with basic table fields, primary key, foreign key, and DDL SQL generation. Fixes #1802 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0c8226ff39b7ae8dcbe6fd141730ad7b9e4cbb3b Author: Aditya Toshniwal Modified Files

Re: [pgAdmin][RM1802] ERD Tool (Beta)

2021-01-16 Thread Akshay Joshi
Thanks, patch applied. On Fri, Jan 15, 2021 at 7:01 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > I've fixed the issues. You can find the comments inline. > I've also added PropTypes for the components for increased validation. > > On Tue, Jan 12, 2021 at 12:18 PM Khus