Re: [pgadmin-hackers] Schema bug

2005-12-12 Thread Guillaume LELARGE
Le Mardi 13 Décembre 2005 05:58, Andreas Pflug a écrit : > Jim C. Nasby wrote: > > On Tue, Dec 13, 2005 at 12:48:55AM +0100, Guillaume LELARGE wrote: > >>Well, it seems that pg_* schemas are system schemas and that public and > >>information_schema schemas are public one. I think we should exclude

Re: [pgadmin-hackers] Schema bug

2005-12-12 Thread Andreas Pflug
Jim C. Nasby wrote: On Tue, Dec 13, 2005 at 12:48:55AM +0100, Guillaume LELARGE wrote: Well, it seems that pg_* schemas are system schemas and that public and information_schema schemas are public one. I think we should exclude system schemas depending on their names and show public and inform

Re: [pgadmin-hackers] Schema bug

2005-12-12 Thread Jim C. Nasby
On Tue, Dec 13, 2005 at 12:48:55AM +0100, Guillaume LELARGE wrote: > Well, it seems that pg_* schemas are system schemas and that public and > information_schema schemas are public one. I think we should exclude system > schemas depending on their names and show public and information_schema, >

Re: [pgadmin-hackers] Schema bug

2005-12-12 Thread Guillaume LELARGE
Le Samedi 10 Décembre 2005 16:55, Andreas Pflug a écrit : > Dave Page wrote: > >>I still think this patch should be applied. > > > > Does anyone see a reason /not/ to do this? > > Hm, Guillaume started a thread on pgsql-hackers about renaming system > schemas in general, maybe we should wait for th

Re: [pgadmin-hackers] Schema bug

2005-12-12 Thread Jim C. Nasby
FWIW, here's what we ended up going with in newsysviews: create or replace function _pg_sv_system_schema(name) returns boolean as 'select $1 in (name ''pg_catalog'', name ''pg_toast'', name ''pg_sysviews'', name ''information_schema'')' language sql immutable strict; This

Re: [pgadmin-hackers] Schema bug

2005-12-12 Thread Florian G. Pflug
Andreas Pflug wrote: > Florian G. Pflug wrote: >> I'd prefer system-catalogs being excluded by name - preferably the >> exclusion-list would be editable, and part of the pgadmin preferences. >> Seems more transparent to me - and future-proof, in the sense that >> even if a future postgres version

Re: [pgadmin-hackers] Schema bug

2005-12-12 Thread Andreas Pflug
Florian G. Pflug wrote: I'd prefer system-catalogs being excluded by name - preferably the exclusion-list would be editable, and part of the pgadmin preferences. Seems more transparent to me - and future-proof, in the sense that even if a future postgres version chooses to rename some catalog

Re: [pgadmin-hackers] Schema bug

2005-12-12 Thread Florian G. Pflug
Dave Page wrote: I had two ways to fix this bug : detect system schemas on their names, or detect public schema by its OID. I think it's better to only keep the public schema with its OID, it's much less risky to have a wrong one. That's what the patch is doing : AND nspname != 'public' is

[pgadmin-hackers] SVN Commit by andreas: r4841 - branches/REL-1_4_0_PATCHES/pgadmin3/src/slony

2005-12-12 Thread svn
Author: andreas Date: 2005-12-12 11:37:05 + (Mon, 12 Dec 2005) New Revision: 4841 Modified: branches/REL-1_4_0_PATCHES/pgadmin3/src/slony/slNode.cpp Log: fix slony node statistics Modified: branches/REL-1_4_0_PATCHES/pgadmin3/src/slony/slNode.cpp ===

[pgadmin-hackers] SVN Commit by andreas: r4840 - in trunk/pgadmin3: . src/slony

2005-12-12 Thread svn
Author: andreas Date: 2005-12-12 11:36:44 + (Mon, 12 Dec 2005) New Revision: 4840 Modified: trunk/pgadmin3/CHANGELOG.txt trunk/pgadmin3/src/slony/slNode.cpp Log: fix slony node statistics Modified: trunk/pgadmin3/CHANGELOG.txt