Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid

2008-02-06 Thread Robins Tharakan
Hi, The attached patch does this: 1. Sanitize the if-else bracket style for the earlier patch. 2. Use 'IS DISTINCT FROM' instead of <> in an exclusion condition. Two issues remain that I can't resolve: 1. Rightly as you point out thread->IsRunning() needs to be called only if it exists. On rigoro

Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid

2008-02-06 Thread Dave Page
On Feb 6, 2008 11:02 AM, Robins Tharakan <[EMAIL PROTECTED]> wrote: > > ... snip ... > Sure ! Points that I'll take into account from now on. > > > > One other thing I noticed that should be fixed in a new patch - if you > > sort ascending on a column, and then sort descending, it will add > > bot

Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid

2008-02-06 Thread Robins Tharakan
> ... snip ... Sure ! Points that I'll take into account from now on. > One other thing I noticed that should be fixed in a new patch - if you > sort ascending on a column, and then sort descending, it will add > both. It should remove the ascending and replace it with the > descending sort. True

Re: [pgadmin-hackers] Fwd: Filter by Selection on Grid

2008-02-06 Thread Dave Page
On Feb 5, 2008 5:57 PM, Robins Tharakan <[EMAIL PROTECTED]> wrote: > Sure, I'll try and keep separate patches in separate emails. > Attached is reworked patch which takes care of the issues that you > mentioned. > > Updates in this patch: > 1. Removed the extra separator that came up on right-clic

[pgadmin-hackers] SVN Commit by dpage: r7060 - trunk/pgadmin3/pgadmin/frm

2008-02-06 Thread svn
Author: dpage Date: 2008-02-06 10:27:22 + (Wed, 06 Feb 2008) New Revision: 7060 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7060&view=rev Log: Quote identifier/values in sort/filter options Modified: trunk/pgadmin3/pgadmin/frm/frmEditGrid.cpp

Re: [pgadmin-hackers] A new feature patch and a bug fix

2008-02-06 Thread Dave Page
On Feb 6, 2008 9:55 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > > The password dialogue is the frmPassword.xrc file, right ? I don't see > the difference between it and my xrc file. It's a fixed size dialog, > style is the same. All widgets have a specific position, only entry one > have a s

[pgadmin-hackers] SVN Commit by dpage: r7059 - in trunk/pgadmin3: . pgadmin/dlg pgadmin/frm pgadmin/include/frm

2008-02-06 Thread svn
Author: dpage Date: 2008-02-06 10:07:56 + (Wed, 06 Feb 2008) New Revision: 7059 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7059&view=rev Log: Add options to the Edit Grid to allow sorting and filtering based on the selected cell [Robins Tharakan] Modified: trunk

Re: [pgadmin-hackers] A new feature patch and a bug fix

2008-02-06 Thread Guillaume Lelarge
Dave Page wrote: On Feb 5, 2008 4:43 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: Dave Page wrote: On Feb 5, 2008 9:46 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: [...] I'm not sure I get this right. It took me much more time than the four previous stuff. XRCed is not really easy gett

Re: [pgadmin-hackers] How do you manage versions of your own code ?

2008-02-06 Thread Magnus Hagander
On Wed, Feb 06, 2008 at 09:04:46AM +0530, Robins Tharakan wrote: > Hi all, > > After going a bit of back and forth on different versions that I am working > on I think I might as well ask how do you guys work on an open-source > development project once you are disconnected ? > > I mean, if I do

Re: [pgadmin-hackers] How do you manage versions of your own code ?

2008-02-06 Thread Heikki Linnakangas
Robins Tharakan wrote: After going a bit of back and forth on different versions that I am working on I think I might as well ask how do you guys work on an open-source development project once you are disconnected ? I mean, if I do a svn co and start working, it wouldnt allow me to check in a v

Re: [pgadmin-hackers] How do you manage versions of your own code ?

2008-02-06 Thread Kalle Hallivuori
Hi, 2008/2/6, Robins Tharakan <[EMAIL PROTECTED]>: > After going a bit of back and forth on different versions that I am working > on I think I might as well ask how do you guys work on an open-source > development project once you are disconnected ? We use Mercurial ( http://www.selenic.com/merc

Re: [pgadmin-hackers] How do you manage versions of your own code ?

2008-02-06 Thread Guillaume Lelarge
Dave Page wrote: On Feb 6, 2008 3:34 AM, Robins Tharakan <[EMAIL PROTECTED]> wrote: Hi all, After going a bit of back and forth on different versions that I am working on I think I might as well ask how do you guys work on an open-source development project once you are disconnected ? I mean,

Re: [pgadmin-hackers] How do you manage versions of your own code ?

2008-02-06 Thread Dave Page
On Feb 6, 2008 3:34 AM, Robins Tharakan <[EMAIL PROTECTED]> wrote: > Hi all, > > After going a bit of back and forth on different versions that I am working > on I think I might as well ask how do you guys work on an open-source > development project once you are disconnected ? > > I mean, if I do