Re: [pgadmin-hackers] Dialogs review

2008-07-09 Thread Guillaume Lelarge
Guillaume Lelarge a écrit : [...] I tend to prefer the "one patch for each dialog" approach, but I would like to know your thoughts on this. Here is the first one, dlgAggregate.xrc. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com Index: pgadmin/ui/dlgAggregate.xrc ===

Re: [pgadmin-hackers] patch to fix pgadmin1.8.4 build on Solaris 10.

2008-07-09 Thread Mayuresh Nirhali
Hello, OpenSolaris has IPADDR_NONE defined in netinet/in.h. but Solaris 10 does not. I believe the previous builds for pgAdmin 1.8.4 for were only done for OpenSolaris. Could you please confirm, zdenek ? Mayuresh Dave Page wrote: On Wed, Jul 9, 2008 at 12:42 PM, Mayuresh Nirhali <[EMAIL PRO

Re: [pgadmin-hackers] patch to fix pgadmin1.8.4 build on Solaris 10.

2008-07-09 Thread Dave Page
On Wed, Jul 9, 2008 at 12:42 PM, Mayuresh Nirhali <[EMAIL PROTECTED]> wrote: > Hello, > > While building pgadmin 1.8.4 on Solaris 10, I encountered following error. > > "./debugger/dbgPgConn.cpp", line 97: Error: INADDR_NONE is not defined. > gmake[2]: *** [dbgPgConn.o] Error 1 > > This seems to be

[pgadmin-hackers] patch to fix pgadmin1.8.4 build on Solaris 10.

2008-07-09 Thread Mayuresh Nirhali
Hello, While building pgadmin 1.8.4 on Solaris 10, I encountered following error. "./debugger/dbgPgConn.cpp", line 97: Error: INADDR_NONE is not defined. gmake[2]: *** [dbgPgConn.o] Error 1 This seems to be a known problem with Solaris10. I prepared a patch based on how the same issue is worked

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-07-09 Thread Dave Page
On Wed, Jul 9, 2008 at 12:31 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > I think you also check on Windows. No issue found? No, I don't have Windows to hand at the moment. I'm sure it will be fine here though if it works OK for you. Windows is pretty predictable in that way :-) > I prefer

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-07-09 Thread Guillaume Lelarge
Dave Page a écrit : On Wed, Jul 9, 2008 at 9:18 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: The last patch I sent works on GTK+. When I try it on Windows, it works for dlgFunction and dlgTrigger and doesn't with all other dlg*. I tried to understand what could be wrong with dlgDatabase. dl

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-07-09 Thread Dave Page
On Wed, Jul 9, 2008 at 9:18 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > The last patch I sent works on GTK+. When I try it on Windows, it works for > dlgFunction and dlgTrigger and doesn't with all other dlg*. I tried to > understand what could be wrong with dlgDatabase. dlgFunction already

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-07-09 Thread Guillaume Lelarge
Dave Page a écrit : (apologies for not reviewing the latest patch yet - we moved offices on Monday so I've been tied up with that for the last few days) No problem, don't worry :) On Wed, Jul 9, 2008 at 12:07 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: I worked on the remaining issue

Re: [pgadmin-hackers] Enabling SQL text field in the SQL tab of object dialog

2008-07-09 Thread Dave Page
(apologies for not reviewing the latest patch yet - we moved offices on Monday so I've been tied up with that for the last few days) On Wed, Jul 9, 2008 at 12:07 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > I worked on the remaining issue tonight and it seems I can fix it this way: > I add