Re: [pgadmin-hackers] Source reindenting

2010-12-29 Thread Guillaume Lelarge
Le 29/12/2010 18:44, Dave Page a écrit : > On Wed, Dec 29, 2010 at 5:30 PM, Magnus Hagander wrote: >> I just did a testrun with astyle to reindent and restyle the code. I >> created a rule in Makefile.am per: >> >> diff --git a/Makefile.am b/Makefile.am >> index be6af45..8266f8d 100644 >> --- a/Ma

Re: [pgadmin-hackers] fix: cannot build wxWidgets if sources are located at another disk

2010-12-29 Thread Dave Page
Thanks - patch committed. On Wed, Dec 29, 2010 at 4:47 PM, Nail Samatov wrote: > Sorry, forgot to attach the patch :-) > > 2010/12/29 Nail Samatov : >> For example, configuration wxWidgets sources are here: >>  C:\libs\wxWidgets-2.8.11 >> PgAdmin sources are here: >>  T:\my\pgadmin3 >> >> when in

[pgadmin-hackers] pgAdmin III commit: Fix the build-wxmsw.bat script to work in the case

2010-12-29 Thread Dave Page
Fix the build-wxmsw.bat script to work in the case that it is on a different drive than wxWidgets. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=d5989136fe2a1ea9eb3ad80944cf1f45d6a4301a Author: Nail Samatov Modified Files -- xtra

Fwd: [pgadmin-hackers] Email notification pgAgent

2010-12-29 Thread Jasmin Dizdarevic
-- Forwarded message -- From: Jasmin Dizdarevic Date: 2010/12/29 Subject: Re: [pgadmin-hackers] Email notification pgAgent To: Dave Page Hi, * * *I'm not so keen on that - it could require some funky code to ensure* *that the user uses sequential (or at least, non-duplicate) num

Re: [pgadmin-hackers] Keywords files

2010-12-29 Thread Dave Page
On Wed, Dec 29, 2010 at 4:40 PM, Magnus Hagander wrote: > On Wed, Dec 29, 2010 at 14:55, Dave Page wrote: >> On Wed, Dec 29, 2010 at 11:54 AM, Magnus Hagander >> wrote: >>> We haven't updated the keywords.cpp file for ages. In fact, so long >>> ago that the instructions are incorrect. >>> >>> R

Re: [pgadmin-hackers] Email notification pgAgent

2010-12-29 Thread Dave Page
Hi On Wed, Dec 29, 2010 at 6:55 PM, Jasmin Dizdarevic wrote: > Hi, > I've made the necessary changes to pgAdmin, but how do we handle schema > version conflicts? > pgAdmin's job UI now will not work with pgAgent schema version 3, because of > the changes in pgagent.pga_job table. I think we have

Re: [pgadmin-hackers] Email notification pgAgent

2010-12-29 Thread Jasmin Dizdarevic
Hi, I've made the necessary changes to pgAdmin, but how do we handle schema version conflicts? pgAdmin's job UI now will not work with pgAgent schema version 3, because of the changes in pgagent.pga_job table. I think we have two possibilities: 1. Disable editing Jobs in pgAdmin until a schema up

Re: [pgadmin-hackers] Source reindenting

2010-12-29 Thread Dave Page
On Wed, Dec 29, 2010 at 6:16 PM, Magnus Hagander wrote: > On Wed, Dec 29, 2010 at 18:44, Dave Page wrote: >> On Wed, Dec 29, 2010 at 5:30 PM, Magnus Hagander wrote: >>> I just did a testrun with astyle to reindent and restyle the code. I >>> created a rule in Makefile.am per: >>> >>> diff --git

Re: [pgadmin-hackers] Source reindenting

2010-12-29 Thread Magnus Hagander
On Wed, Dec 29, 2010 at 18:44, Dave Page wrote: > On Wed, Dec 29, 2010 at 5:30 PM, Magnus Hagander wrote: >> I just did a testrun with astyle to reindent and restyle the code. I >> created a rule in Makefile.am per: >> >> diff --git a/Makefile.am b/Makefile.am >> index be6af45..8266f8d 100644 >>

Re: [pgadmin-hackers] Source reindenting

2010-12-29 Thread Dave Page
On Wed, Dec 29, 2010 at 5:30 PM, Magnus Hagander wrote: > I just did a testrun with astyle to reindent and restyle the code. I > created a rule in Makefile.am per: > > diff --git a/Makefile.am b/Makefile.am > index be6af45..8266f8d 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -65,3 +65,13 @

[pgadmin-hackers] Source reindenting

2010-12-29 Thread Magnus Hagander
I just did a testrun with astyle to reindent and restyle the code. I created a rule in Makefile.am per: diff --git a/Makefile.am b/Makefile.am index be6af45..8266f8d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -65,3 +65,13 @@ endif # We need to ensure the help cache is world writeable install-

Re: [pgadmin-hackers] fix: cannot build wxWidgets if sources are located at another disk

2010-12-29 Thread Nail Samatov
Sorry, forgot to attach the patch :-) 2010/12/29 Nail Samatov : > For example, configuration wxWidgets sources are here: >  C:\libs\wxWidgets-2.8.11 > PgAdmin sources are here: >  T:\my\pgadmin3 > > when in console I go to the "T:\my\pgadmin3\xtra\wx-build\" directory > and run "build-wxmsw.bat",

[pgadmin-hackers] fix: cannot build wxWidgets if sources are located at another disk

2010-12-29 Thread Nail Samatov
For example, configuration wxWidgets sources are here: C:\libs\wxWidgets-2.8.11 PgAdmin sources are here: T:\my\pgadmin3 when in console I go to the "T:\my\pgadmin3\xtra\wx-build\" directory and run "build-wxmsw.bat", build fails. This patch fixes this. -- Sent via pgadmin-hackers mailing li

Re: [pgadmin-hackers] Keywords files

2010-12-29 Thread Magnus Hagander
On Wed, Dec 29, 2010 at 14:55, Dave Page wrote: > On Wed, Dec 29, 2010 at 11:54 AM, Magnus Hagander wrote: >> We haven't updated the keywords.cpp file for ages. In fact, so long >> ago that the instructions are incorrect. >> >> Recent versions of postgresql installs the list of keywords in >> kwl

Re: [pgadmin-hackers] Keywords files

2010-12-29 Thread Dave Page
On Wed, Dec 29, 2010 at 11:54 AM, Magnus Hagander wrote: > We haven't updated the keywords.cpp file for ages. In fact, so long > ago that the instructions are incorrect. > > Recent versions of postgresql installs the list of keywords in > kwlist.h. That requires PostgreSQL 8.4 or later. > > How ol

[pgadmin-hackers] Keywords files

2010-12-29 Thread Magnus Hagander
We haven't updated the keywords.cpp file for ages. In fact, so long ago that the instructions are incorrect. Recent versions of postgresql installs the list of keywords in kwlist.h. That requires PostgreSQL 8.4 or later. How old versions of the PostgreSQL *source* do we accept building against? C

Re: [pgadmin-hackers] Email notification pgAgent

2010-12-29 Thread Dave Page
Hi On Tue, Dec 28, 2010 at 1:54 AM, Jasmin Dizdarevic wrote: > Okay, I'm almost done. Actually there is a problem with building the wxSMTP > package, so it doesn't send mails yet. > If this is done, I'm going to test it on Windows and *nix. Ok. > Time to take care about some other things: > 1.

[pgadmin-hackers] pgAdmin III commit: PostgreSQL 8.5 was renamed 9.0

2010-12-29 Thread Magnus Hagander
PostgreSQL 8.5 was renamed 9.0 Fix a couple of incorrect comments Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=17598151cbdd6bc7dc29bd36eb53b1cf0e9510b6 Modified Files -- pgadmin/include/debugger/dbgConnProp.h |2 +- pgadmin/s