Re: [pgadmin-hackers] pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers

2011-01-04 Thread Ashesh Vashi
On Wed, Jan 5, 2011 at 12:37 AM, Magnus Hagander wrote: > On Tue, Jan 4, 2011 at 18:46, Ashesh Vashi > wrote: > >> Hi Magnus/Dave, >> >> This check-in has added one compilation error. >> The following line introduce an error in file '*pgadmin/db/keywords.c*' >> *#include >> #include * >> >> Beca

Re: [pgadmin-hackers] Source reindenting

2011-01-04 Thread Erwin Brandstetter
On Thursday, December 30, 2010 6:33:14 PM UTC+1, Guillaume Lelarge wrote: > Le 30/12/2010 11:24, Magnus Hagander a �crit : > > On Thu, Dec 30, 2010 at 11:13, Guillaume Lelarge > > wrote: > >> Le 30/12/2010 09:52, Magnus Hagander a �crit : (...) > >>> Do you also prefer tabs in the end, and

[pgadmin-hackers] Uncalled CREATE OR REPLACE VIEW in privileges dialog

2011-01-04 Thread Erwin Brandstetter
Hi developers! My best wishes for 2011 to the pgAdmin team! :) Testing v.1.12.2 (Dec 13 2010) on Windows XP Pro, Server PostgreSQL 8.4.5 on Debian Lenny. I found some weirdness in the privileges dialog for VIEWs. On changing any privileges via dialog, the VIEW itself gets CREATE OR REPLACEd

[pgadmin-hackers] [pgAdmin III] #296: Uncalled CREATE OR REPLACE VIEW in privileges dialog

2011-01-04 Thread pgAdmin Trac
#296: Uncalled CREATE OR REPLACE VIEW in privileges dialog -+-- Reporter: brsa | Owner: dpage Type: bug | Status: new Priority: minor| Milestone: Component: pgadmin | Version

Re: [pgadmin-hackers] pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers

2011-01-04 Thread Magnus Hagander
On Tue, Jan 4, 2011 at 18:46, Ashesh Vashi wrote: > Hi Magnus/Dave, > > This check-in has added one compilation error. > The following line introduce an error in file '*pgadmin/db/keywords.c*' > *#include > #include * > > Because - these header files does not always find under *`pg_config > --inc

Re: [pgadmin-hackers] pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers

2011-01-04 Thread Ashesh Vashi
Hi Magnus/Dave, This check-in has added one compilation error. The following line introduce an error in file '*pgadmin/db/keywords.c*' *#include #include * Because - these header files does not always find under *`pg_config --includedir`* folder, but can be found under *`pg_config --pkgincludedi

Re: [pgadmin-hackers] Step ordering pgAgent

2011-01-04 Thread Jasmin Dizdarevic
I'm with you about the ease of use, but I don't agree that triggers and jobs are so near to each other. In my opinion there is at least a functional difference: Triggers are needed on application level and are maintained by a developer. Jobs are helpers for database admins to keep the database "cle

[pgadmin-hackers] pgAdmin III commit: Fix a rendering issue in the SQL text box on Mac, w

2011-01-04 Thread Dave Page
Fix a rendering issue in the SQL text box on Mac, where resizing the line numbering margin can obscure text. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=b0ecbbca7f77c0f07cff67bba3d2bca28954a1e2 Author: Dhiraj Chawla Modified Files

Re: [pgadmin-hackers] Number of selected characters.

2011-01-04 Thread Dave Page
On Tue, Jan 4, 2011 at 3:41 PM, Guillaume Lelarge wrote: > Le 04/01/2011 16:27, Dave Page a écrit : >> On Tue, Jan 4, 2011 at 2:05 PM, Guillaume Lelarge >> wrote: >>> Ch is not obvious either. But, what about Sel? >> >> It is obvious when it changes to a new value every time you move the >> curso

Re: [pgadmin-hackers] Number of selected characters.

2011-01-04 Thread Guillaume Lelarge
Le 04/01/2011 16:27, Dave Page a écrit : > On Tue, Jan 4, 2011 at 2:05 PM, Guillaume Lelarge > wrote: >> Ch is not obvious either. But, what about Sel? > > It is obvious when it changes to a new value every time you move the > cursor. Sl (or Sel) isn't - you don't see it change in normal > operat

Re: [pgadmin-hackers] Number of selected characters.

2011-01-04 Thread Dave Page
On Tue, Jan 4, 2011 at 2:05 PM, Guillaume Lelarge wrote: > Ch is not obvious either. But, what about Sel? It is obvious when it changes to a new value every time you move the cursor. Sl (or Sel) isn't - you don't see it change in normal operation. >> - It's of extremely limited utility in my opi

Re: [pgadmin-hackers] Number of selected characters.

2011-01-04 Thread Guillaume Lelarge
Le 04/01/2011 14:43, Dave Page a écrit : > On Sat, Dec 18, 2010 at 8:14 PM, Guillaume Lelarge > wrote: >> Le 16/12/2010 01:25, Vinicius Santos a écrit : >>> Em 15/12/2010 21:55, Vinicius Santos escreveu: I'm sending a patch. Thanks. >>> >>> Or Better. >>> >> >> Commited. I repl

Re: [pgadmin-hackers] Number of selected characters.

2011-01-04 Thread Dave Page
On Sat, Dec 18, 2010 at 8:14 PM, Guillaume Lelarge wrote: > Le 16/12/2010 01:25, Vinicius Santos a écrit : >> Em 15/12/2010 21:55, Vinicius Santos escreveu: >>> >>> I'm sending a patch. >>> >>> Thanks. >> >> Or Better. >> > > Commited. I replaced the / character with a comma, but nothing else. > T