[pgadmin-hackers] pgAdmin III: EDB procedures with non void return types not handled properly

2011-01-30 Thread Nikhil S
Hi, With the latest refactorings in the EDBAS90 source base, procedures (CREATE PROCEDURE objects) can have non void return types in some cases. For example: edb=# create or replace procedure set_Order ( v_indexINOUT integer ) AS counterinteger; BEGIN counter := 0; v_

Re: [pgadmin-hackers] pgAdmin III: Error on clicking "Display Objects" while doing a restore

2011-01-30 Thread Nikhil S
> Just applied. > > This issue was bugging me too, but I couldn't find a proper fix. So, > thanks a lot for this :) > > Glad to be of some help :). Thanks Guillaume. Regards, Nikhils

[pgadmin-hackers] Add support for directory dump and restore

2011-01-30 Thread Guillaume Lelarge
Hi, Subject says it all. This patch aims to support this new feature of 9.1: http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=7f508f1c6b515df66d27f860b2faa7b5761fa55d The radiobox in the dump window has been changed into a combobox because we have now four possible choices and it

Re: [pgadmin-hackers] pgAdmin III: Error on clicking "Display Objects" while doing a restore

2011-01-30 Thread Guillaume Lelarge
Hi, Le 29/01/2011 09:56, Nikhil S a écrit : > [...] > The following set of operations induce an error: > > 1. Create a backup file /tmp/pg.backup of an existing database > 2. Create a new database > 3. Right click and select restore database by specifying this file > 4. Clicking on "Display Objec

[pgadmin-hackers] pgAdmin III commit: Fix an error when clicking on "Display objects"

2011-01-30 Thread Guillaume Lelarge
Fix an error when clicking on "Display objects" The frmRestore::OnEndProcess() function, when it reads the toc information, should ignore the line which contains the entry for the dumped database itself. So the current code erroneously tries to find the schema to which the DATABASE object belongs

[pgadmin-hackers] pgAdmin III commit: Fix an error when clicking on "Display objects"

2011-01-30 Thread Guillaume Lelarge
Fix an error when clicking on "Display objects" The frmRestore::OnEndProcess() function, when it reads the toc information, should ignore the line which contains the entry for the dumped database itself. So the current code erroneously tries to find the schema to which the DATABASE object belongs

Re: [pgadmin-hackers] Patch to support SSL certificate connections

2011-01-30 Thread Guillaume Lelarge
Le 28/01/2011 20:44, Guillaume Lelarge a écrit : > Le 28/01/2011 19:39, Dave Page a écrit : >> That's better. >> >> Fyi, the other design did look OK - i just think we need to plan such >> changes properly and implement in batches rather than piecemeal. >> > > My issue with my last design is that

Re: [pgadmin-hackers] Number of selected characters.

2011-01-30 Thread Guillaume Lelarge
Le 22/01/2011 01:18, Guillaume Lelarge a écrit : > Le 21/01/2011 10:17, Dave Page a écrit : >> On Fri, Jan 21, 2011 at 9:16 AM, Dave Page wrote: >>> On Thu, Jan 20, 2011 at 10:33 PM, Guillaume Lelarge >>> wrote: Le 04/01/2011 17:34, Dave Page a écrit : > On Tue, Jan 4, 2011 at 3:41 PM, G

Re: [pgadmin-hackers] Support for pg_stat_database_conflicts and pg_stat_replication

2011-01-30 Thread Guillaume Lelarge
Le 20/01/2011 23:06, Guillaume Lelarge a écrit : > Hi, > > Two new patchs to add support for these 9.1 features. > > Not a lot to say. pg_stat_database_conflicts adds the new statistics > columns in the Databases node and on each database's node. > pg_stat_replication adds informations in each se

[pgadmin-hackers] pgAdmin III commit: Add pg_stat_replication with pg_stat_activity

2011-01-30 Thread Guillaume Lelarge
Add pg_stat_replication with pg_stat_activity Only in server's Statistics tab, so that we can have a look at the replication activity when we are on the server's node. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=e8e93a6800104073e192a777483f

[pgadmin-hackers] pgAdmin III commit: Add a specific panel for selection information

2011-01-30 Thread Guillaume Lelarge
Add a specific panel for selection information This patch adds a new panel to show the number of selected characters in the query tool. Moreover, it uses " chars" instead of "Sel. " (the latter one being less descriptive). Branch -- master Details --- http://git.postgresql.org/gitweb?p=p

[pgadmin-hackers] pgAdmin III commit: Support for SSL certificate files

2011-01-30 Thread Guillaume Lelarge
Support for SSL certificate files This patch adds support to specify SSL certificate files, and to connect with them. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=bb101a0b79a44567d65a8017de01ad8043fe5e29 Modified Files -- CHANGE

[pgadmin-hackers] pgAdmin III commit: Add pg_stat_database_conflicts to the db stats

2011-01-30 Thread Guillaume Lelarge
Add pg_stat_database_conflicts to the db stats All stats available in the new pg_stat_database_conflicts view of 9.1 are available in the statistics tabs of the Databases node and of earch database's node. pg_stat_database.conflicts is not used because it is a sum of the other ones. Branch -