Re: [pgadmin-hackers] Updated sequence syntax

On 3 July 2011 22:40, Guillaume Lelarge wrote: > On Sun, 2011-07-03 at 19:23 +0100, Thom Brown wrote: >> [...] >> I noticed that altering sequences still uses the old ALTER TABLE >> syntax.  While that's required for older versions, it's not anymore. >> Attached a patch to use most up-to-date synt

[pgadmin-hackers] pgAdmin III commit: Use the new syntax for sequence when possible

Use the new syntax for sequence when possible In 8.4, the ALTER SEQUENCE can be used to rename a sequence, and to change the owner of a sequence. First patch from Thom Brown, few changes by me. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=2

Re: [pgadmin-hackers] Updated sequence syntax

On Sun, 2011-07-03 at 19:23 +0100, Thom Brown wrote: > [...] > I noticed that altering sequences still uses the old ALTER TABLE > syntax. While that's required for older versions, it's not anymore. > Attached a patch to use most up-to-date syntax for each version. This > is based on the previous

Re: [pgadmin-hackers] [FEATURE] OIDs check box to enable OIDs

On Sun, 2011-07-03 at 12:34 +0100, Thom Brown wrote: > On 2 July 2011 21:26, Thom Brown wrote: > > On 2 July 2011 20:20, Guillaume Lelarge wrote: > >> Great patch. It even helped me find a bug. Anyway, commited and pushed. > >> Thank you. > > > > Thanks for committing it. :) > > > >>> I personall

[pgadmin-hackers] pgAdmin III commit: Wrap SQL lines for ALTER commands

Wrap SQL lines for ALTER commands Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=ad38180640dff0a9f0969964bc26d8df03f7eef7 Author: Thom Brown Modified Files -- pgadmin/dlg/dlgCheck.cpp |4 ++-- pgadmin/dlg/dlgDatabase.

[pgadmin-hackers] Updated sequence syntax

Hi, I noticed that altering sequences still uses the old ALTER TABLE syntax. While that's required for older versions, it's not anymore. Attached a patch to use most up-to-date syntax for each version. This is based on the previous newline patch having already been applied. Obviously this won't

[pgadmin-hackers] [BUG] Index operator class + collation = bad SQL

Hi, I noticed that when using PostgreSQL 9.1 and PgAdmin III 1.14 beta 2, the operator class, sort order and whether nulls are first or last appears before collation on a column when showing the index definition in the SQL pane, but this is invalid syntax. Test case: CREATE TABLE dictionary (wor

Re: [pgadmin-hackers] [FEATURE] OIDs check box to enable OIDs

On 2 July 2011 21:26, Thom Brown wrote: > On 2 July 2011 20:20, Guillaume Lelarge wrote: >> Great patch. It even helped me find a bug. Anyway, commited and pushed. >> Thank you. > > Thanks for committing it. :) > >>> I personally prefer the ones with newlines, especially since I've been >>> exper

Re: [pgadmin-hackers] pgAdmin III commit: Update CHANGELOG and make style.

On Sun, 2011-07-03 at 01:00 +0100, Thom Brown wrote: > On 2 July 2011 23:17, Guillaume Lelarge wrote: > > Update CHANGELOG and make style. > > > > Branch > > -- > > master > > > > Details > > --- > > http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=ac158b076d598748d8d9bac4afc

[pgadmin-hackers] pgAdmin III commit: New maintenance action: CLUSTER

New maintenance action: CLUSTER Available for databases, tables, indexes, and some constraints. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=b40e8f9f1cda5aaffc40f85a93d7fe85b80e8ec4 Author: Thom Brown Modified Files -- CHANGELO

Re: [pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)

On Sat, Jul 2, 2011 at 2:09 PM, Guillaume Lelarge wrote: > On Thu, 2011-06-30 at 09:32 +0100, Dave Page wrote: >> On Thu, Jun 30, 2011 at 9:08 AM, Guillaume Lelarge >> wrote: >> > >> > Could be the next thing I do. Last time we talked about it, I had done >> > some work on sphynx. IIRC, I had two