Re: [pgadmin-hackers] [PATCH] Added a menu option to disable code folding

2014-01-09 Thread Dave Page
On Wed, Jan 8, 2014 at 10:49 PM, Kaarel Moppel wrote: > Hmm, I'm not sure if we're talking about the same thing now, yes I don't > have to click that but I mean for me there's just no way to look pass that. > The clickable box with the minus sign together with the downstretching line > that appear

Re: [pgadmin-hackers] [PATCH] fix newly added server being lost when crashing

2014-01-09 Thread Ashesh Vashi
Dave, In that case, we should not change the inheritance mode. Kaarel, I've attached the patch as per Dave's comment. Can you please test it at your end? On Thu, Jan 9, 2014 at 2:35 PM, Dave Page wrote: > > > > On Thu, Jan 9, 2014 at 4:41 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com>

Re: [pgadmin-hackers] [PATCH] Add a menu option for disabling restoration of previous environment on reconnect

2014-01-09 Thread Dave Page
On Wed, Jan 8, 2014 at 10:33 PM, Kaarel Moppel wrote: > Oh indeed, missed the attachment somehow, sorry about that. > > And yes, there's an option already for that. But its on the 'advanced' tab > with the default being "on" (changing this to "off" wouldn't probably be > nice now) meaning couple o

Re: [pgadmin-hackers] [PATCH] fix newly added server being lost when crashing

2014-01-09 Thread Dave Page
On Thu, Jan 9, 2014 at 4:41 AM, Ashesh Vashi wrote: > Looking good to me. > If nobody has any objection, then I can check-in. > > NOTE: > I don't know the reason for the class sysSettings to inherit the wxConfig > privately in original implementation. > It was done by Dave in this commit: > cfbae7