Re: [pgadmin-hackers] Patch : PGPASSFILE fix

On Wed, Mar 4, 2015 at 8:44 AM, Prasad wrote: > Ashesh, > > Thanks for reviewing patch, > Code I have removed in I think, was switch statement inside if condition, > which doesn't make sense. > ie. > if (var == 2) > { > switch (var) > case 2: > . > bre

Re: [pgadmin-hackers] Patch : PGPASSFILE fix

Ashesh, Thanks for reviewing patch,  Code I have removed in I think, was switch statement inside if condition, which doesn't make sense. ie. if (var == 2) { switch (var) case 2: . break; } that's why I removed it, because it's redundant. About creatio

Re: [pgadmin-hackers] Patch : PGPASSFILE fix

Hi Prasad, I see couple of issues with your patch. * Please generate the patch using 'git diff'. I could not apply your patch straight forwardly. I had to use the patch utility. * Please follow the coding style of pgAdmin. You can find it at https://wiki.postgresql.org/wiki/PgAdmin_Internal

Re: [pgadmin-hackers] assert "!IsAttached()" failed in SetInvokingWindow()

Sure -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Tue, Mar 3, 2015 at 2:01 PM, Dave Page wrote: > Ashesh; can you please get this reviewe

Re: [pgadmin-hackers] PgAgent Patch

Sure -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Tue, Mar 3, 2015 at 2:01 PM, Dave Page wrote: > Ashesh; can you please get this reviewe

Re: [pgadmin-hackers] Patch : PGPASSFILE fix

Sure. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Tue, Mar 3, 2015 at 2:01 PM, Dave Page wrote: > Ashesh; can you please get this review

[pgadmin-hackers] pgAdmin 4 commit: Allow modules to create browser panels.

Allow modules to create browser panels. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7441d98c496bd313ca10a3a13f6760280edebfd1 Modified Files -- .../browser/templates/browser/js/browser.js| 49 + web/pgadm

[pgadmin-hackers] pgAdmin 4 commit: Don't restyle scroll bars.

Don't restyle scroll bars. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=497164d741b5cf54b7acd4145af7f1ba8e32b9e1 Modified Files -- web/pgadmin/static/css/wcDocker/theme.css|2 + web/pgadmin/static/css/wcDocker/wcDocker.css

Re: [pgadmin-hackers] assert "!IsAttached()" failed in SetInvokingWindow()

Ashesh; can you please get this reviewed and applied if it looks OK? Thanks. On Sun, Mar 1, 2015 at 10:14 PM, Prasad wrote: > Hi, > > It seems that, wxWidget has added some checks in PopupMenu API. We can just > directly call DoPopupMenu instead. Find attached patch. Seems harmless to > direct

Re: [pgadmin-hackers] PgAgent Patch

Ashesh; can you please get this reviewed and applied if it looks OK? Thanks. On Tue, Mar 3, 2015 at 12:00 PM, Mehmet Emin KARAKAŞ wrote: > Hi, > If batch cron is failed, pgagent doesn't receive error messages. We fix it. > We canalized the stderr to stdout. This patch batch cron receive error >

Re: [pgadmin-hackers] Patch : PGPASSFILE fix

Ashesh; can you please get this reviewed and applied if it looks OK? Thanks. On Sun, Mar 1, 2015 at 10:08 PM, Prasad wrote: > > Hi, > > Find attached fix for reading PGPASSFILE environment variable for pg password > file. > > regards, > Prasad > > -- > Sent via pgadmin-hackers mailing list (pga

[pgadmin-hackers] PgAgent Patch

Hi, If batch cron is failed, pgagent doesn't receive error messages. We fix it. We canalized the stderr to stdout. This patch batch cron receive error massages from nix machine. Git Diff Message and job.cpp file is attached. Thanks. -- MEHMET EMİN KARAKAŞ Postgresql Global Username: emin100 d

[pgadmin-hackers] pgAdmin 4 commit: Update wcDocker to enable properly translation of the

Update wcDocker to enable properly translation of the context menu options. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=527620d34e0647a391ad68be20da22dd2c458163 Modified Files -- .../browser/templates/browser/js/browser.js

[pgadmin-hackers] pgAdmin 4 commit: Fix i18n for the docking system.

Fix i18n for the docking system. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cd059aaea3647ab97af64d7e1664a2688460bead Modified Files -- web/babel.cfg |1 + .../browser/templates/browser/js

[pgadmin-hackers] pgAdmin 4 commit: Fix placeholder text.

Fix placeholder text. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=eef0a48823c89ee5d57d59202958d727d27d3cef Modified Files -- web/pgadmin/browser/templates/browser/js/browser.js |8 1 file changed, 4 insertions(+), 4