Sorry, the patch contained the unnecessary newline in the condition. This
is fixed and the patch is attached.
On Wed, Feb 25, 2015 at 6:44 PM, Dave Page wrote:
> Thanks - patch applied.
>
> On Wed, Feb 25, 2015 at 6:09 AM, Sandeep Thakkar <
> sandeep.thak...@enterprisedb.com> wrote:
>
>> Hi
>>
Hi,
As mentioned in my earlier communication code calling this function is checking
for file existence. So if we decide to add code for creation of full path, then
similar code has to be removed from location of call to this function.
Otherwise, it will end up with multiple error messages. It's
On Wed, Mar 4, 2015 at 4:40 PM, Dave Page wrote:
>
>
> On Wed, Mar 4, 2015 at 11:06 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Wed, Mar 4, 2015 at 4:09 PM, Dave Page wrote:
>>
>>> I think we should try to create the full path if necessary, and simply
>>> throw an error if
On Wed, Mar 4, 2015 at 11:06 AM, Ashesh Vashi wrote:
> On Wed, Mar 4, 2015 at 4:09 PM, Dave Page wrote:
>
>> I think we should try to create the full path if necessary, and simply
>> throw an error if we can't.
>
> And, I think - we should switch back to default pgpass configuration file.
>
No
This is already done by somewhere in code by calling function. In this case we
need to move file creation in this function.
Will look in to it tonight or over weekend.
regards,
Prasad
Sent: Wednesday, March 04, 2015 at 10:39 AM
From: "Dave Page"
To: Prasad
Cc: pgadmin-hackers , "Ashesh Vashi
On Wed, Mar 4, 2015 at 4:09 PM, Dave Page wrote:
> I think we should try to create the full path if necessary, and simply
> throw an error if we can't.
And, I think - we should switch back to default pgpass configuration file.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise
Sure.
On Wed, Mar 4, 2015 at 4:20 PM, Dave Page wrote:
>
>
> On Wed, Mar 4, 2015 at 10:48 AM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Dave,
>>
>> On Wed, Mar 4, 2015 at 4:11 PM, Dave Page wrote:
>>
>>> Hi,
>>>
>>> Mehmet may not be able to work on Windows, so one of us may h
On Wed, Mar 4, 2015 at 10:48 AM, Akshay Joshi wrote:
> Dave,
>
> On Wed, Mar 4, 2015 at 4:11 PM, Dave Page wrote:
>
>> Hi,
>>
>> Mehmet may not be able to work on Windows, so one of us may have to deal
>> with that. Did we not solve this already in PEM btw?
>>
>
> Yes we have solved it in PE
Dave,
On Wed, Mar 4, 2015 at 4:11 PM, Dave Page wrote:
> Hi,
>
> Mehmet may not be able to work on Windows, so one of us may have to deal
> with that. Did we not solve this already in PEM btw?
>
Yes we have solved it in PEM, I have send the source code in my
previous email.
>
> On Wed, Mar
Hi,
Mehmet may not be able to work on Windows, so one of us may have to deal
with that. Did we not solve this already in PEM btw?
On Wed, Mar 4, 2015 at 10:16 AM, Akshay Joshi wrote:
> Hi Mehmet
>
> I have reviewed the patch, but it is only for nix machine. Can you please
> provide a patch wher
I think we should try to create the full path if necessary, and simply
throw an error if we can't.
On Wed, Mar 4, 2015 at 10:01 AM, Prasad wrote:
> Alright , I'll revert to PGPASS check.
> Existing function only creates folder containing file. With this case, whats
> expected ? Reading value in
Hi Mehmet
I have reviewed the patch, but it is only for nix machine. Can you please
provide a patch where it should be fixed for Windows as well. I
have implemented the same in one of my project using below logic which
works for both windows and nix. You can tried out the below logic
errFile = 'x
Alright , I'll revert to PGPASS check.
Existing function only creates folder containing file. With this case, whats
expected ? Reading value in PGPASSFILE and try to create folder containing
pgpass file (Assuming it's valid path)? Remember, it's environment variable.
User can specify anything in
13 matches
Mail list logo
