Re: [pgadmin-hackers] autocommit feature in pgadmin

2015-03-31 Thread Ashesh Vashi
Hi Sanket, In your patch, I see couple of issues with your patch: 1. In pgadmin/frm/frmQuery.cpp: You've used "settings->Read(wxT("frmQuery/AutoCommit"), &bVal, true)" directly. You should be using the function, you've defined in sysSettings. i.e. sysSettings::GetAutoCommit() and, sysSettings::Set

Re: [pgadmin-hackers] PATCH: pgagent fix for 'Caught unhandled unknown exception; terminating' bug in SQL steps

2015-03-31 Thread Ashesh Vashi
On Tue, Mar 31, 2015 at 6:20 PM, Dave Page wrote: > > > On Tue, Mar 31, 2015 at 8:45 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Thu, Mar 26, 2015 at 6:19 PM, Thomas Krennwallner < >> tk+pg...@postsubmeta.net> wrote: >> >>> Hi! >>> >>> Running pgagent 3.4.0 on Debian jessie

Re: [pgadmin-hackers] PATCH: pgagent fix for 'Caught unhandled unknown exception; terminating' bug in SQL steps

2015-03-31 Thread Dave Page
On Tue, Mar 31, 2015 at 8:45 AM, Ashesh Vashi wrote: > On Thu, Mar 26, 2015 at 6:19 PM, Thomas Krennwallner < > tk+pg...@postsubmeta.net> wrote: > >> Hi! >> >> Running pgagent 3.4.0 on Debian jessie with an SQL jobstep crashes the >> worker thread with the error message >> >> Caught unhandled unk

Re: [pgadmin-hackers] PATCH: pgagent fix for 'Caught unhandled unknown exception; terminating' bug in SQL steps

2015-03-31 Thread Ashesh Vashi
On Thu, Mar 26, 2015 at 6:19 PM, Thomas Krennwallner < tk+pg...@postsubmeta.net> wrote: > Hi! > > Running pgagent 3.4.0 on Debian jessie with an SQL jobstep crashes the > worker thread with the error message > > Caught unhandled unknown exception; terminating > > Both job and jobstep status then r