Re: [pgadmin-hackers] Patch : PGPASSFILE fix

2015-04-16 Thread Prasad
Yes, that's right. regards, Prasad    Sent: Thursday, April 16, 2015 at 2:00 PM From: "Sanket Mehta" To: Prasad Cc: pgadmin-hackers Subject: Re: [pgadmin-hackers] Patch : PGPASSFILE fix Hi,   Below is my understanding of this patch:   When checking for password file in getconfigfile() functio

Re: [pgadmin-hackers] [Patch] PGAdmin 4 JSON Handling

2015-04-16 Thread Dave Page
On Thu, Apr 16, 2015 at 2:44 PM, Ronan Dunklau wrote: > Le jeudi 16 avril 2015 11:40:14 Dave Page a écrit : >> On Thu, Apr 16, 2015 at 11:19 AM, Ronan Dunklau >> >> wrote: >> > Le jeudi 16 avril 2015 15:46:51 Ashesh Vashi a écrit : >> >> Hi Ronan, >> >> >> >> On Thu, Apr 16, 2015 at 2:49 PM, Rona

Re: [pgadmin-hackers] [Patch] PGAdmin 4 JSON Handling

2015-04-16 Thread Ronan Dunklau
Le jeudi 16 avril 2015 11:40:14 Dave Page a écrit : > On Thu, Apr 16, 2015 at 11:19 AM, Ronan Dunklau > > wrote: > > Le jeudi 16 avril 2015 15:46:51 Ashesh Vashi a écrit : > >> Hi Ronan, > >> > >> On Thu, Apr 16, 2015 at 2:49 PM, Ronan Dunklau > >> > >> wrote: > >> > Hello. > >> > > >> > I'm

Re: [pgadmin-hackers] Patch : PGPASSFILE fix

2015-04-16 Thread Sanket Mehta
Hi, Below is my understanding of this patch: When checking for password file in getconfigfile() function, it should first check for parent directory and if that does not exists then it should create it. Same operation should happen for password file also. If my understanding is correct, the patc

Re: [pgadmin-hackers] [Patch] PGAdmin 4 JSON Handling

2015-04-16 Thread Ashesh Vashi
On Thu, Apr 16, 2015 at 4:10 PM, Dave Page wrote: > On Thu, Apr 16, 2015 at 11:19 AM, Ronan Dunklau > wrote: > > Le jeudi 16 avril 2015 15:46:51 Ashesh Vashi a écrit : > >> Hi Ronan, > >> > >> On Thu, Apr 16, 2015 at 2:49 PM, Ronan Dunklau < > ronan.dunk...@dalibo.com> > >> > >> wrote: > >> > He

Re: [pgadmin-hackers] [Patch] PGAdmin 4 JSON Handling

2015-04-16 Thread Dave Page
On Thu, Apr 16, 2015 at 11:19 AM, Ronan Dunklau wrote: > Le jeudi 16 avril 2015 15:46:51 Ashesh Vashi a écrit : >> Hi Ronan, >> >> On Thu, Apr 16, 2015 at 2:49 PM, Ronan Dunklau >> >> wrote: >> > Hello. >> > >> > I'm trying to dive into the PGAdmin 4 codebase, and one low hanging fruit >> > that

Re: [pgadmin-hackers] [Patch] PGAdmin 4 JSON Handling

2015-04-16 Thread Ashesh Vashi
On Thu, Apr 16, 2015 at 3:49 PM, Ronan Dunklau wrote: > Le jeudi 16 avril 2015 15:46:51 Ashesh Vashi a écrit : > > Hi Ronan, > > > > On Thu, Apr 16, 2015 at 2:49 PM, Ronan Dunklau > > > > > wrote: > > > Hello. > > > > > > I'm trying to dive into the PGAdmin 4 codebase, and one low hanging > frui

Re: [pgadmin-hackers] [Patch] PGAdmin 4 JSON Handling

2015-04-16 Thread Ronan Dunklau
Le jeudi 16 avril 2015 15:46:51 Ashesh Vashi a écrit : > Hi Ronan, > > On Thu, Apr 16, 2015 at 2:49 PM, Ronan Dunklau > > wrote: > > Hello. > > > > I'm trying to dive into the PGAdmin 4 codebase, and one low hanging fruit > > that > > I saw was the handling of JSON data. > > > > The first patc

Re: [pgadmin-hackers] [Patch] PGAdmin 4 JSON Handling

2015-04-16 Thread Ashesh Vashi
Hi Ronan, On Thu, Apr 16, 2015 at 2:49 PM, Ronan Dunklau wrote: > Hello. > > I'm trying to dive into the PGAdmin 4 codebase, and one low hanging fruit > that > I saw was the handling of JSON data. > > The first patch is really trivial, and allows PgAdmin4 to run on system > with > case sensitive

[pgadmin-hackers] [Patch] PGAdmin 4 JSON Handling

2015-04-16 Thread Ronan Dunklau
Hello. I'm trying to dive into the PGAdmin 4 codebase, and one low hanging fruit that I saw was the handling of JSON data. The first patch is really trivial, and allows PgAdmin4 to run on system with case sensitive filesystems. JSON data should be returned to the client using an application/json