Re: [pgadmin-hackers] PGAdmin 4 architecture (Was: [Patch] PGAdmin 4 JSON Handling)

2015-04-22 Thread Ashesh Vashi
Hi Dave/Ronan, On Mon, Apr 20, 2015 at 4:10 PM, Dave Page wrote: > On Mon, Apr 20, 2015 at 10:52 AM, Ronan Dunklau > wrote: > >> Ronan; can you update the test, help and about modules as well please? > > > > Done, please find attached a new patch for that. Ashesh, once you're > done with > > wh

Re: [pgadmin-hackers] autocommit feature in pgadmin

2015-04-22 Thread Sanket Mehta
Hi, I have made the following changes: When autocommit mode is enabled and transaction is not idle, it will show a warning message to user suggesting to close the current transaction by executing COMMIT or ROLLBACK in order to take the effect of AUTOCOMMIT mode. I have attached the patch with th

Re: [pgadmin-hackers] autocommit feature in pgadmin

2015-04-22 Thread Sanket Mehta
Hi, Sure, I will do the required changes. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Wed, Apr 22, 2015 at 3:09 PM, Ashesh Vashi wrote: > > > On Wed, Apr 22, 2015 at 1:23 PM, Dave Page wrote: > >> >> >> On Wed, Apr 22, 2015 at 8:40 AM, Ashesh Vashi < >> ashesh.va...@enterprise

Re: [pgadmin-hackers] autocommit feature in pgadmin

2015-04-22 Thread Ashesh Vashi
On Wed, Apr 22, 2015 at 1:23 PM, Dave Page wrote: > > > On Wed, Apr 22, 2015 at 8:40 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Tue, Apr 7, 2015 at 11:02 AM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> On Wed, Apr 1, 2015 at 2:31 PM, Sanket Mehta < >>> s

Re: [pgadmin-hackers] Patch : PGPASSFILE fix

2015-04-22 Thread Prasad
Hi, Is there anything remained to be done for this patch ? thanks and regards, Prasad     Sent: Thursday, April 16, 2015 at 2:00 PM From: "Sanket Mehta" To: Prasad Cc: pgadmin-hackers Subject: Re: [pgadmin-hackers] Patch : PGPASSFILE fix Hi,   Below is my understanding of this patch:   When

[pgadmin-hackers] pgAdmin III commit: Do not unlock the mutex, which was not owned by the

2015-04-22 Thread Ashesh Vashi
Do not unlock the mutex, which was not owned by the thread, during creating the popup menu. (cherry picked from commit 127b89c273c4588c5f49ffa8bccab730c76740a8) Conflicts: CHANGELOG Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=f7576

[pgadmin-hackers] pgAdmin III commit: Do not unlock the mutex, which was not owned by the

2015-04-22 Thread Ashesh Vashi
Do not unlock the mutex, which was not owned by the thread, during creating the popup menu. Branch -- REL-1_20_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=127b89c273c4588c5f49ffa8bccab730c76740a8 Author: Wander Nauta Modified Files --

Re: [pgadmin-hackers] autocommit feature in pgadmin

2015-04-22 Thread Dave Page
On Wed, Apr 22, 2015 at 8:40 AM, Ashesh Vashi wrote: > On Tue, Apr 7, 2015 at 11:02 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Wed, Apr 1, 2015 at 2:31 PM, Sanket Mehta < >> sanket.me...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> I have made all the changes mentioned in b

Re: [pgadmin-hackers] autocommit feature in pgadmin

2015-04-22 Thread Ashesh Vashi
On Tue, Apr 7, 2015 at 11:02 AM, Ashesh Vashi wrote: > On Wed, Apr 1, 2015 at 2:31 PM, Sanket Mehta < > sanket.me...@enterprisedb.com> wrote: > >> Hi, >> >> I have made all the changes mentioned in below mail. >> Along with that I have changed the code to read autoRollBack value in >> pgadmin/frm