Re: [pgadmin-hackers] patch: fix errors after libssh2 merge

Thanks. I have checked-in. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Tue, Dec 8, 2015 at 10:41 PM, Dmitriy Olshevskiy wrote: > Hello e

[pgadmin-hackers] pgAdmin III commit: A manual merge of few last commits from libssh2 res

A manual merge of few last commits from libssh2 resulted into an critical issue. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=5b2f89173e0da9c27afe4aa686e43dd46c9666ae Author: Dmitriy Olshevskiy Modified Files -- pgadmin/libssh2/

[pgadmin-hackers] patch: fix errors after libssh2 merge

Hello everyone! please see the file attached. there are some small, but critical errors in the libssh2/hostkey.c. thank you. -- Dmitriy Olshevskiy diff --git a/pgadmin/libssh2/hostkey.c b/pgadmin/libssh2/hostkey.c index cdd788d..09955d7 100644 --- a/pgadmin/libssh2/hostkey.c +++ b/pgadmin/libs

Re: [pgadmin-hackers] patch: fix to use ``pg_get_functiondef()``

COMMENT-1 ON GITHUB [BEGIN] <<< Dmitriy olshevski...@bk.ru >>> BTW pg_get_functiondef() -- less wrong what's wrong with this function? :) COMMENT-2 ON GITHUB [BEGIN] ok. a few examples: example "A"

Re: [pgadmin-hackers] [pgadmin-support] SSH tunnel key exchange methods

On Tue, Dec 8, 2015 at 6:36 PM, Dave Page wrote: > Yes, I think so. > Thanks. I have committed the code in the master branch, from which we will create a new branch 'REL-1_22_0_PATCHES' for 1.22.x releases. -- Thanks & Regards, Ashesh Vashi > > On Tue, Dec 8, 2015 at 1:05 PM, Ashesh Vashi < >

[pgadmin-hackers] pgAdmin III commit: Merging the libssh2 to the latest developement vers

Merging the libssh2 to the latest developement version (post 1.6.0 release). It has been merged from the repository - https://github.com/libssh2/libssh2 upto commit-id: 95dc2a6a52fbc942babd80eb9b977cfc0e48d2f8 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=

Re: [pgadmin-hackers] [pgadmin-support] SSH tunnel key exchange methods

Dave, Patch looks good to me. But - Should we consider this as a bug fix, and commit it for 1.22.0 release? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi*

Re: [pgadmin-hackers] [pgadmin-support] SSH tunnel key exchange methods

Yes, I think so. On Tue, Dec 8, 2015 at 1:05 PM, Ashesh Vashi wrote: > Dave, > > Patch looks good to me. > But - Should we consider this as a bug fix, and commit it for 1.22.0 > release? > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company >

Re: [pgadmin-hackers] patch: fixing dublicates foreign-tables

Hi Andrej Your patch looks good to me. During testing I came across one more issue when user select the existing foreign table and click on Properties menu entry in the "Foreign Server" combo box is blank. I have fixed the issue and attached is the patch with combined fix. *Issue *:- As per the c

[pgadmin-hackers] patch: fix to use ``pg_get_functiondef()``

patch: fix to use ``pg_get_functiondef()`` [see attachment file] it is copy of pull-request https://github.com/postgres/pgadmin3/pull/12 thank you! -- Андрей Антонов, инженер-программист отдела информационных технологий и программирования, компания «Импульс М»From c8330fefa05278b73f8a4f79645f4c

Re: [pgadmin-hackers] patch: fixing dublicates foreign-tables

Hi Andrej Can you please share the reproduction step of the issue that you have fixed. On Tue, Dec 8, 2015 at 11:15 AM, Akshay Joshi wrote: > > > On Tue, Dec 8, 2015 at 11:09 AM, Dave Page wrote: > >> Akshay, can you review this please? >> > >Sure, Dave. > >> >> 2015-12-07 19:47 GMT+05:30