[pgadmin-hackers] pgAdmin 4 commit: Don't add (GROUP) to the end of group role names; tha

2016-02-12 Thread Dave Page
Don't add (GROUP) to the end of group role names; that's denoted by the icon. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=47fc43c23f0670f6d4c7eb4521a20c5f8c7be4fb Modified Files -- .../browser/server_groups/servers/roles/templat

[pgadmin-hackers] pgAdmin 4 commit: Don't ask before connecting to servers or databases,

2016-02-12 Thread Dave Page
Don't ask before connecting to servers or databases, just do it like pgAdmin 3. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=131043d7cb1b0bb8ac59d808ad232922dbc171fc Modified Files -- .../databases/templates/databases/js/database

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Language Module

2016-02-12 Thread Dave Page
On Fri, Feb 12, 2016 at 11:21 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > New language patch is working fine. > Ashesh - Can you please review it ? > If it looks good then can you please commit ? > > Thank you, > Harshal > A few comments: - We omitted CREATE LANGUAGE,

Re: [pgadmin-hackers] patch for cast module

2016-02-12 Thread Dave Page
On Fri, Feb 12, 2016 at 11:57 AM, Sanket Mehta < sanket.me...@enterprisedb.com> wrote: > Hi Akshay, > > PFA the updated patch. > > Hi When testing this patch, I get the following error: Traceback (most recent call last): File "pgAdmin4.py", line 56, in app = create_app() File "/Users/dp

Re: [pgadmin-hackers] pgAdmin III: Muliple SQL tabs

2016-02-12 Thread Dave Page
On Thu, Feb 11, 2016 at 2:22 PM, Sergey Busel wrote: > Added the query name to history entries. Please note that history entries > are not modified if user saves [Query 1] to file [foo.sql]. I don't think > that would be practical. > Thanks. So I was just about to commit this, when it crashed on

Re: [pgadmin-hackers] patch for cast module

2016-02-12 Thread Sanket Mehta
Hi Akshay, PFA the updated patch. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Thu, Feb 11, 2016 at 12:09 PM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Sanket > > Most of the review comments has been resolved but I found some issues with > this patch > >- When

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Language Module

2016-02-12 Thread Harshal Dhumal
Hi, New language patch is working fine. Ashesh - Can you please review it ? If it looks good then can you please commit ? Thank you, Harshal -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Thu, Feb 11, 2016 at 4:01 PM, Akshay Joshi wrote: > Hi All >