Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Resource Group Module

Hi All On Mon, Feb 15, 2016 at 12:05 PM, Neel Patel wrote: > Hi Akshay, > > Please find below review comments. > >- We are getting error at python side saying "*AttributeError: >'Response' object has no attribute 'strip'*" >- "CPU Rate Limit" and "Dirty Rate Limit" should not allowed

Re: [pgadmin-hackers] pgAdmin III: Muliple SQL tabs

After trying it couple times, I was able to reproduce the crash. I think it was due to the way tabs were being closed. A dirty tab would prompt the user to save the changes and close the tab right away before moving on to the next tab. I think it crashed because the user was closing the window via

Re: [pgadmin-hackers] patch for cast module

And this time with the attachment... On Mon, Feb 15, 2016 at 4:53 PM, Dave Page wrote: > That's much better. Just a couple of comments now, partly based on an > email I wrote earlier: > > - There is still inconsistency in comment style. Please see the attachment > for an example. Note that there

Re: [pgadmin-hackers] patch for cast module

That's much better. Just a couple of comments now, partly based on an email I wrote earlier: - There is still inconsistency in comment style. Please see the attachment for an example. Note that there is *always* a space between the comment marker and text. - If I try to edit a cast, I can change

Re: [pgadmin-hackers] patch for cast module

Hi, PFA the revised patch with all the required comments. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Mon, Feb 15, 2016 at 4:18 PM, Dave Page wrote: > > > On Mon, Feb 15, 2016 at 8:10 AM, Sanket Mehta < > sanket.me...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Regarding your

[pgadmin-hackers] [pgAdmin4] Numeric Control for Backform

Hi All I have added Numeric Input control for Backform as we already have for Integer type. Also fixed one issue in Integer input control. *Usage:* schema: [{ id: 'name', label: '{{ _('Group Name') }}', cell: 'string', type: 'text', },{ id: 'cpu_rate_l

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

Hi On Mon, Feb 15, 2016 at 9:55 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > PFA patch with following changes: > >1. Added "Create Extension" menu item in context menu of Database node. >2. Added a new method "node_node" in ExtensionModule class. If a node >h

Re: [pgadmin-hackers] patch for cast module

On Mon, Feb 15, 2016 at 8:10 AM, Sanket Mehta wrote: > Hi Dave, > > Regarding your suggestion of putting some comments in javascript, I think > I have already put some comments regarding model data and their controls if > any extended. > > Can you please let me know where exactly you think more c

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Language Module

On Mon, Feb 15, 2016 at 7:29 AM, Akshay Joshi wrote: > Hi All > > Attached is the new patch after fixing review comments given by Dave. > > On Fri, Feb 12, 2016 at 10:04 PM, Dave Page wrote: > >> >> >> On Fri, Feb 12, 2016 at 11:21 AM, Harshal Dhumal < >> harshal.dhu...@enterprisedb.com> wrote:

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

Hi, PFA patch with following changes: 1. Added "Create Extension" menu item in context menu of Database node. 2. Added a new method "node_node" in ExtensionModule class. If a node has child, returns True, otherwise False. 3. Fixed an issue in which icon won't display in create extensi

Re: [pgadmin-hackers] work status

Please ignore this email as it was supposed to send on another mailing list. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Mon, Feb 15, 2016 at 1:27 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > I have started working on Ba

Re: [pgadmin-hackers] patch for cast module

Hi Dave, Regarding your suggestion of putting some comments in javascript, I think I have already put some comments regarding model data and their controls if any extended. Can you please let me know where exactly you think more comments are required? Regards, Sanket Mehta Sr Software engineer