Re: [pgadmin-hackers] PIP Package Building for pgAdmin4

Hi Dave, On Mon, Mar 14, 2016 at 7:06 PM, Dave Page wrote: > Hi > > On Mon, Mar 14, 2016 at 1:46 PM, Muhammad Aqeel > wrote: > > Hi Dave, > > > > I tested the build after your commit. There were minor bugs in your > changes > > which prevented the packaging of pgadmin4 sources. > > > > - It nee

Re: [pgadmin-hackers] PIP Package Building for pgAdmin4

Hi On Mon, Mar 14, 2016 at 1:46 PM, Muhammad Aqeel wrote: > Hi Dave, > > I tested the build after your commit. There were minor bugs in your changes > which prevented the packaging of pgadmin4 sources. > > - It needed a space after * in recursive include statement of manifest.in > - \n is not int

Re: [pgadmin-hackers] PATCH: PGADMIN 4 - FTS templates node

On Mon, Mar 14, 2016 at 1:52 PM, Sanket Mehta wrote: > Hi Dave, > > I have incorporated your changes. > I have also tried to reproduce the Issues that you have mentioned. > find the response inline. > > Also find revised patch having your suggested changes attached with this > mail. > Please do re

Re: [pgadmin-hackers] PATCH: PGADMIN 4 - FTS templates node

Hi Dave, I have incorporated your changes. I have also tried to reproduce the Issues that you have mentioned. find the response inline. Also find revised patch having your suggested changes attached with this mail. Please do review it and let me know in case anything is missing. Regards, Sanket

Re: [pgadmin-hackers] PIP Package Building for pgAdmin4

Hi Dave, I tested the build after your commit. There were minor bugs in your changes which prevented the packaging of pgadmin4 sources. - It needed a space after * in recursive include statement of manifest.in - \n is not interpreted as new line. I fixed both issues in attached patch and tested

[pgadmin-hackers] Fixed issue related to 'show_system_objects' in dependencies/dependents

Hi All As 'show_system_objects' has been implemented, I have fixed an issue for dependencies/dependents. With previous implementation each node will have to send the values of 'show_system_objects' while calling get_dependencies/get_dependents function. Now I have changed the logic to use the valu

Re: [pgadmin-hackers] PIP Package Building for pgAdmin4

Thanks Dave. --Aqeel On Mon, Mar 14, 2016 at 3:28 PM, Dave Page wrote: > Thanks - committed with some minor tweaks: > > - Avoid packaging *.pyc and pgadmin4.db > - Add some more keywords > - Minor re-arrangement of setup_pip.py and the Makefile. > > Thanks again! > > On Mon, Mar 14, 2016 at 6:3

Re: [pgadmin-hackers] PIP Package Building for pgAdmin4

Thanks - committed with some minor tweaks: - Avoid packaging *.pyc and pgadmin4.db - Add some more keywords - Minor re-arrangement of setup_pip.py and the Makefile. Thanks again! On Mon, Mar 14, 2016 at 6:33 AM, Muhammad Aqeel wrote: > Sorry for broken patch. > PFA the corrected patch. > > --Aq

[pgadmin-hackers] pgAdmin 4 commit: Add a top level Makefile with a target and appropriat

Add a top level Makefile with a target and appropriate Python stuff to build a PIP package of the web code. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dc64160f8249ec8ce9bf2978c8573e2706f8c432 Author: Muhammad Aqeel Modified Files ---

[pgadmin-hackers] pgAdmin 4 commit: Fix an issue with uneditable text fields containing l

Fix an issue with uneditable text fields containing large amounts of data, Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9220dcaa97fae226be1effcf06bfc4e11e0d27af Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/css/