Re: [pgadmin-hackers] [pgAdmin4][Patch] Add formatted error message support in psycopg2

Hi On Fri, Apr 1, 2016 at 3:53 PM, Ashesh Vashi wrote: > Hi Akshay, > > I've update the patch a little bit as discussed offline. > Also, renamed the variable 'is_cancel_transaction' to 'execution_aborted', > and enum value to 'ASYNC_EXECUTION_ABORTED'. > As per our discussion I have modified

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Backgrid StringDepsCell

Hi Ashesh, Yes, agreed. This implementation limits us to use only String Cell. So, I have modified the patch as you suggested. Please find the attachment for the same. Thanks, Khushboo On Fri, Apr 1, 2016 at 2:59 PM, Ashesh Vashi wrote: > Hi Khushboo, > > I am reluctant to use this code as it

Re: [pgadmin-hackers] [pgAdmin4][Patch] Add formatted error message support in psycopg2

Hi Akshay, I've update the patch a little bit as discussed offline. Also, renamed the variable 'is_cancel_transaction' to 'execution_aborted', and enum value to 'ASYNC_EXECUTION_ABORTED'. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company

Re: [pgadmin-hackers] Tree reload & panel close issue after saving new node on server [pgadmin4]

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Thu, Mar 31, 2016 at 1:34 PM, Harshal Dhumal < harshal.dhu...@enterprisedb

[pgadmin-hackers] pgAdmin 4 commit: Allow to close the create/edit dialog after successfu

Allow to close the create/edit dialog after successful 'save' operation. Some of the nodes do not return id as result, when they were created. Modified the logic to allow to open the parent node in such conditions. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Collection Control Fixes

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Mon, Mar 28, 2016 at 2:52 PM, Khushboo Vashi < khushboo.va...@enterprisedb

[pgadmin-hackers] pgAdmin 4 commit: Resolved few issues in the collection controls. Uniqu

Resolved few issues in the collection controls. UniqueCollectionControl was not honouring the change events after execution of the function - 'render' more than one time. Change the label of the Add button to make it consistent with the Unique Collection Control. Branch -- master Details

Re: [pgadmin-hackers] PATCH: Fixed select2 control template [pgAdmin4]

On Fri, Mar 25, 2016 at 5:43 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix backform Select2 control template. > > *Issue:* It was not rendering value properly. > Thanks - committed. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enter

[pgadmin-hackers] pgAdmin 4 commit: Updated the template for the NodeAjaxOptionsControl,

Updated the template for the NodeAjaxOptionsControl, which was not honouring the disabled attribute due to missing quotes around values. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1a5eb0c41798aef835c0a6a5ff38b8da603cf2d0 Author: Murtuza Zab

Re: [pgadmin-hackers] Patch: Added select2cell editor for backgrid [pgAdmin4]

On Thu, Mar 31, 2016 at 12:27 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > We have added Select2Cell Editor for backgrid, eariler as it was not > present & causing issue in rendering in subnode control. > Looks good to me, but - have some feedback. 1. Can you please

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Backgrid StringDepsCell

Hi Khushboo, I am reluctant to use this code as it is. I would prefer you create just helper functions (i.e. initialize, remove) for the dependents in Backgrid.Cell, and then use them directly from the different cell itself. Because - this functionality limits us to us only with the string type.