Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

Hi Dave, Please find the attached patch file with below fix. - Remove the duplicate CSS and used the actual class for the debugger button toolbar. - As per the Ashesh's comment, previously we used 2 wcDocker instance to arrange the multiple tabs to main debugger panel. Now with this p

[pgadmin-hackers] pgAdmin 4 commit: Don't try to use the template engine's gettext on Jav

Don't try to use the template engine's gettext on Javascript variables, as it won't work as the templates are evaluated before any JS is executed. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=37699a982076a2e9cb2644d2e263a84f32f70f5a Author:

Re: [pgadmin-hackers] [pgAdmin4][patch]: String evaluation issue

Thanks, applied. On Monday, April 18, 2016, Neel Patel wrote: > Hi, > > Please find attached patch file containing the fix for the below issue. > This issue is reported by Dave during the debugger code review and we have > removed the same issue from other files where we used. > > *Issue :- * >

Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

Hi On Monday, April 18, 2016, Neel Patel wrote: > Hi Dave, > > Please find inline comments with all the fixes. > Attached is the updated patch file. Do review it and let me know for any > comments. > > If you find any issues, let me know .Now, Working on the remaining TODOs > as mentioned in bel

[pgadmin-hackers] pgAdmin 4 commit: Various tweaks and improvements to the debugger

Various tweaks and improvements to the debugger Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4f8b018b39ab51df77298876fa8e3d5901ace577 Author: Neel Patel Modified Files -- web/pgadmin/tools/debugger/__init__.py | 70

[pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Hi Team, Dave, Attached herewith are two patches. pgadmin4-mac-bundle.patch - This includes scripts to build Mac app bundle and DMG for pgAdmin4. This is the tree of the generated app bundle: $ find pgAdmin4.app/ -maxdepth 3 -type d pgAdmin4.app/ pgAdmin4.app//ContentspgAdmin4.app//Contents/

Re: [pgadmin-hackers] PATCH: graphical explain

On Monday, April 18, 2016, Sanket Mehta wrote: > Hi Dave, > > Regarding your second comment, > Almost all the libraries that I have checked uses Jquery UI which is quite > heavy. > Please share your comments about using these libraries. > What have you found? > > > Meanwhile currently I have i

[pgadmin-hackers] [pgAdmin4][patch]: String evaluation issue

Hi, Please find attached patch file containing the fix for the below issue. This issue is reported by Dave during the debugger code review and we have removed the same issue from other files where we used. *Issue :- * When we use below string to form the error message then it will not work becau

[pgadmin-hackers] pgAdmin 4 commit: Adding missing query templates required for the serve

Adding missing query templates required for the server module. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=09cc78bd0a0d7ae3c2832ede35002cec27c238ee Modified Files -- .../templates/servers/sql/9.1_plus/stats.sql | 49 ++

Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

Hi Dave, Please find inline comments with all the fixes. Attached is the updated patch file. Do review it and let me know for any comments. If you find any issues, let me know .Now, Working on the remaining TODOs as mentioned in below email. Thanks, Neel Patel On Fri, Apr 15, 2016 at 2:09 AM, D

[pgadmin-hackers] pgAdmin 4 commit: Fix the properties toolbar at the top of the panel so

Fix the properties toolbar at the top of the panel so it's always visible. This patch also introduce a callback 'onCreate' for each panel, and frame, which will be called whenever a panel/frame is being created. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git