[pgadmin-hackers] pgAdmin 4 commit: Do not close the menu, when clicking on the menu with

2016-04-25 Thread Ashesh Vashi
Do not close the menu, when clicking on the menu with checkbox. Introduced a class 'noclose'. Then - menu-item having this class will not propograte the events to its parent, hence - it will not be closed. Some of the CSS applicable only to the immediate buttons only, and not the grand-children.

Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

2016-04-25 Thread Neel Patel
Hi, Please find attached patch file with below fixes. - Removed the "lineWrapping" option from the codemirror textarea because it was creating issue in the code folding. - Handle the values while depositing during debugging. - Properly handle the Array values while saving it to sqlite

Re: [pgadmin-hackers] PATCH: Graphincal explain integrated in sql editor

2016-04-25 Thread Ashesh Vashi
Hi Sanket, Please find the review comments. - Please add the missing 'explain.css'. - The application should be smart enough to handle conflict in options. i.e. Buffer is not a valid options without EXPLAIN ANALYZE. - A statement having EXPLAIN keywords with different format should at least

[pgadmin-hackers] pgAdmin 4 commit: Do not reset the driver registry when the 'load_drive

2016-04-25 Thread Ashesh Vashi
Do not reset the driver registry when the 'load_driver' method of DriverRegistry is executed second time. Also, initialize the driver before registering different blueprints, which uses those driver inside them. Thanks Khushboo for reporting the issue. Branch -- master Details --- http:

Re: [pgadmin-hackers] PATCH: Graphincal explain integrated in sql editor

2016-04-25 Thread Sanket Mehta
Hi, This patch includes the patch sent earlier for stand alone graphical explain. And also "horizontal lines are not proper" bug is fixed in the same which was reported by Dave in previous patch. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Thu, Apr 21, 2016 at 8:38 PM, Sanket Meh

[pgadmin-hackers] pgAdmin 4 commit: background-position-x and background-position-y are n

2016-04-25 Thread Ashesh Vashi
background-position-x and background-position-y are not supported on the browser, using background-position instead which is supported in all the supported browsers. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=52aa32a4d2ba0ea76e34706db9e42dd

Re: [pgadmin-hackers] pgAdmin4 download

2016-04-25 Thread Ashesh Vashi
On Wed, Apr 20, 2016 at 8:19 PM, Meet Bhagdev wrote: > Hello team, > > I heard about pgAdmin4 at pgConf yesterday. I am super excited to check it > out and wanted to know how do I download it :) Do you have instructions for > downloading pdAdmin4 Windows and OSX? > It is not yet available for the

Re: [pgadmin-hackers] Fixed fieldset control UI (pgAdmin4)

2016-04-25 Thread Ashesh Vashi
Thanks - applied. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Mon, Apr 18, 2016 at 11:56 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterpr

[pgadmin-hackers] pgAdmin4 download

2016-04-25 Thread Meet Bhagdev
Hello team, I heard about pgAdmin4 at pgConf yesterday. I am super excited to check it out and wanted to know how do I download it :) Do you have instructions for downloading pdAdmin4 Windows and OSX? Cheers, Meet

[pgadmin-hackers] pgAdmin 4 commit: Match the border style of the inline-fieldset with th

2016-04-25 Thread Ashesh Vashi
Match the border style of the inline-fieldset with the other control. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=973e2b1b4a0aa29c3ae5f1434f0c95d71be0b816 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/css/overr