Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Foreign Table Module

Hi Khushboo, Below are the observations. - When we create the new Foreign Table with column name and types then it shows NULL along with column name and type in properties tab. e.g. column_1 xml[] NULL - Once we inherits the table from another table then column and another

Re: [pgadmin-hackers] Minor issues

-- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Fri, Apr 29, 2016 at 11:52 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA patch for minor issues. > > Issues fixed: > > 1] Removed unwanted "{% if %}" from database 9.1 nodes.s

[pgadmin-hackers] Minor issues

Hi, PFA patch for minor issues. Issues fixed: 1] Removed unwanted "{% if %}" from database 9.1 nodes.sql 2] Fixed issue while removing select2cell fro backgrid. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB diff --git a/web/pgadmin/browser/server_g

Re: [pgadmin-hackers][pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl

Hi, More specifically to the issue. I am using SqlFieldControl in View for Definition Field which takes default height of 300px which is set by Control as default height. but as per dave's suggestion on thread http://www.postgresql.org/message-id/ca+ocxozn++8sfqjwjz5qsfbxa7p-47apoholtsotpbk6n5v..

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

-- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Thu, Apr 28, 2016 at 2:22 PM, Dave Page wrote: > > > > On 27 Apr 2016, at 13:43, Thom Brown wrote: > > > > On 27 April 2016 at 10:22, Harshal Dhumal > > wrote: > >> > >> Hi, > >> > >> PFA attached patch

[pgadmin-hackers][pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl

Hi, The *SqlFieldControl* is setting default height for textarea, which is not needed. It should expand as needed as similar in *SqlTabControl*. Please find the attached patch, review it. Thanks Surinder Kumar remove_default_height_in_SqlFieldControl.patch Description: Binary data -- Sent vi

Re: [pgadmin-hackers][pgAdmin4][Patch]: File Manager & Backform FileControl

Hi Surinder, Please find additional comments as below. 1. In Windows OS, when we try to open the dialog with default preference value then it gives error as below. 2016-04-28 13:07:44,716: ERROR pgadmin:Exception on /file_manager/filemanager/2530270/ [POST] Traceback (most recent call

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

> On 27 Apr 2016, at 13:43, Thom Brown wrote: > > On 27 April 2016 at 10:22, Harshal Dhumal > wrote: >> >> Hi, >> >> PFA attached patches for table node and all table child nodes. >> >> This patch includes below nodes, >> >> 1) Table node -- Initial patch by Mu

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

On 27 April 2016 at 14:34, Thom Brown wrote: > On 27 April 2016 at 13:43, Thom Brown wrote: >> On 27 April 2016 at 10:22, Harshal Dhumal >> wrote: >>> >>> Hi, >>> >>> PFA attached patches for table node and all table child nodes. >>> >>> This patch includes below nodes, >>> >>> 1) Table node