Re: [pgadmin-hackers] New committer: Akshay Joshi

2016-05-06 Thread Fahar Abbas
Congratulations Akshay. On Fri, May 6, 2016 at 4:58 PM, Akshay Joshi wrote: > > > On Fri, May 6, 2016 at 1:54 PM, Dave Page wrote: > >> All, >> >> I'm pleased to announce that Akshay Joshi has been added to the >> pgAdmin 4 project as our newest committer. Akshay has been working on >> pgAdmin

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

2016-05-06 Thread Dave Page
Hi Thanks. I've applied the path fix patch. The second one needs a little work - I've attached an updated version to work from: - I've updated the README, and some of the default values. - I've removed the file type registration for .sql files. - Should we note that the user may need to run in

[pgadmin-hackers] pgAdmin 4 commit: Fix the runtime search path when running in a Mac App

2016-05-06 Thread Dave Page
Fix the runtime search path when running in a Mac App Bundle Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c8406a5994d7febedfbda8353dd98ba98d9e5872 Author: Sandeep Thakkar Modified Files -- runtime/Server.cpp | 2 +- 1 file change

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed an issue related to the Delete/Drop context Menu of the node

2016-05-06 Thread Dave Page
Thanks, committed. On Fri, May 6, 2016 at 10:41 AM, Khushboo Vashi wrote: > Hi, > > When we try to drop any node and the visibility of the Delete/Drop context > Menu of that node is having dependency on some function then, after deleting > that node object, it gives a JS error. > > Please find th

[pgadmin-hackers] pgAdmin 4 commit: Ensure delete/drop works without JS errors.

2016-05-06 Thread Dave Page
Ensure delete/drop works without JS errors. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e522ebbccaf699d93b57cd2a9b8a988b4165722c Author: Khushboo Vashi Modified Files -- web/pgadmin/browser/templates/browser/js/node.js | 6 +++-

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed an issue related to the Property dialogue buttons in IE 10

2016-05-06 Thread Dave Page
Thanks, applied. On Fri, May 6, 2016 at 2:45 PM, Khushboo Vashi wrote: > Hi, > > In IE (ver: 10), the Save/Reset buttons are not getting enabled even after > changing the fields. > > Please find the attached patch for the same. > > Thanks, > Khushboo > > > -- > Sent via pgadmin-hackers mailing li

Re: [pgadmin-hackers] PATCH: Initiale for "Restore Utility" [pgAdmin4]

2016-05-06 Thread Murtuza Zabuawala
Hi, PFA updated patch, I have fixed typo in argument template. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, May 6, 2016 at 6:56 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA initial patch for

[pgadmin-hackers] pgAdmin 4 commit: In IE10, the Save/Reset buttons are not getting enabl

2016-05-06 Thread Dave Page
In IE10, the Save/Reset buttons are not getting enabled after changing fields. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f3d05279a7afc7c5507be7ea34f6e4b763ef1c06 Author: Khushboo Vashi Modified Files -- web/pgadmin/browser/te

Re: [pgadmin-hackers] PATCH: Allow pgAdmin4 application to host over LAN

2016-05-06 Thread Dave Page
Thanks, patch committed. On Tue, Apr 26, 2016 at 12:09 PM, Murtuza Zabuawala wrote: > Hi, > > Given patch will allow user to host pgAdmin4 to host over LAN network by > default it hosts on localhost (using 'lo' adapter). > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterpris

[pgadmin-hackers] pgAdmin 4 commit: Allow Werkzeug to be configured to bind to adaptors o

2016-05-06 Thread Dave Page
Allow Werkzeug to be configured to bind to adaptors other than localhost for testing. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3eb51e93e70c9d7f5aa1ccfdb0e797cf968ec354 Author: Murtuza Zabuawala Modified Files -- web/config.

[pgadmin-hackers] pgAdmin 4 commit: Branch refs/heads/dashboards was removed

2016-05-06 Thread git
Branch refs/heads/dashboards was removed. -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Allow the server config to be reloaded.

2016-05-06 Thread Dave Page
Allow the server config to be reloaded. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4190933909c09d712fb65def8e4c28e2cdc9971b Author: Neel Patel Modified Files -- .../browser/server_groups/servers/__init__.py | 26 +

Re: [pgadmin-hackers] [pgAdmin4]: Reload Server Configuration

2016-05-06 Thread Dave Page
Thanks, patch applied. On Thu, May 5, 2016 at 2:36 PM, Neel Patel wrote: > Hi, > > Please find attached patch file to reload the server configuration. > > Do review it and let me know for any comments. > > Thanks, > Neel Patel > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@post

[pgadmin-hackers] pgAdmin 4 commit: Fix dependents/dependency icons.

2016-05-06 Thread Dave Page
Fix dependents/dependency icons. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=86c4dd06b5836a7eaa312cf3ed9dd91adc020c3a Author: Khushboo Vashi Modified Files -- web/pgadmin/static/css/wcDocker/Themes/pgadmin.css | 5 + 1 file

Re: [pgadmin-hackers] [pgAdmin4][Patch]: TODO File

2016-05-06 Thread Dave Page
Thanks, enhanced and committed. On Fri, May 6, 2016 at 11:39 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached patch for adding a TODO file. > > Thanks, > Khushboo > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription:

[pgadmin-hackers] pgAdmin 4 commit: Add a TODO list.

2016-05-06 Thread Dave Page
Add a TODO list. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=128070877afbd263112a3d693228d392ab0e083e Author: Khushboo Vashi Modified Files -- TODO.txt | 28 1 file changed, 28 insertions(+) -- Se

Re: [pgadmin-hackers] []pgAdmin4[Patch]: Dependencies Tab: Type Icon Issue fix

2016-05-06 Thread Dave Page
Thanks - committed, though I moved it to the wcDocker theme stylesheet as it was overriding a wc class. On Fri, May 6, 2016 at 1:17 PM, Khushboo Vashi wrote: > Hi, > > In the Dependencies tab, the Icon of the Type is not showing up. > Please find the attached patch for the same. > > Thanks, > Khu

[pgadmin-hackers] [pgAdmin4][Patch]: Fixed an issue related to the Property dialogue buttons in IE 10

2016-05-06 Thread Khushboo Vashi
Hi, In IE (ver: 10), the Save/Reset buttons are not getting enabled even after changing the fields. Please find the attached patch for the same. Thanks, Khushboo diff --git a/web/pgadmin/browser/templates/browser/js/node.js b/web/pgadmin/browser/templates/browser/js/node.js index 5810e74..6289c2

[pgadmin-hackers] PATCH: Initiale for "Restore Utility" [pgAdmin4]

2016-05-06 Thread Murtuza Zabuawala
Hi, PFA initial patch for restore utility. *Note:* This patch depends on File manager patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Restore_tool_v1.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pga

Re: [pgadmin-hackers] PATCH: Fixed typo in Server node

2016-05-06 Thread Dave Page
Thanks - applied. On Fri, May 6, 2016 at 11:14 AM, Murtuza Zabuawala wrote: > Hi, > > Looks like below given commit has left a typo in the code, I’m getting error > while updating any Server node, > > Commit: > 0628ee04 web/pgadmin/browser/server_groups/servers/__init__.py (Dave Page > 2016-05-05

[pgadmin-hackers] pgAdmin 4 commit: Fix a typo introduced in a merge.

2016-05-06 Thread Dave Page
Fix a typo introduced in a merge. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=94303867dd63ddf0a5dc35592ba7eccdb4deed68 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/browser/server_groups/servers/__init__.py | 2 +- 1 f

[pgadmin-hackers] pgAdmin 4 commit: First round of string review and cleanup.

2016-05-06 Thread Dave Page
First round of string review and cleanup. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=949e536bae8b297c2333478b6f377f5d637a53f2 Author: Karen Blatchley Modified Files -- .../browser/server_groups/servers/__init__.py | 20

[pgadmin-hackers] pgAdmin 4 commit: Fixed below review comments for QueryTool

2016-05-06 Thread Akshay Joshi
Fixed below review comments for QueryTool - The button bar be moved out into an HTML template - create.sql should perhaps be renamed to insert.sql - The "Add Row" button only works if you're on the last page of the resultset. - Use one wcDocker instead of two - Added support of code folding B

[pgadmin-hackers] pgAdmin 4 commit: Added dependency of messages 'pgadmin.browser.message

2016-05-06 Thread Akshay Joshi
Added dependency of messages 'pgadmin.browser.messages' in backfrom.pgadmin.js Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7867adaa5396d66a1fbb09e91cbb7d227e3a55df Modified Files -- web/pgadmin/static/js/backform.pgadmin.js | 2

Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

2016-05-06 Thread Akshay Joshi
On Mon, Apr 25, 2016 at 7:18 PM, Neel Patel wrote: > Hi, > > Please find attached patch file with below fixes. > >- Removed the "lineWrapping" option from the codemirror textarea >because it was creating issue in the code folding. >- Handle the values while depositing during debugging

[pgadmin-hackers] []pgAdmin4[Patch]: Dependencies Tab: Type Icon Issue fix

2016-05-06 Thread Khushboo Vashi
Hi, In the Dependencies tab, the Icon of the Type is not showing up. Please find the attached patch for the same. Thanks, Khushboo diff --git a/web/pgadmin/static/css/overrides.css b/web/pgadmin/static/css/overrides.css index 1927ff1..cbb7ff8 100755 --- a/web/pgadmin/static/css/overrides.css +++

[pgadmin-hackers] pgAdmin 4 commit: Fixed below review comments

2016-05-06 Thread Akshay Joshi
Fixed below review comments - Removed the "lineWrapping" option from the codemirror textarea because it was creating issue in the code folding. - Handle the values while depositing during debugging. - Properly handle the Array values while saving it to sqlite database and displayed in input dia

Re: [pgadmin-hackers] New committer: Akshay Joshi

2016-05-06 Thread Akshay Joshi
On Fri, May 6, 2016 at 1:54 PM, Dave Page wrote: > All, > > I'm pleased to announce that Akshay Joshi has been added to the > pgAdmin 4 project as our newest committer. Akshay has been working on > pgAdmin 3 for a number of years now, and has done some excellent work > on pgAdmin 4, being primari

[pgadmin-hackers] [pgAdmin4][patch]: Unable to create extension "postgis_topology" and "postgis_tiger_geocoder" installed through stack builder

2016-05-06 Thread Surinder Kumar
Hi, PFA patch to fix the issue: Unable to create extension "postgis_topology" and "postgis_tiger_geocoder", due to wrong schema name in generated SQL query. *For example*: It generates following query for '*postgis_toplology*' extension: CREATE EXTENSION *postgis_topology* SCHEMA *topology*; wh

[pgadmin-hackers] [pgAdmin4][Patch]: TODO File

2016-05-06 Thread Khushboo Vashi
Hi, Please find the attached patch for adding a TODO file. Thanks, Khushboo diff --git a/TODO.txt b/TODO.txt new file mode 100644 index 000..666edb8 --- /dev/null +++ b/TODO.txt @@ -0,0 +1,16 @@ +List of TODOs: +

[pgadmin-hackers] PATCH: Fixed typo in Server node

2016-05-06 Thread Murtuza Zabuawala
Hi, Looks like below given commit has left a typo in the code, I’m getting error while updating any Server node, *Commit:* 0628ee04 web/pgadmin/browser/server_groups/servers/__init__.py (Dave Page 2016-05-05 16:42:16 +0100 377) node=self.blueprint.generate_browser_node( *Error:* *retur

[pgadmin-hackers] [pgAdmin4][Patch]: Fixed an issue related to the Delete/Drop context Menu of the node

2016-05-06 Thread Khushboo Vashi
Hi, When we try to drop any node and the visibility of the Delete/Drop context Menu of that node is having dependency on some function then, after deleting that node object, it gives a JS error. Please find the attached patch to fix this issue. Thanks, Khushboo diff --git a/web/pgadmin/browser/t

Fwd: [pgadmin-hackers] [pgAdmin4] [Patch]: Grant Wizard

2016-05-06 Thread Surinder Kumar
Hi, PFA patch with following issues fixed: 1. As SqlTab Control is renamed to SqlCtrl, throws error on grant wizard close. it is Fixed. 2. Moved grant wizard specific css from wizard.css to grant_wizard.css. On Wed, Apr 13, 2016 at 8:41 PM, Dave Page wrote: > Hi > > On Fri, Apr 8, 2016 at 6:59

[pgadmin-hackers] pgAdmin 4 commit: Fix comment marker.

2016-05-06 Thread Dave Page
Fix comment marker. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1efba422bce770a0eea5290bfa425f8fe504de8a Modified Files -- web/pgadmin/misc/sql/static/js/sql.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via

Re: [pgadmin-hackers] New committer: Akshay Joshi

2016-05-06 Thread Khushboo Vashi
Congrats Akshay. On Fri, May 6, 2016 at 1:54 PM, Dave Page wrote: > All, > > I'm pleased to announce that Akshay Joshi has been added to the > pgAdmin 4 project as our newest committer. Akshay has been working on > pgAdmin 3 for a number of years now, and has done some excellent work > on pg

Re: [pgadmin-hackers] New committer: Akshay Joshi

2016-05-06 Thread Ashesh Vashi
On Fri, May 6, 2016 at 1:54 PM, Dave Page wrote: > All, > > I'm pleased to announce that Akshay Joshi has been added to the > pgAdmin 4 project as our newest committer. Akshay has been working on > pgAdmin 3 for a number of years now, and has done some excellent work > on pgAdmin 4, being primari

Re: [pgadmin-hackers] New committer: Akshay Joshi

2016-05-06 Thread Sanket Mehta
Congratulations Akshay...way to go...!!! Regards, Sanket Mehta Sr Software engineer Enterprisedb On Fri, May 6, 2016 at 2:25 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Congrats Akshay... Well deserved... keep it up > > Thanks > Surinder Kumar > > On Fri, May 6, 2016 at 2:01 P

Re: [pgadmin-hackers] New committer: Akshay Joshi

2016-05-06 Thread Surinder Kumar
Congrats Akshay... Well deserved... keep it up Thanks Surinder Kumar On Fri, May 6, 2016 at 2:01 PM, Neel Patel wrote: > Congratulations Akshay... Well deserved... !! > > Thanks, > Neel Patel > > On Fri, May 6, 2016 at 1:58 PM, Guillaume Lelarge > wrote: > >> Le 6 mai 2016 10:25 AM, "Dave Page

Re: [pgadmin-hackers] New committer: Akshay Joshi

2016-05-06 Thread Neel Patel
Congratulations Akshay... Well deserved... !! Thanks, Neel Patel On Fri, May 6, 2016 at 1:58 PM, Guillaume Lelarge wrote: > Le 6 mai 2016 10:25 AM, "Dave Page" a écrit : > > > > All, > > > > I'm pleased to announce that Akshay Joshi has been added to the > > pgAdmin 4 project as our newest com

Re: [pgadmin-hackers] New committer: Akshay Joshi

2016-05-06 Thread Guillaume Lelarge
Le 6 mai 2016 10:25 AM, "Dave Page" a écrit : > > All, > > I'm pleased to announce that Akshay Joshi has been added to the > pgAdmin 4 project as our newest committer. Akshay has been working on > pgAdmin 3 for a number of years now, and has done some excellent work > on pgAdmin 4, being primarily

[pgadmin-hackers] New committer: Akshay Joshi

2016-05-06 Thread Dave Page
All, I'm pleased to announce that Akshay Joshi has been added to the pgAdmin 4 project as our newest committer. Akshay has been working on pgAdmin 3 for a number of years now, and has done some excellent work on pgAdmin 4, being primarily responsible for the Query Tool amongst other work. Congrat

[pgadmin-hackers] pgAdmin 4 commit: Ensure we update the error message on dashboard grids

2016-05-06 Thread Dave Page
Ensure we update the error message on dashboard grids when it changes. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c3762c90594e2cbe51ba7154265f899674b47fb8 Modified Files -- web/pgadmin/dashboard/templates/dashboard/js/dashboard