Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi, Please find attached add-on patch for table's subnode rule. Apply this patch at end after applying previous patches in email thread. *Issue fixed*: "Do Instead" on Rule node under View/M-View node not working in properties mode. Unable to generate proper SQL. On Mon, May 16, 2016 at 7:02 PM,

[pgadmin-hackers] pgAdmin 4 commit: Link online help to dialogs

Link online help to dialogs Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1606f1d8e8aeaececa03050321aace5e3a54d6fc Modified Files -- docs/en_US/code-snippet.rst| 74 ++ .../databases/cast

Re: [pgadmin-hackers] [pgAdmin4][Patch]: CanDrop as a function not working

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Mon, May 16, 2016 at 8:11 PM, Surinder Kumar < surinder.ku...@enterprisedb

[pgadmin-hackers] pgAdmin 4 commit: Resolved an issue about missing 'canDrop' function ch

Resolved an issue about missing 'canDrop' function check for the browser tree nodes. Each individual node is responsible for introducing the 'canDrop' function/flag to decide whether the 'Delete/Drop' context menu should be enabled/disabled. In commit-id: 26aa5607ad8eb92591e732837e6aa1a0c48f62b3,

[pgadmin-hackers] [pgAdmin4][Patch]: CanDrop as a function not working

Hi, *Issue*: When we delete a node, it gets deleted successfully, but after that it binds each sub-nodes of particular node with canDrop method, then code throws javascript error. I found that it was caused because canDrop value is set to true by default in delete_obj callback(node.js), so the fu

[pgadmin-hackers] pgAdmin 4 commit: Fixed misc issues

Fixed misc issues Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d1e3237e2e3e72d396a9be4b45cd9b8b799d2444 Modified Files -- web/pgadmin/misc/file_manager/templates/file_manager/js/utility.js| 3 ++- web/pgadmin/static/css/overri

Re: [pgadmin-hackers] PATCH: FTS configuration node

Hi, Revised patch is attached with this mail. My response is inline. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Fri, May 13, 2016 at 6:20 PM, Akshay Joshi wrote: > Hi Sanket > > Below are my review comments: > > >- Add button should be disabled in Tokens tab while creating

[pgadmin-hackers] pgAdmin 4 commit: Show the error div only when it has some data within

Show the error div only when it has some data within it. Changed its colour for better attendtion. Reduced the margin-bottom for the backform-tab, so that - we can see the control well in the properties dialog. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi, PFA add-on patch for table and it's child node. (please apply this patch on version 6 patch) Murtuza and I fixed following issues: 1. SQL formatting 2. Vacuum grid should not be editable in properties mode. 3. Column datatype does not get displayed in the properties and edit mode. 4. Do not

[pgadmin-hackers] pgAdmin 4 commit: Check for valid object existence before checking its

Check for valid object existence before checking its session changed flag in the data model. Thanks Murtuza, and Harshal for reporting it. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8a7a8eb9aaa8f34d9370399069d74d50492206aa Modified Files

Re: [pgadmin-hackers] [pgAdmin4][Patch]: View and Materialised View Nodes

Hi Below are my review comments: - Definition box on the View dialogue not expanded as needed. It should expand on resize. - "Do Instead" on Rule node under View/M-View node not working. Unable to generate proper SQL. - I am still able to drop columns under view/mview node. - "S

Re: [pgadmin-hackers][pgAdmin4][Patch]: Load/Save file in query tool

Hi, Please find patch for issue "whenever we select file other than SQL/text file, it results into an unexpected error at server side." On Sat, May 14, 2016 at 3:45 PM, Ashesh Vashi wrote: > On Sat, May 14, 2016 at 3:37 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> >> >> O

[pgadmin-hackers] pgAdmin 4 commit: Fixed issue while using decode() without checking typ

Fixed issue while using decode() without checking type of the variable. Type maybe string or byte. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=76087f3df3d4cc1993fdfc679d942cd5a7c84602 Author: Ashesh Vashi Modified Files -- web

Re: [pgadmin-hackers] [pgAdmin4]: Initial patch for Import table

Hi Neel, As discussed, I am sending you the updated path for based on your new patch (sent personally, which included the background process integration). Also, the COPY Statement expects the file to be present on the server OS, hence - we should be using the '\copy' command of psql to do the job.